You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2017/12/01 22:49:55 UTC
Re: Review Request 64144: Made master acknowledge offer operation
updates when 'id' isn't set.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64144/#review192583
-----------------------------------------------------------
src/master/master.cpp
Lines 7500-7502 (patched)
<https://reviews.apache.org/r/64144/#comment270839>
Remove NONE case here.
- Greg Mann
On Nov. 29, 2017, 5:47 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64144/
> -----------------------------------------------------------
>
> (Updated Nov. 29, 2017, 5:47 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Gaston Kleiman, Jie Yu, and Jan Schlicht.
>
>
> Bugs: MESOS-8193
> https://issues.apache.org/jira/browse/MESOS-8193
>
>
> Repository: mesos
>
>
> Description
> -------
>
> When a framework does not request feedback about an operation,
> the master should acknowledge offer operation status updates
> to the agent so that the updates are not retried.
>
>
> Diffs
> -----
>
> src/common/protobuf_utils.hpp 6f991e86e46512d5a2bc4e67e160189fccb77f6a
> src/common/protobuf_utils.cpp c0ff306ae6c16cbba6fd08469b639b9f906c672b
> src/master/master.cpp 700e12433b0b66efc3f5dd296711c0f203a13144
>
>
> Diff: https://reviews.apache.org/r/64144/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Greg Mann
>
>