You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Amrit Sarkar (JIRA)" <ji...@apache.org> on 2018/01/08 12:18:00 UTC

[jira] [Comment Edited] (SOLR-11718) Deprecate CDCR Buffer APIs

    [ https://issues.apache.org/jira/browse/SOLR-11718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16312936#comment-16312936 ] 

Amrit Sarkar edited comment on SOLR-11718 at 1/8/18 12:17 PM:
--------------------------------------------------------------

Patch attached with documentation changes but {{CdcrReplicationHandlerTest}} is failing due to changed behavior of disabling Buffer permanently.

7 tests failed.
FAILED:  org.apache.solr.cloud.cdcr.CdcrReplicationHandlerTest.testReplicationWithBufferedUpdates
FAILED:  junit.framework.TestSuite.org.apache.solr.cloud.cdcr.CdcrReplicationHandlerTest
FAILED:  junit.framework.TestSuite.org.apache.solr.cloud.cdcr.CdcrReplicationHandlerTest
FAILED:  org.apache.solr.cloud.cdcr.CdcrReplicationHandlerTest.testPartialReplication
FAILED:  org.apache.solr.cloud.cdcr.CdcrReplicationHandlerTest.testFullReplication
FAILED:  org.apache.solr.cloud.cdcr.CdcrReplicationHandlerTest.testPartialReplicationAfterPeerSync
FAILED:  org.apache.solr.cloud.cdcr.CdcrReplicationHandlerTest.testPartialReplicationWithTruncatedTlog

Looking into studying and implement what should be intended behavior now.


was (Author: sarkaramrit2@gmail.com):
Patch attached with documentation changes but {{CdcrReplicationHandlerTest}} is failing due to changed behavior of disabling Tlogs permanently.

7 tests failed.
FAILED:  org.apache.solr.cloud.cdcr.CdcrReplicationHandlerTest.testReplicationWithBufferedUpdates
FAILED:  junit.framework.TestSuite.org.apache.solr.cloud.cdcr.CdcrReplicationHandlerTest
FAILED:  junit.framework.TestSuite.org.apache.solr.cloud.cdcr.CdcrReplicationHandlerTest
FAILED:  org.apache.solr.cloud.cdcr.CdcrReplicationHandlerTest.testPartialReplication
FAILED:  org.apache.solr.cloud.cdcr.CdcrReplicationHandlerTest.testFullReplication
FAILED:  org.apache.solr.cloud.cdcr.CdcrReplicationHandlerTest.testPartialReplicationAfterPeerSync
FAILED:  org.apache.solr.cloud.cdcr.CdcrReplicationHandlerTest.testPartialReplicationWithTruncatedTlog

Looking into studying and implement what should be intended behavior now.

> Deprecate CDCR Buffer APIs
> --------------------------
>
>                 Key: SOLR-11718
>                 URL: https://issues.apache.org/jira/browse/SOLR-11718
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: CDCR
>    Affects Versions: 7.1
>            Reporter: Amrit Sarkar
>             Fix For: master (8.0), 7.3
>
>         Attachments: SOLR-11718.patch
>
>
> Kindly see the discussion on SOLR-11652.
> Today, if we see the current CDCR documentation page, buffering is "disabled" by default in both source and target. We don't see any purpose served by Cdcr buffering and it is quite an overhead considering it can take a lot heap space (tlogs ptr) and forever retention of tlogs on the disk when enabled. Also today, even if we disable buffer from API on source , considering it was enabled at startup, tlogs are never purged on leader node of shards of source, refer jira: SOLR-11652



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org