You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/04/17 20:32:38 UTC

[GitHub] [beam] udim commented on a change in pull request #11449: Updates and clarifications on type safety.

udim commented on a change in pull request #11449: Updates and clarifications on type safety.
URL: https://github.com/apache/beam/pull/11449#discussion_r410453129
 
 

 ##########
 File path: sdks/python/apache_beam/examples/snippets/snippets_test_py3.py
 ##########
 @@ -44,7 +44,7 @@ def test_bad_types_annotations(self):
     # pylint: disable=expression-not-assigned
     # pylint: disable=unused-variable
     class FilterEvensDoFn(beam.DoFn):
-      def process(self, element, *unused_args, **unused_kwargs):
 
 Review comment:
   I put these `unused_` arguments because I ran this file through mypy and it was complaining about them not being there.
   PyCharm has similar complaints. Any solution to this?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services