You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Thomas Neidhart <th...@gmail.com> on 2013/11/11 22:12:11 UTC
[VOTE] Release of Commons Collections 4.0 based on RC3
Hi,
I'd like to call a vote for releasing Commons Collections 4.0 based on RC3.
Changes since RC2:
* [COLLECTIONS-499] Refactored the test framework for Bag
implementations to extend from "AbstractCollectionTest" by
decorating the concrete Bag instance with a CollectionBag or
CollectionSortedBag.
* [COLLECTIONS-498] "CollectionBag" will now also respect the
contract of the decorated bag in case a null argument is provided
to either removeAll or retainAll.
* [COLLECTIONS-497] Added bag decorator "CollectionSortedBag" which
decorates a SortedBag to make it comply with the Collection
contract.
* [COLLECTIONS-496] "UnmodifiableBoundedCollection" does now also
implement the marker interface "Unmodifiable" similar as all other
unmodifiable decorators.
* [COLLECTIONS-495] "UnmodifiableTrie#unmodifiableTrie(Trie)" will
not decorate again an already unmodifiable Trie. Also the return
type has been changed to "Trie" to be consistent with other
Unmodifiable decorators.
* [COLLECTIONS-494] Moved "Equator" interface to base package for
consistency. Thanks to Emmanuel Bourg.
* improved release notes with suggestions from Emmanuel Bourg
* added unit tests for TrieUtils and QueueUtils and factory methods
for all Unmodifiable decorators
* added more unit tests for the Queue interface
* cleanup of many test classes: removed unused imports, unneeded
constructors
Changes since RC1:
* release notes are now also included in the binary distribution
* removed spurious hashCode() method in AbstractPatriciaTrie, the
inherited one from AbstractMap will be used instead
Collections 4.0 RC3 is available for review here:
https://dist.apache.org/repos/dist/dev/commons/collections/
(svn revision 3477)
Maven artifacts are here:
https://repository.apache.org/content/repositories/orgapachecommons-118/org/apache/commons/commons-collections4/4.0/
The tag is here:
https://svn.apache.org/repos/asf/commons/proper/collections/tags/COLLECTIONS_4_0_RC3/
(svn revision 1540843)
Site:
http://people.apache.org/builds/commons/collections/4.0/RC3/
Details of changes can be found in the release notes:
https://dist.apache.org/repos/dist/dev/commons/collections/RELEASE-NOTES.txt
http://people.apache.org/builds/commons/collections/4.0/RC3/changes-report.html
Please review the release candidate and vote.
This vote will close no sooner than 72 hours from now.
[ ] +1 Release these artifacts
[ ] +0 OK, but...
[ ] -0 OK, but really should fix...
[ ] -1 I oppose this release because...
Note: the clirr report is generated against 4.0-alpha1 and it is also
highlighted in the release notes that this release is not compatible
with any previous release.
Note2: there have been reports in the past that some unit tests fail
with certain versions of the IBM Java 6 VM. Some tests have been
disabled when run with a IBM Java 6 VM due to some bugs in the
java.util.TreeMap implementation, but it may still fail for other versions.
Thank you for your reviews,
Thomas
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE] Release of Commons Collections 4.0 based on RC3
Posted by Jörg Schaible <jo...@gmx.de>.
Hi Thomas,
Thomas Neidhart wrote:
> On 11/13/2013 11:04 AM, Jörg Schaible wrote:
>> Hi Thomas,
>>
>> Thomas Neidhart wrote:
>>
>>> Hi Joerg,
>>>
>>> the failure for JDK 1.8 is clear: this version updated the Map interface
>>> with a new method boolean remove(Object, Object) which clashes with the
>>> ones in MultiValueMap and MultiMap. We should change the return type to
>>> be compatible.
>>
>> This means unfortunately that I will vote with -1. If this new method
>> stays in J8, we would have to make an incompatible change ourselves for
>> J8- compatibility :-(
>>
>>> For IBM JDK 6: I did already ignore several tests (due to problems with
>>> the TreeMap implementation there) if run with this JVM but obviously
>>> something has changed since then, need to check.
>>
>> I can tell you this evening (in ~6 hours), which version I used exactly.
>> However, IIRC the number of executed tests were for me always the same.
>> Maybe the check for IBM JDK 1.6 failed?
>>
>>>
>>> For IBM JDK 5: It only fails to compile the tests, but I could not yet
>>> figure out why.
>>
>> Same to me. BTW: I forget in my list below to mention that I can run with
>> IBM JDK 1.5 all tests successfully if I use the compiled classes of Sun
>> JDK 1.5.
>
> The compiler does not like constructs like this:
>
> for (@SuppressWarnings("unused") final String element : array) {
> iterator.next();
> }
>
> Removing the @SuppressWarnings solves it.
> I guess this creates an internal compiler error, that's why we don't see
> any message / error.
Gosh. This is so stupid. Alas, trunk compiles now. All tests are fine.
Cheers,
Jörg
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE] Release of Commons Collections 4.0 based on RC3
Posted by Thomas Neidhart <th...@gmail.com>.
On 11/13/2013 11:04 AM, Jörg Schaible wrote:
> Hi Thomas,
>
> Thomas Neidhart wrote:
>
>> Hi Joerg,
>>
>> the failure for JDK 1.8 is clear: this version updated the Map interface
>> with a new method boolean remove(Object, Object) which clashes with the
>> ones in MultiValueMap and MultiMap. We should change the return type to be
>> compatible.
>
> This means unfortunately that I will vote with -1. If this new method stays
> in J8, we would have to make an incompatible change ourselves for J8-
> compatibility :-(
>
>> For IBM JDK 6: I did already ignore several tests (due to problems with
>> the TreeMap implementation there) if run with this JVM but obviously
>> something has changed since then, need to check.
>
> I can tell you this evening (in ~6 hours), which version I used exactly.
> However, IIRC the number of executed tests were for me always the same.
> Maybe the check for IBM JDK 1.6 failed?
>
>>
>> For IBM JDK 5: It only fails to compile the tests, but I could not yet
>> figure out why.
>
> Same to me. BTW: I forget in my list below to mention that I can run with
> IBM JDK 1.5 all tests successfully if I use the compiled classes of Sun JDK
> 1.5.
The compiler does not like constructs like this:
for (@SuppressWarnings("unused") final String element : array) {
iterator.next();
}
Removing the @SuppressWarnings solves it.
I guess this creates an internal compiler error, that's why we don't see
any message / error.
Thomas
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE] Release of Commons Collections 4.0 based on RC3
Posted by Thomas Neidhart <th...@gmail.com>.
On 11/13/2013 10:59 PM, Jörg Schaible wrote:
> Thomas Neidhart wrote:
>
>> On 11/13/2013 05:39 PM, Jörg Schaible wrote:
>>> Jörg Schaible wrote:
>>>
>>>> Hi Thomas,
>>>>
>>>> Thomas Neidhart wrote:
>
> [snip]
>
>>>>> For IBM JDK 6: I did already ignore several tests (due to problems with
>>>>> the TreeMap implementation there) if run with this JVM but obviously
>>>>> something has changed since then, need to check.
>>>>
>>>> I can tell you this evening (in ~6 hours), which version I used exactly.
>>>> However, IIRC the number of executed tests were for me always the same.
>>>> Maybe the check for IBM JDK 1.6 failed?
>>>
>>> ===================== %< ===============
>>> $ java -version
>>> java version "1.6.0"
>>> Java(TM) SE Runtime Environment (build pxa6460sr9fp2-20110625_01(SR9
>>> FP2)) IBM J9 VM (build 2.4, JRE 1.6.0 IBM J9 2.4 Linux amd64-64
>>> jvmxa6460sr9-20110624_85526 (JIT enabled, AOT enabled)
>>> J9VM - 20110624_085526
>>> JIT - r9_20101028_17488ifx17
>>> GC - 20101027_AA)
>>> JCL - 20110530_01
>>> ===================== %< ===============
>>
>> I tested with this version:
>>
>> java version "1.6.0"
>> Java(TM) SE Runtime Environment (build pxi3260sr12-20121025_01(SR12))
>> IBM J9 VM (build 2.4, JRE 1.6.0 IBM J9 2.4 Linux x86-32
>> jvmxi3260sr12-20121024_126067 (JIT enabled, AOT enabled)
>> J9VM - 20121024_126067
>> JIT - r9_20120914_26057
>> GC - 20120928_AA)
>> JCL - 20121014_01
>>
>> and got 3 failures from a recently added test, for which I forgot to add
>> the ignore rules.
>>
>> Could you output me the result of this for your IBM JDK version:
>>
>> final String vmName = System.getProperty("java.vm.name");
>> final String version = System.getProperty("java.version");
>
> =========================== %< ===========================
> java.specification.version: 1.6
> java.specification.vendor: Sun Microsystems Inc.
> java.specification.name: Java Platform API Specification
> java.vm.vendor: IBM Corporation
> java.vendor: IBM Corporation
> java.vm.name: IBM J9 VM
> =========================== %< ===========================
>
> Failing and erroneous tests:
>
> =========================== %< ===========================
> Failed tests:
> AbstractMapTest$TestMapEntrySet.testMapEntrySetIteratorEntrySetValue:1656
> expected:<true> but was:<false>
> AbstractMapTest$TestMapEntrySet.testMapEntrySetIteratorEntrySetValue:1656
> expected:<true> but was:<false>
> AbstractMapTest$TestMapEntrySet>AbstractCollectionTest.testCollectionToArray2:1097
> toArrays should be equal expected:
> <[Entry(key=again [28], value=againv, parent=all [14], left=again [28],
> right=all [14], predecessor=again [28]), Entry(key=all [14], value=allv,
> parent=foo [13], left=again [28], right=bar [28], predecessor=again [28]),
> Entry(key=bar [28], value=barv, parent=all [14], left=baz [44], right=blah
> [9], predecessor=baz [44]), Entry(key=baz [44], value=bazv, parent=bar [28],
> left=bar [28], right=baz [44], predecessor=baz [44]), Entry(key=blah [9],
> value=blahv, parent=ROOT, left=ROOT, right=tmp [11], predecessor=bar [28]),
> Entry(key=foo [13], value=foov, parent=hello [12], left=all [14], right=gosh
> [15], predecessor=gosh [15])]> but was:<[Entry(key=foo [13], value=foov,
> parent=hello [12], left=all [14], right=gosh [15], predecessor=gosh [15]),
> Entry(key=blah [9], value=blahv, parent=ROOT, left=ROOT, right=tmp [11],
> predecessor=bar [28]), Entry(key=baz [44], value=bazv, parent=bar [28],
> left=bar [28], right=baz [44], predecessor=baz [44]), Entry(key=bar [28],
> value=barv, parent=all [14], left=baz [44], right=blah [9], predecessor=baz
> [44]), Entry(key=all [14], value=allv, parent=foo [13], left=again [28],
> right=bar [28], predecessor=again [28]), Entry(key=again [28], value=againv,
> parent=all [14], left=again [28], right=all [14], predecessor=again [28])]>
> AbstractMapTest$TestMapEntrySet>AbstractCollectionTest.testCollectionToArray2:1097
> toArrays should be equal expected:<[Entry(key=key2 [58], value=value,
> parent=key [14], left=key [14], right=key2 [58], predecessor=key2 [58]),
> Entry(key=nonnullkey [13], value=value, parent=hello [12], left=key [14],
> right=nonnullkey [13], predecessor=nonnullkey [13]), Entry(key=see [13],
> value=seev, parent=you [12], left=see [13], right=we'll [14],
> predecessor=see [13]), Entry(key=tmp [11], value=tmpv, parent=blah [9],
> left=hello [12], right=you [12], predecessor=we'll [14]), Entry(key=we'll
> [14], value=we'llv, parent=see [13], left=tmp [11], right=we'll [14],
> predecessor=we'll [14]), Entry(key=you [12], value=youv, parent=tmp [11],
> left=see [13], right=you [12], predecessor=you [12])]> but
> was:<[Entry(key=you [12], value=youv, parent=tmp [11], left=see [13],
> right=you [12], predecessor=you [12]), Entry(key=we'll [14], value=we'llv,
> parent=see [13], left=tmp [11], right=we'll [14], predecessor=we'll [14]),
> Entry(key=tmp [11], value=tmpv, parent=blah [9], left=hello [12], right=you
> [12], predecessor=we'll [14]), Entry(key=see [13], value=seev, parent=you
> [12], left=see [13], right=we'll [14], predecessor=see [13]),
> Entry(key=nonnullkey [13], value=value, parent=hello [12], left=key [14],
> right=nonnullkey [13], predecessor=nonnullkey [13]), Entry(key=key2 [58],
> value=value, parent=key [14], left=key [14], right=key2 [58],
> predecessor=key2 [58])]>
> AbstractMapTest$TestMapEntrySet>AbstractCollectionTest.testCollectionToArray2:1097
> toArrays should be equal expected:<[Entry(key=baz [44], value=bazv,
> parent=bar [28], left=bar [28], right=baz [44], predecessor=baz [44]),
> Entry(key=blah [9], value=blahv, parent=ROOT, left=ROOT, right=tmp [11],
> predecessor=bar [28]), Entry(key=foo [13], value=foov, parent=hello [12],
> left=all [14], right=gosh [15], predecessor=gosh [15]), Entry(key=gee [28],
> value=geev, parent=gosh [15], left=gee [28], right=golly [43],
> predecessor=gee [28]), Entry(key=golly [43], value=gollyv, parent=gee [28],
> left=goodbye [46], right=gosh [15], predecessor=goodbye [46]),
> Entry(key=goodbye [46], value=goodbyev, parent=golly [43], left=golly [43],
> right=goodbye [46], predecessor=goodbye [46]), Entry(key=gosh [15],
> value=goshv, parent=foo [13], left=foo [13], right=gee [28],
> predecessor=golly [43]), Entry(key=hello [12], value=hellov, parent=tmp
> [11], left=foo [13], right=nonnullkey [13], predecessor=key [14]),
> Entry(key=key [14], value=null, parent=nonnullkey [13], left=hello [12],
> right=key2 [58], predecessor=key2 [58]), Entry(key=key2 [58], value=value,
> parent=key [14], left=key [14], right=key2 [58], predecessor=key2 [58]),
> Entry(key=nonnullkey [13], value=value, parent=hello [12], left=key [14],
> right=nonnullkey [13], predecessor=nonnullkey [13]), Entry(key=see [13],
> value=seev, parent=you [12], left=see [13], right=we'll [14],
> predecessor=see [13])]> but was:<[Entry(key=see [13], value=seev, parent=you
> [12], left=see [13], right=we'll [14], predecessor=see [13]),
> Entry(key=nonnullkey [13], value=value, parent=hello [12], left=key [14],
> right=nonnullkey [13], predecessor=nonnullkey [13]), Entry(key=key2 [58],
> value=value, parent=key [14], left=key [14], right=key2 [58],
> predecessor=key2 [58]), Entry(key=key [14], value=null, parent=nonnullkey
> [13], left=hello [12], right=key2 [58], predecessor=key2 [58]),
> Entry(key=hello [12], value=hellov, parent=tmp [11], left=foo [13],
> right=nonnullkey [13], predecessor=key [14]), Entry(key=gosh [15],
> value=goshv, parent=foo [13], left=foo [13], right=gee [28],
> predecessor=golly [43]), Entry(key=goodbye [46], value=goodbyev,
> parent=golly [43], left=golly [43], right=goodbye [46], predecessor=goodbye
> [46]), Entry(key=golly [43], value=gollyv, parent=gee [28], left=goodbye
> [46], right=gosh [15], predecessor=goodbye [46]), Entry(key=gee [28],
> value=geev, parent=gosh [15], left=gee [28], right=golly [43],
> predecessor=gee [28]), Entry(key=foo [13], value=foov, parent=hello [12],
> left=all [14], right=gosh [15], predecessor=gosh [15]), Entry(key=blah [9],
> value=blahv, parent=ROOT, left=ROOT, right=tmp [11], predecessor=bar [28]),
> Entry(key=baz [44], value=bazv, parent=bar [28], left=bar [28], right=baz
> [44], predecessor=baz [44])]>
>
> Tests in error:
> AbstractSortedMapTest$TestTailMap>AbstractMapTest.testMapRemove:1002-
>> AbstractSortedMapTest$TestViewMap.verify:138->AbstractMapTest.verify:1942-
>> AbstractMapTest.verifyValues:2013 » ArrayIndexOutOfBounds
> AbstractMapTest$TestMapEntrySet>AbstractCollectionTest.testCollectionIteratorRemove:834-
>> verify:1707 » ArrayIndexOutOfBounds
> AbstractMapTest$TestMapEntrySet>AbstractCollectionTest.testCollectionRemoveAll:930-
>> verify:1707 » ArrayIndexOutOfBounds
> AbstractMapTest$TestMapKeySet>AbstractCollectionTest.testCollectionIteratorRemove:834-
>> verify:1786 » ArrayIndexOutOfBounds
> AbstractMapTest$TestMapKeySet>AbstractCollectionTest.testCollectionRemoveAll:930-
>> verify:1786 » ArrayIndexOutOfBounds
> AbstractSortedMapTest$TestTailMap>AbstractMapTest.testMapRemove:1002-
>> AbstractSortedMapTest$TestViewMap.verify:138->AbstractMapTest.verify:1942-
>> AbstractMapTest.verifyValues:2013 » ArrayIndexOutOfBounds
> AbstractMapTest$TestMapEntrySet>AbstractCollectionTest.testCollectionIteratorRemove:834-
>> verify:1707 » ArrayIndexOutOfBounds
> AbstractMapTest$TestMapEntrySet>AbstractCollectionTest.testCollectionRemoveAll:930-
>> verify:1707 » ArrayIndexOutOfBounds
> AbstractMapTest$TestMapKeySet>AbstractCollectionTest.testCollectionIteratorRemove:834-
>> verify:1786 » ArrayIndexOutOfBounds
> AbstractMapTest$TestMapKeySet>AbstractCollectionTest.testCollectionRemoveAll:930-
>> verify:1786 » ArrayIndexOutOfBounds
> AbstractSortedMapTest$TestTailMap>AbstractMapTest.testMapRemove:1002-
>> AbstractSortedMapTest$TestViewMap.verify:138->AbstractMapTest.verify:1942-
>> AbstractMapTest.verifyValues:2013 » ArrayIndexOutOfBounds
> AbstractMapTest$TestMapEntrySet>AbstractCollectionTest.testCollectionIteratorRemove:834-
>> verify:1707 » ArrayIndexOutOfBounds
> AbstractMapTest$TestMapEntrySet>AbstractCollectionTest.testCollectionRemoveAll:930-
>> verify:1707 » ArrayIndexOutOfBounds
> AbstractMapTest$TestMapKeySet>AbstractCollectionTest.testCollectionIteratorRemove:834-
>> verify:1786 » ArrayIndexOutOfBounds
> AbstractMapTest$TestMapKeySet>AbstractCollectionTest.testCollectionRemoveAll:930-
>> verify:1786 » ArrayIndexOutOfBounds
> =========================== %< ===========================
Hi Joerg,
it looks like the difference in the test results is due to a more recent
version of the JDK. Previously I tested with SR12 and excluded all
failing tests. I downloaded now also SR15 and got the same errors as
you, so it seems more bugs have been introduced with recent SRs.
I will add these also to the exclusion lists.
The issue with Java 8 is still open, I would be happy with a method
change as posted in another thread, but will wait if there is some
answer on the openjdk mailinglist.
Thomas
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE] Release of Commons Collections 4.0 based on RC3
Posted by Jörg Schaible <jo...@gmx.de>.
Thomas Neidhart wrote:
> On 11/13/2013 05:39 PM, Jörg Schaible wrote:
>> Jörg Schaible wrote:
>>
>>> Hi Thomas,
>>>
>>> Thomas Neidhart wrote:
[snip]
>>>> For IBM JDK 6: I did already ignore several tests (due to problems with
>>>> the TreeMap implementation there) if run with this JVM but obviously
>>>> something has changed since then, need to check.
>>>
>>> I can tell you this evening (in ~6 hours), which version I used exactly.
>>> However, IIRC the number of executed tests were for me always the same.
>>> Maybe the check for IBM JDK 1.6 failed?
>>
>> ===================== %< ===============
>> $ java -version
>> java version "1.6.0"
>> Java(TM) SE Runtime Environment (build pxa6460sr9fp2-20110625_01(SR9
>> FP2)) IBM J9 VM (build 2.4, JRE 1.6.0 IBM J9 2.4 Linux amd64-64
>> jvmxa6460sr9-20110624_85526 (JIT enabled, AOT enabled)
>> J9VM - 20110624_085526
>> JIT - r9_20101028_17488ifx17
>> GC - 20101027_AA)
>> JCL - 20110530_01
>> ===================== %< ===============
>
> I tested with this version:
>
> java version "1.6.0"
> Java(TM) SE Runtime Environment (build pxi3260sr12-20121025_01(SR12))
> IBM J9 VM (build 2.4, JRE 1.6.0 IBM J9 2.4 Linux x86-32
> jvmxi3260sr12-20121024_126067 (JIT enabled, AOT enabled)
> J9VM - 20121024_126067
> JIT - r9_20120914_26057
> GC - 20120928_AA)
> JCL - 20121014_01
>
> and got 3 failures from a recently added test, for which I forgot to add
> the ignore rules.
>
> Could you output me the result of this for your IBM JDK version:
>
> final String vmName = System.getProperty("java.vm.name");
> final String version = System.getProperty("java.version");
=========================== %< ===========================
java.specification.version: 1.6
java.specification.vendor: Sun Microsystems Inc.
java.specification.name: Java Platform API Specification
java.vm.vendor: IBM Corporation
java.vendor: IBM Corporation
java.vm.name: IBM J9 VM
=========================== %< ===========================
Failing and erroneous tests:
=========================== %< ===========================
Failed tests:
AbstractMapTest$TestMapEntrySet.testMapEntrySetIteratorEntrySetValue:1656
expected:<true> but was:<false>
AbstractMapTest$TestMapEntrySet.testMapEntrySetIteratorEntrySetValue:1656
expected:<true> but was:<false>
AbstractMapTest$TestMapEntrySet>AbstractCollectionTest.testCollectionToArray2:1097
toArrays should be equal expected:
<[Entry(key=again [28], value=againv, parent=all [14], left=again [28],
right=all [14], predecessor=again [28]), Entry(key=all [14], value=allv,
parent=foo [13], left=again [28], right=bar [28], predecessor=again [28]),
Entry(key=bar [28], value=barv, parent=all [14], left=baz [44], right=blah
[9], predecessor=baz [44]), Entry(key=baz [44], value=bazv, parent=bar [28],
left=bar [28], right=baz [44], predecessor=baz [44]), Entry(key=blah [9],
value=blahv, parent=ROOT, left=ROOT, right=tmp [11], predecessor=bar [28]),
Entry(key=foo [13], value=foov, parent=hello [12], left=all [14], right=gosh
[15], predecessor=gosh [15])]> but was:<[Entry(key=foo [13], value=foov,
parent=hello [12], left=all [14], right=gosh [15], predecessor=gosh [15]),
Entry(key=blah [9], value=blahv, parent=ROOT, left=ROOT, right=tmp [11],
predecessor=bar [28]), Entry(key=baz [44], value=bazv, parent=bar [28],
left=bar [28], right=baz [44], predecessor=baz [44]), Entry(key=bar [28],
value=barv, parent=all [14], left=baz [44], right=blah [9], predecessor=baz
[44]), Entry(key=all [14], value=allv, parent=foo [13], left=again [28],
right=bar [28], predecessor=again [28]), Entry(key=again [28], value=againv,
parent=all [14], left=again [28], right=all [14], predecessor=again [28])]>
AbstractMapTest$TestMapEntrySet>AbstractCollectionTest.testCollectionToArray2:1097
toArrays should be equal expected:<[Entry(key=key2 [58], value=value,
parent=key [14], left=key [14], right=key2 [58], predecessor=key2 [58]),
Entry(key=nonnullkey [13], value=value, parent=hello [12], left=key [14],
right=nonnullkey [13], predecessor=nonnullkey [13]), Entry(key=see [13],
value=seev, parent=you [12], left=see [13], right=we'll [14],
predecessor=see [13]), Entry(key=tmp [11], value=tmpv, parent=blah [9],
left=hello [12], right=you [12], predecessor=we'll [14]), Entry(key=we'll
[14], value=we'llv, parent=see [13], left=tmp [11], right=we'll [14],
predecessor=we'll [14]), Entry(key=you [12], value=youv, parent=tmp [11],
left=see [13], right=you [12], predecessor=you [12])]> but
was:<[Entry(key=you [12], value=youv, parent=tmp [11], left=see [13],
right=you [12], predecessor=you [12]), Entry(key=we'll [14], value=we'llv,
parent=see [13], left=tmp [11], right=we'll [14], predecessor=we'll [14]),
Entry(key=tmp [11], value=tmpv, parent=blah [9], left=hello [12], right=you
[12], predecessor=we'll [14]), Entry(key=see [13], value=seev, parent=you
[12], left=see [13], right=we'll [14], predecessor=see [13]),
Entry(key=nonnullkey [13], value=value, parent=hello [12], left=key [14],
right=nonnullkey [13], predecessor=nonnullkey [13]), Entry(key=key2 [58],
value=value, parent=key [14], left=key [14], right=key2 [58],
predecessor=key2 [58])]>
AbstractMapTest$TestMapEntrySet>AbstractCollectionTest.testCollectionToArray2:1097
toArrays should be equal expected:<[Entry(key=baz [44], value=bazv,
parent=bar [28], left=bar [28], right=baz [44], predecessor=baz [44]),
Entry(key=blah [9], value=blahv, parent=ROOT, left=ROOT, right=tmp [11],
predecessor=bar [28]), Entry(key=foo [13], value=foov, parent=hello [12],
left=all [14], right=gosh [15], predecessor=gosh [15]), Entry(key=gee [28],
value=geev, parent=gosh [15], left=gee [28], right=golly [43],
predecessor=gee [28]), Entry(key=golly [43], value=gollyv, parent=gee [28],
left=goodbye [46], right=gosh [15], predecessor=goodbye [46]),
Entry(key=goodbye [46], value=goodbyev, parent=golly [43], left=golly [43],
right=goodbye [46], predecessor=goodbye [46]), Entry(key=gosh [15],
value=goshv, parent=foo [13], left=foo [13], right=gee [28],
predecessor=golly [43]), Entry(key=hello [12], value=hellov, parent=tmp
[11], left=foo [13], right=nonnullkey [13], predecessor=key [14]),
Entry(key=key [14], value=null, parent=nonnullkey [13], left=hello [12],
right=key2 [58], predecessor=key2 [58]), Entry(key=key2 [58], value=value,
parent=key [14], left=key [14], right=key2 [58], predecessor=key2 [58]),
Entry(key=nonnullkey [13], value=value, parent=hello [12], left=key [14],
right=nonnullkey [13], predecessor=nonnullkey [13]), Entry(key=see [13],
value=seev, parent=you [12], left=see [13], right=we'll [14],
predecessor=see [13])]> but was:<[Entry(key=see [13], value=seev, parent=you
[12], left=see [13], right=we'll [14], predecessor=see [13]),
Entry(key=nonnullkey [13], value=value, parent=hello [12], left=key [14],
right=nonnullkey [13], predecessor=nonnullkey [13]), Entry(key=key2 [58],
value=value, parent=key [14], left=key [14], right=key2 [58],
predecessor=key2 [58]), Entry(key=key [14], value=null, parent=nonnullkey
[13], left=hello [12], right=key2 [58], predecessor=key2 [58]),
Entry(key=hello [12], value=hellov, parent=tmp [11], left=foo [13],
right=nonnullkey [13], predecessor=key [14]), Entry(key=gosh [15],
value=goshv, parent=foo [13], left=foo [13], right=gee [28],
predecessor=golly [43]), Entry(key=goodbye [46], value=goodbyev,
parent=golly [43], left=golly [43], right=goodbye [46], predecessor=goodbye
[46]), Entry(key=golly [43], value=gollyv, parent=gee [28], left=goodbye
[46], right=gosh [15], predecessor=goodbye [46]), Entry(key=gee [28],
value=geev, parent=gosh [15], left=gee [28], right=golly [43],
predecessor=gee [28]), Entry(key=foo [13], value=foov, parent=hello [12],
left=all [14], right=gosh [15], predecessor=gosh [15]), Entry(key=blah [9],
value=blahv, parent=ROOT, left=ROOT, right=tmp [11], predecessor=bar [28]),
Entry(key=baz [44], value=bazv, parent=bar [28], left=bar [28], right=baz
[44], predecessor=baz [44])]>
Tests in error:
AbstractSortedMapTest$TestTailMap>AbstractMapTest.testMapRemove:1002-
>AbstractSortedMapTest$TestViewMap.verify:138->AbstractMapTest.verify:1942-
>AbstractMapTest.verifyValues:2013 » ArrayIndexOutOfBounds
AbstractMapTest$TestMapEntrySet>AbstractCollectionTest.testCollectionIteratorRemove:834-
>verify:1707 » ArrayIndexOutOfBounds
AbstractMapTest$TestMapEntrySet>AbstractCollectionTest.testCollectionRemoveAll:930-
>verify:1707 » ArrayIndexOutOfBounds
AbstractMapTest$TestMapKeySet>AbstractCollectionTest.testCollectionIteratorRemove:834-
>verify:1786 » ArrayIndexOutOfBounds
AbstractMapTest$TestMapKeySet>AbstractCollectionTest.testCollectionRemoveAll:930-
>verify:1786 » ArrayIndexOutOfBounds
AbstractSortedMapTest$TestTailMap>AbstractMapTest.testMapRemove:1002-
>AbstractSortedMapTest$TestViewMap.verify:138->AbstractMapTest.verify:1942-
>AbstractMapTest.verifyValues:2013 » ArrayIndexOutOfBounds
AbstractMapTest$TestMapEntrySet>AbstractCollectionTest.testCollectionIteratorRemove:834-
>verify:1707 » ArrayIndexOutOfBounds
AbstractMapTest$TestMapEntrySet>AbstractCollectionTest.testCollectionRemoveAll:930-
>verify:1707 » ArrayIndexOutOfBounds
AbstractMapTest$TestMapKeySet>AbstractCollectionTest.testCollectionIteratorRemove:834-
>verify:1786 » ArrayIndexOutOfBounds
AbstractMapTest$TestMapKeySet>AbstractCollectionTest.testCollectionRemoveAll:930-
>verify:1786 » ArrayIndexOutOfBounds
AbstractSortedMapTest$TestTailMap>AbstractMapTest.testMapRemove:1002-
>AbstractSortedMapTest$TestViewMap.verify:138->AbstractMapTest.verify:1942-
>AbstractMapTest.verifyValues:2013 » ArrayIndexOutOfBounds
AbstractMapTest$TestMapEntrySet>AbstractCollectionTest.testCollectionIteratorRemove:834-
>verify:1707 » ArrayIndexOutOfBounds
AbstractMapTest$TestMapEntrySet>AbstractCollectionTest.testCollectionRemoveAll:930-
>verify:1707 » ArrayIndexOutOfBounds
AbstractMapTest$TestMapKeySet>AbstractCollectionTest.testCollectionIteratorRemove:834-
>verify:1786 » ArrayIndexOutOfBounds
AbstractMapTest$TestMapKeySet>AbstractCollectionTest.testCollectionRemoveAll:930-
>verify:1786 » ArrayIndexOutOfBounds
=========================== %< ===========================
[snip]
Cheers,
Jörg
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE] Release of Commons Collections 4.0 based on RC3
Posted by Thomas Neidhart <th...@gmail.com>.
On 11/13/2013 05:39 PM, Jörg Schaible wrote:
> Jörg Schaible wrote:
>
>> Hi Thomas,
>>
>> Thomas Neidhart wrote:
>>
>>> Hi Joerg,
>>>
>>> the failure for JDK 1.8 is clear: this version updated the Map interface
>>> with a new method boolean remove(Object, Object) which clashes with the
>>> ones in MultiValueMap and MultiMap. We should change the return type to
>>> be compatible.
>>
>> This means unfortunately that I will vote with -1. If this new method
>> stays in J8, we would have to make an incompatible change ourselves for
>> J8- compatibility :-(
>>
>>> For IBM JDK 6: I did already ignore several tests (due to problems with
>>> the TreeMap implementation there) if run with this JVM but obviously
>>> something has changed since then, need to check.
>>
>> I can tell you this evening (in ~6 hours), which version I used exactly.
>> However, IIRC the number of executed tests were for me always the same.
>> Maybe the check for IBM JDK 1.6 failed?
>
> ===================== %< ===============
> $ java -version
> java version "1.6.0"
> Java(TM) SE Runtime Environment (build pxa6460sr9fp2-20110625_01(SR9 FP2))
> IBM J9 VM (build 2.4, JRE 1.6.0 IBM J9 2.4 Linux amd64-64
> jvmxa6460sr9-20110624_85526 (JIT enabled, AOT enabled)
> J9VM - 20110624_085526
> JIT - r9_20101028_17488ifx17
> GC - 20101027_AA)
> JCL - 20110530_01
> ===================== %< ===============
I tested with this version:
java version "1.6.0"
Java(TM) SE Runtime Environment (build pxi3260sr12-20121025_01(SR12))
IBM J9 VM (build 2.4, JRE 1.6.0 IBM J9 2.4 Linux x86-32
jvmxi3260sr12-20121024_126067 (JIT enabled, AOT enabled)
J9VM - 20121024_126067
JIT - r9_20120914_26057
GC - 20120928_AA)
JCL - 20121014_01
and got 3 failures from a recently added test, for which I forgot to add
the ignore rules.
Could you output me the result of this for your IBM JDK version:
final String vmName = System.getProperty("java.vm.name");
final String version = System.getProperty("java.version");
Thanks,
Thomas
>>>
>>> For IBM JDK 5: It only fails to compile the tests, but I could not yet
>>> figure out why.
>>
>> Same to me. BTW: I forget in my list below to mention that I can run with
>> IBM JDK 1.5 all tests successfully if I use the compiled classes of Sun
>> JDK 1.5.
>>
>> We should add at least a note to RELEASE-NOTES.txt (if not already
>> happened) explaining the problems with IBM JDK 1.5/1.6 and probably also
>> something directly on the site.
>>
>> Cheers,
>> Jörg
>>
>>>
>>> Thomas
>>>
>>>
>>>
>>> On Wed, Nov 13, 2013 at 12:13 AM, Jörg Schaible
>>> <jo...@gmx.de>wrote:
>>>
>>>> Hi Thomas,
>>>>
>>>> I've downloaded the source tar.gz and tested it with my compiler zoo.
>>>>
>>>> 1/ IBM JDK 1.5 fails with compilation error (without telling where or
>>>> why). 2/ Sun JDK 1.5 compiles and runs tests fine, using these class
>>>> files to run the tests:
>>>> 2.1/ IBM JDK 1.6 runs tests with 5 failures / 15 errors
>>>> 2.2/ IBM JDK 1.7 runs tests successful
>>>> 2.3/ IcedTea 6 / OpenJDK runs tests successful
>>>> 2.4/ IcedTea 7 / OpenJDK runs tests successful
>>>> 2.5/ Oracle JDK 1.7 runs tests successful
>>>> 2.6/ Oracle JDK 1.8 (b109) runs tests successful
>>>> 2.7/ Sun JDK 1.6 runs tests successful
>>>> 3/ IBM JDK 1.6 compiles and runs tests with 5 failures / 15 errors
>>>> 4/ IBM JDK 1.7 compiles and runs tests successful
>>>> 5/ IcedTea 6 compiles and runs tests successful
>>>> 6/ IcedTea 7 compiles and runs tests successful
>>>> 7/ Sun JDK 1.6 compiles and runs tests successful
>>>> 8/ Oracle JDK 1.7 compiles and runs tests successful
>>>> 9/ Oracle JDK 1.8 (b109) fails to compile:
>>>> ======================= %< =========================
>>>> [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-
>>>> plugin:3.1:compile (default-compile) on project commons-collections4:
>>>> Compilation failure: Compilation failure:
>>>> [ERROR] /home/joehni/tmp/download/commons-collections4-4.0-
>>>>
> src/src/main/java/org/apache/commons/collections4/map/MultiValueMap.java:
>>>> [211,14] remove(java.lang.Object,java.lang.Object) in
>>>> org.apache.commons.collections4.map.MultiValueMap cannot implement
>>>> remove(java.lang.Object,java.lang.Object) in java.util.Map
>>>> [ERROR] return type V is not compatible with boolean
>>>> [ERROR] /home/joehni/tmp/download/commons-collections4-4.0-
>>>> src/src/main/java/org/apache/commons/collections4/MultiMap.java:[64,14]
>>>> name
>>>> clash: remove(K,V) in org.apache.commons.collections4.MultiMap and
>>>> remove(java.lang.Object,java.lang.Object) in java.util.Map have the same
>>>> erasure, yet neither overrides the other
>>>> [ERROR] /home/joehni/tmp/download/commons-collections4-4.0-
>>>> src/src/main/java/org/apache/commons/collections4/map/MultiKeyMap.java:
>>>> [199,14] remove(java.lang.Object,java.lang.Object) in
>>>> org.apache.commons.collections4.map.MultiKeyMap cannot implement
>>>> remove(java.lang.Object,java.lang.Object) in java.util.Map
>>>> [ERROR] return type V is not compatible with boolean
>>>> ======================= %< =========================
>>>>
>>>> Actually I don't know, if the older IBM compilers simply have problems
>>>> with generics or if J8 is representative here - at least it runs.
>>>>
>>>> Cheers,
>>>> Jörg
>>>>
>>>> Thomas Neidhart wrote:
>>>>
>>>>> Hi,
>>>>>
>>>>> I'd like to call a vote for releasing Commons Collections 4.0 based on
>>>>> RC3.
>>>>>
>>>>> Changes since RC2:
>>>>>
>>>>> * [COLLECTIONS-499] Refactored the test framework for Bag
>>>>> implementations to extend from "AbstractCollectionTest" by
>>>>> decorating the concrete Bag instance with a CollectionBag or
>>>>> CollectionSortedBag.
>>>>> * [COLLECTIONS-498] "CollectionBag" will now also respect the
>>>>> contract of the decorated bag in case a null argument is provided
>>>>> to either removeAll or retainAll.
>>>>> * [COLLECTIONS-497] Added bag decorator "CollectionSortedBag" which
>>>>> decorates a SortedBag to make it comply with the Collection
>>>>> contract.
>>>>> * [COLLECTIONS-496] "UnmodifiableBoundedCollection" does now also
>>>>> implement the marker interface "Unmodifiable" similar as all other
>>>>> unmodifiable decorators.
>>>>> * [COLLECTIONS-495] "UnmodifiableTrie#unmodifiableTrie(Trie)" will
>>>>> not decorate again an already unmodifiable Trie. Also the return
>>>>> type has been changed to "Trie" to be consistent with other
>>>>> Unmodifiable decorators.
>>>>> * [COLLECTIONS-494] Moved "Equator" interface to base package for
>>>>> consistency. Thanks to Emmanuel Bourg.
>>>>> * improved release notes with suggestions from Emmanuel Bourg
>>>>> * added unit tests for TrieUtils and QueueUtils and factory methods
>>>>> for all Unmodifiable decorators
>>>>> * added more unit tests for the Queue interface
>>>>> * cleanup of many test classes: removed unused imports, unneeded
>>>>> constructors
>>>>>
>>>>> Changes since RC1:
>>>>>
>>>>> * release notes are now also included in the binary distribution
>>>>> * removed spurious hashCode() method in AbstractPatriciaTrie, the
>>>>> inherited one from AbstractMap will be used instead
>>>>>
>>>>>
>>>>> Collections 4.0 RC3 is available for review here:
>>>>> https://dist.apache.org/repos/dist/dev/commons/collections/
>>>>> (svn revision 3477)
>>>>>
>>>>> Maven artifacts are here:
>>>>>
>>>>>
>>>>
>>>>
>>
> https://repository.apache.org/content/repositories/orgapachecommons-118/org/apache/commons/commons-collections4/4.0/
>>>>>
>>>>> The tag is here:
>>>>>
>>>>>
>>>>
>>>>
>>
> https://svn.apache.org/repos/asf/commons/proper/collections/tags/COLLECTIONS_4_0_RC3/
>>>>> (svn revision 1540843)
>>>>>
>>>>> Site:
>>>>> http://people.apache.org/builds/commons/collections/4.0/RC3/
>>>>>
>>>>> Details of changes can be found in the release notes:
>>>>>
>>>>>
>>>> https://dist.apache.org/repos/dist/dev/commons/collections/RELEASE-NOTES.txt
>>>>>
>>>>>
>>>> http://people.apache.org/builds/commons/collections/4.0/RC3/changes-report.html
>>>>>
>>>>> Please review the release candidate and vote.
>>>>> This vote will close no sooner than 72 hours from now.
>>>>>
>>>>> [ ] +1 Release these artifacts
>>>>> [ ] +0 OK, but...
>>>>> [ ] -0 OK, but really should fix...
>>>>> [ ] -1 I oppose this release because...
>>>>>
>>>>> Note: the clirr report is generated against 4.0-alpha1 and it is also
>>>>> highlighted in the release notes that this release is not compatible
>>>>> with any previous release.
>>>>>
>>>>> Note2: there have been reports in the past that some unit tests fail
>>>>> with certain versions of the IBM Java 6 VM. Some tests have been
>>>>> disabled when run with a IBM Java 6 VM due to some bugs in the
>>>>> java.util.TreeMap implementation, but it may still fail for other
>>>>> versions.
>>>>>
>>>>> Thank you for your reviews,
>>>>>
>>>>> Thomas
>>>>
>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>>
>>>>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE] Release of Commons Collections 4.0 based on RC3
Posted by Jörg Schaible <jo...@gmx.de>.
Jörg Schaible wrote:
> Hi Thomas,
>
> Thomas Neidhart wrote:
>
>> Hi Joerg,
>>
>> the failure for JDK 1.8 is clear: this version updated the Map interface
>> with a new method boolean remove(Object, Object) which clashes with the
>> ones in MultiValueMap and MultiMap. We should change the return type to
>> be compatible.
>
> This means unfortunately that I will vote with -1. If this new method
> stays in J8, we would have to make an incompatible change ourselves for
> J8- compatibility :-(
>
>> For IBM JDK 6: I did already ignore several tests (due to problems with
>> the TreeMap implementation there) if run with this JVM but obviously
>> something has changed since then, need to check.
>
> I can tell you this evening (in ~6 hours), which version I used exactly.
> However, IIRC the number of executed tests were for me always the same.
> Maybe the check for IBM JDK 1.6 failed?
===================== %< ===============
$ java -version
java version "1.6.0"
Java(TM) SE Runtime Environment (build pxa6460sr9fp2-20110625_01(SR9 FP2))
IBM J9 VM (build 2.4, JRE 1.6.0 IBM J9 2.4 Linux amd64-64
jvmxa6460sr9-20110624_85526 (JIT enabled, AOT enabled)
J9VM - 20110624_085526
JIT - r9_20101028_17488ifx17
GC - 20101027_AA)
JCL - 20110530_01
===================== %< ===============
>>
>> For IBM JDK 5: It only fails to compile the tests, but I could not yet
>> figure out why.
>
> Same to me. BTW: I forget in my list below to mention that I can run with
> IBM JDK 1.5 all tests successfully if I use the compiled classes of Sun
> JDK 1.5.
>
> We should add at least a note to RELEASE-NOTES.txt (if not already
> happened) explaining the problems with IBM JDK 1.5/1.6 and probably also
> something directly on the site.
>
> Cheers,
> Jörg
>
>>
>> Thomas
>>
>>
>>
>> On Wed, Nov 13, 2013 at 12:13 AM, Jörg Schaible
>> <jo...@gmx.de>wrote:
>>
>>> Hi Thomas,
>>>
>>> I've downloaded the source tar.gz and tested it with my compiler zoo.
>>>
>>> 1/ IBM JDK 1.5 fails with compilation error (without telling where or
>>> why). 2/ Sun JDK 1.5 compiles and runs tests fine, using these class
>>> files to run the tests:
>>> 2.1/ IBM JDK 1.6 runs tests with 5 failures / 15 errors
>>> 2.2/ IBM JDK 1.7 runs tests successful
>>> 2.3/ IcedTea 6 / OpenJDK runs tests successful
>>> 2.4/ IcedTea 7 / OpenJDK runs tests successful
>>> 2.5/ Oracle JDK 1.7 runs tests successful
>>> 2.6/ Oracle JDK 1.8 (b109) runs tests successful
>>> 2.7/ Sun JDK 1.6 runs tests successful
>>> 3/ IBM JDK 1.6 compiles and runs tests with 5 failures / 15 errors
>>> 4/ IBM JDK 1.7 compiles and runs tests successful
>>> 5/ IcedTea 6 compiles and runs tests successful
>>> 6/ IcedTea 7 compiles and runs tests successful
>>> 7/ Sun JDK 1.6 compiles and runs tests successful
>>> 8/ Oracle JDK 1.7 compiles and runs tests successful
>>> 9/ Oracle JDK 1.8 (b109) fails to compile:
>>> ======================= %< =========================
>>> [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-
>>> plugin:3.1:compile (default-compile) on project commons-collections4:
>>> Compilation failure: Compilation failure:
>>> [ERROR] /home/joehni/tmp/download/commons-collections4-4.0-
>>>
src/src/main/java/org/apache/commons/collections4/map/MultiValueMap.java:
>>> [211,14] remove(java.lang.Object,java.lang.Object) in
>>> org.apache.commons.collections4.map.MultiValueMap cannot implement
>>> remove(java.lang.Object,java.lang.Object) in java.util.Map
>>> [ERROR] return type V is not compatible with boolean
>>> [ERROR] /home/joehni/tmp/download/commons-collections4-4.0-
>>> src/src/main/java/org/apache/commons/collections4/MultiMap.java:[64,14]
>>> name
>>> clash: remove(K,V) in org.apache.commons.collections4.MultiMap and
>>> remove(java.lang.Object,java.lang.Object) in java.util.Map have the same
>>> erasure, yet neither overrides the other
>>> [ERROR] /home/joehni/tmp/download/commons-collections4-4.0-
>>> src/src/main/java/org/apache/commons/collections4/map/MultiKeyMap.java:
>>> [199,14] remove(java.lang.Object,java.lang.Object) in
>>> org.apache.commons.collections4.map.MultiKeyMap cannot implement
>>> remove(java.lang.Object,java.lang.Object) in java.util.Map
>>> [ERROR] return type V is not compatible with boolean
>>> ======================= %< =========================
>>>
>>> Actually I don't know, if the older IBM compilers simply have problems
>>> with generics or if J8 is representative here - at least it runs.
>>>
>>> Cheers,
>>> Jörg
>>>
>>> Thomas Neidhart wrote:
>>>
>>> > Hi,
>>> >
>>> > I'd like to call a vote for releasing Commons Collections 4.0 based on
>>> > RC3.
>>> >
>>> > Changes since RC2:
>>> >
>>> > * [COLLECTIONS-499] Refactored the test framework for Bag
>>> > implementations to extend from "AbstractCollectionTest" by
>>> > decorating the concrete Bag instance with a CollectionBag or
>>> > CollectionSortedBag.
>>> > * [COLLECTIONS-498] "CollectionBag" will now also respect the
>>> > contract of the decorated bag in case a null argument is provided
>>> > to either removeAll or retainAll.
>>> > * [COLLECTIONS-497] Added bag decorator "CollectionSortedBag" which
>>> > decorates a SortedBag to make it comply with the Collection
>>> > contract.
>>> > * [COLLECTIONS-496] "UnmodifiableBoundedCollection" does now also
>>> > implement the marker interface "Unmodifiable" similar as all other
>>> > unmodifiable decorators.
>>> > * [COLLECTIONS-495] "UnmodifiableTrie#unmodifiableTrie(Trie)" will
>>> > not decorate again an already unmodifiable Trie. Also the return
>>> > type has been changed to "Trie" to be consistent with other
>>> > Unmodifiable decorators.
>>> > * [COLLECTIONS-494] Moved "Equator" interface to base package for
>>> > consistency. Thanks to Emmanuel Bourg.
>>> > * improved release notes with suggestions from Emmanuel Bourg
>>> > * added unit tests for TrieUtils and QueueUtils and factory methods
>>> > for all Unmodifiable decorators
>>> > * added more unit tests for the Queue interface
>>> > * cleanup of many test classes: removed unused imports, unneeded
>>> > constructors
>>> >
>>> > Changes since RC1:
>>> >
>>> > * release notes are now also included in the binary distribution
>>> > * removed spurious hashCode() method in AbstractPatriciaTrie, the
>>> > inherited one from AbstractMap will be used instead
>>> >
>>> >
>>> > Collections 4.0 RC3 is available for review here:
>>> > https://dist.apache.org/repos/dist/dev/commons/collections/
>>> > (svn revision 3477)
>>> >
>>> > Maven artifacts are here:
>>> >
>>> >
>>>
>>>
>
https://repository.apache.org/content/repositories/orgapachecommons-118/org/apache/commons/commons-collections4/4.0/
>>> >
>>> > The tag is here:
>>> >
>>> >
>>>
>>>
>
https://svn.apache.org/repos/asf/commons/proper/collections/tags/COLLECTIONS_4_0_RC3/
>>> > (svn revision 1540843)
>>> >
>>> > Site:
>>> > http://people.apache.org/builds/commons/collections/4.0/RC3/
>>> >
>>> > Details of changes can be found in the release notes:
>>> >
>>> >
>>> https://dist.apache.org/repos/dist/dev/commons/collections/RELEASE-NOTES.txt
>>> >
>>> >
>>> http://people.apache.org/builds/commons/collections/4.0/RC3/changes-report.html
>>> >
>>> > Please review the release candidate and vote.
>>> > This vote will close no sooner than 72 hours from now.
>>> >
>>> > [ ] +1 Release these artifacts
>>> > [ ] +0 OK, but...
>>> > [ ] -0 OK, but really should fix...
>>> > [ ] -1 I oppose this release because...
>>> >
>>> > Note: the clirr report is generated against 4.0-alpha1 and it is also
>>> > highlighted in the release notes that this release is not compatible
>>> > with any previous release.
>>> >
>>> > Note2: there have been reports in the past that some unit tests fail
>>> > with certain versions of the IBM Java 6 VM. Some tests have been
>>> > disabled when run with a IBM Java 6 VM due to some bugs in the
>>> > java.util.TreeMap implementation, but it may still fail for other
>>> > versions.
>>> >
>>> > Thank you for your reviews,
>>> >
>>> > Thomas
>>>
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>
>>>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE] Release of Commons Collections 4.0 based on RC3
Posted by Jörg Schaible <Jo...@scalaris.com>.
Hi Thomas,
Thomas Neidhart wrote:
> Hi Joerg,
>
> the failure for JDK 1.8 is clear: this version updated the Map interface
> with a new method boolean remove(Object, Object) which clashes with the
> ones in MultiValueMap and MultiMap. We should change the return type to be
> compatible.
This means unfortunately that I will vote with -1. If this new method stays
in J8, we would have to make an incompatible change ourselves for J8-
compatibility :-(
> For IBM JDK 6: I did already ignore several tests (due to problems with
> the TreeMap implementation there) if run with this JVM but obviously
> something has changed since then, need to check.
I can tell you this evening (in ~6 hours), which version I used exactly.
However, IIRC the number of executed tests were for me always the same.
Maybe the check for IBM JDK 1.6 failed?
>
> For IBM JDK 5: It only fails to compile the tests, but I could not yet
> figure out why.
Same to me. BTW: I forget in my list below to mention that I can run with
IBM JDK 1.5 all tests successfully if I use the compiled classes of Sun JDK
1.5.
We should add at least a note to RELEASE-NOTES.txt (if not already happened)
explaining the problems with IBM JDK 1.5/1.6 and probably also something
directly on the site.
Cheers,
Jörg
>
> Thomas
>
>
>
> On Wed, Nov 13, 2013 at 12:13 AM, Jörg Schaible
> <jo...@gmx.de>wrote:
>
>> Hi Thomas,
>>
>> I've downloaded the source tar.gz and tested it with my compiler zoo.
>>
>> 1/ IBM JDK 1.5 fails with compilation error (without telling where or
>> why). 2/ Sun JDK 1.5 compiles and runs tests fine, using these class
>> files to run the tests:
>> 2.1/ IBM JDK 1.6 runs tests with 5 failures / 15 errors
>> 2.2/ IBM JDK 1.7 runs tests successful
>> 2.3/ IcedTea 6 / OpenJDK runs tests successful
>> 2.4/ IcedTea 7 / OpenJDK runs tests successful
>> 2.5/ Oracle JDK 1.7 runs tests successful
>> 2.6/ Oracle JDK 1.8 (b109) runs tests successful
>> 2.7/ Sun JDK 1.6 runs tests successful
>> 3/ IBM JDK 1.6 compiles and runs tests with 5 failures / 15 errors
>> 4/ IBM JDK 1.7 compiles and runs tests successful
>> 5/ IcedTea 6 compiles and runs tests successful
>> 6/ IcedTea 7 compiles and runs tests successful
>> 7/ Sun JDK 1.6 compiles and runs tests successful
>> 8/ Oracle JDK 1.7 compiles and runs tests successful
>> 9/ Oracle JDK 1.8 (b109) fails to compile:
>> ======================= %< =========================
>> [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-
>> plugin:3.1:compile (default-compile) on project commons-collections4:
>> Compilation failure: Compilation failure:
>> [ERROR] /home/joehni/tmp/download/commons-collections4-4.0-
>> src/src/main/java/org/apache/commons/collections4/map/MultiValueMap.java:
>> [211,14] remove(java.lang.Object,java.lang.Object) in
>> org.apache.commons.collections4.map.MultiValueMap cannot implement
>> remove(java.lang.Object,java.lang.Object) in java.util.Map
>> [ERROR] return type V is not compatible with boolean
>> [ERROR] /home/joehni/tmp/download/commons-collections4-4.0-
>> src/src/main/java/org/apache/commons/collections4/MultiMap.java:[64,14]
>> name
>> clash: remove(K,V) in org.apache.commons.collections4.MultiMap and
>> remove(java.lang.Object,java.lang.Object) in java.util.Map have the same
>> erasure, yet neither overrides the other
>> [ERROR] /home/joehni/tmp/download/commons-collections4-4.0-
>> src/src/main/java/org/apache/commons/collections4/map/MultiKeyMap.java:
>> [199,14] remove(java.lang.Object,java.lang.Object) in
>> org.apache.commons.collections4.map.MultiKeyMap cannot implement
>> remove(java.lang.Object,java.lang.Object) in java.util.Map
>> [ERROR] return type V is not compatible with boolean
>> ======================= %< =========================
>>
>> Actually I don't know, if the older IBM compilers simply have problems
>> with generics or if J8 is representative here - at least it runs.
>>
>> Cheers,
>> Jörg
>>
>> Thomas Neidhart wrote:
>>
>> > Hi,
>> >
>> > I'd like to call a vote for releasing Commons Collections 4.0 based on
>> > RC3.
>> >
>> > Changes since RC2:
>> >
>> > * [COLLECTIONS-499] Refactored the test framework for Bag
>> > implementations to extend from "AbstractCollectionTest" by
>> > decorating the concrete Bag instance with a CollectionBag or
>> > CollectionSortedBag.
>> > * [COLLECTIONS-498] "CollectionBag" will now also respect the
>> > contract of the decorated bag in case a null argument is provided
>> > to either removeAll or retainAll.
>> > * [COLLECTIONS-497] Added bag decorator "CollectionSortedBag" which
>> > decorates a SortedBag to make it comply with the Collection
>> > contract.
>> > * [COLLECTIONS-496] "UnmodifiableBoundedCollection" does now also
>> > implement the marker interface "Unmodifiable" similar as all other
>> > unmodifiable decorators.
>> > * [COLLECTIONS-495] "UnmodifiableTrie#unmodifiableTrie(Trie)" will
>> > not decorate again an already unmodifiable Trie. Also the return
>> > type has been changed to "Trie" to be consistent with other
>> > Unmodifiable decorators.
>> > * [COLLECTIONS-494] Moved "Equator" interface to base package for
>> > consistency. Thanks to Emmanuel Bourg.
>> > * improved release notes with suggestions from Emmanuel Bourg
>> > * added unit tests for TrieUtils and QueueUtils and factory methods
>> > for all Unmodifiable decorators
>> > * added more unit tests for the Queue interface
>> > * cleanup of many test classes: removed unused imports, unneeded
>> > constructors
>> >
>> > Changes since RC1:
>> >
>> > * release notes are now also included in the binary distribution
>> > * removed spurious hashCode() method in AbstractPatriciaTrie, the
>> > inherited one from AbstractMap will be used instead
>> >
>> >
>> > Collections 4.0 RC3 is available for review here:
>> > https://dist.apache.org/repos/dist/dev/commons/collections/
>> > (svn revision 3477)
>> >
>> > Maven artifacts are here:
>> >
>> >
>>
>>
https://repository.apache.org/content/repositories/orgapachecommons-118/org/apache/commons/commons-collections4/4.0/
>> >
>> > The tag is here:
>> >
>> >
>>
>>
https://svn.apache.org/repos/asf/commons/proper/collections/tags/COLLECTIONS_4_0_RC3/
>> > (svn revision 1540843)
>> >
>> > Site:
>> > http://people.apache.org/builds/commons/collections/4.0/RC3/
>> >
>> > Details of changes can be found in the release notes:
>> >
>> >
>> https://dist.apache.org/repos/dist/dev/commons/collections/RELEASE-NOTES.txt
>> >
>> >
>> http://people.apache.org/builds/commons/collections/4.0/RC3/changes-report.html
>> >
>> > Please review the release candidate and vote.
>> > This vote will close no sooner than 72 hours from now.
>> >
>> > [ ] +1 Release these artifacts
>> > [ ] +0 OK, but...
>> > [ ] -0 OK, but really should fix...
>> > [ ] -1 I oppose this release because...
>> >
>> > Note: the clirr report is generated against 4.0-alpha1 and it is also
>> > highlighted in the release notes that this release is not compatible
>> > with any previous release.
>> >
>> > Note2: there have been reports in the past that some unit tests fail
>> > with certain versions of the IBM Java 6 VM. Some tests have been
>> > disabled when run with a IBM Java 6 VM due to some bugs in the
>> > java.util.TreeMap implementation, but it may still fail for other
>> > versions.
>> >
>> > Thank you for your reviews,
>> >
>> > Thomas
>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE] Release of Commons Collections 4.0 based on RC3
Posted by Thomas Neidhart <th...@gmail.com>.
Hi Joerg,
the failure for JDK 1.8 is clear: this version updated the Map interface
with a new method boolean remove(Object, Object) which clashes with the
ones in MultiValueMap and MultiMap. We should change the return type to be
compatible.
For IBM JDK 6: I did already ignore several tests (due to problems with the
TreeMap implementation there) if run with this JVM but obviously something
has changed since then, need to check.
For IBM JDK 5: It only fails to compile the tests, but I could not yet
figure out why.
Thomas
On Wed, Nov 13, 2013 at 12:13 AM, Jörg Schaible <jo...@gmx.de>wrote:
> Hi Thomas,
>
> I've downloaded the source tar.gz and tested it with my compiler zoo.
>
> 1/ IBM JDK 1.5 fails with compilation error (without telling where or why).
> 2/ Sun JDK 1.5 compiles and runs tests fine, using these class files to run
> the tests:
> 2.1/ IBM JDK 1.6 runs tests with 5 failures / 15 errors
> 2.2/ IBM JDK 1.7 runs tests successful
> 2.3/ IcedTea 6 / OpenJDK runs tests successful
> 2.4/ IcedTea 7 / OpenJDK runs tests successful
> 2.5/ Oracle JDK 1.7 runs tests successful
> 2.6/ Oracle JDK 1.8 (b109) runs tests successful
> 2.7/ Sun JDK 1.6 runs tests successful
> 3/ IBM JDK 1.6 compiles and runs tests with 5 failures / 15 errors
> 4/ IBM JDK 1.7 compiles and runs tests successful
> 5/ IcedTea 6 compiles and runs tests successful
> 6/ IcedTea 7 compiles and runs tests successful
> 7/ Sun JDK 1.6 compiles and runs tests successful
> 8/ Oracle JDK 1.7 compiles and runs tests successful
> 9/ Oracle JDK 1.8 (b109) fails to compile:
> ======================= %< =========================
> [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-
> plugin:3.1:compile (default-compile) on project commons-collections4:
> Compilation failure: Compilation failure:
> [ERROR] /home/joehni/tmp/download/commons-collections4-4.0-
> src/src/main/java/org/apache/commons/collections4/map/MultiValueMap.java:
> [211,14] remove(java.lang.Object,java.lang.Object) in
> org.apache.commons.collections4.map.MultiValueMap cannot implement
> remove(java.lang.Object,java.lang.Object) in java.util.Map
> [ERROR] return type V is not compatible with boolean
> [ERROR] /home/joehni/tmp/download/commons-collections4-4.0-
> src/src/main/java/org/apache/commons/collections4/MultiMap.java:[64,14]
> name
> clash: remove(K,V) in org.apache.commons.collections4.MultiMap and
> remove(java.lang.Object,java.lang.Object) in java.util.Map have the same
> erasure, yet neither overrides the other
> [ERROR] /home/joehni/tmp/download/commons-collections4-4.0-
> src/src/main/java/org/apache/commons/collections4/map/MultiKeyMap.java:
> [199,14] remove(java.lang.Object,java.lang.Object) in
> org.apache.commons.collections4.map.MultiKeyMap cannot implement
> remove(java.lang.Object,java.lang.Object) in java.util.Map
> [ERROR] return type V is not compatible with boolean
> ======================= %< =========================
>
> Actually I don't know, if the older IBM compilers simply have problems with
> generics or if J8 is representative here - at least it runs.
>
> Cheers,
> Jörg
>
> Thomas Neidhart wrote:
>
> > Hi,
> >
> > I'd like to call a vote for releasing Commons Collections 4.0 based on
> > RC3.
> >
> > Changes since RC2:
> >
> > * [COLLECTIONS-499] Refactored the test framework for Bag
> > implementations to extend from "AbstractCollectionTest" by
> > decorating the concrete Bag instance with a CollectionBag or
> > CollectionSortedBag.
> > * [COLLECTIONS-498] "CollectionBag" will now also respect the
> > contract of the decorated bag in case a null argument is provided
> > to either removeAll or retainAll.
> > * [COLLECTIONS-497] Added bag decorator "CollectionSortedBag" which
> > decorates a SortedBag to make it comply with the Collection
> > contract.
> > * [COLLECTIONS-496] "UnmodifiableBoundedCollection" does now also
> > implement the marker interface "Unmodifiable" similar as all other
> > unmodifiable decorators.
> > * [COLLECTIONS-495] "UnmodifiableTrie#unmodifiableTrie(Trie)" will
> > not decorate again an already unmodifiable Trie. Also the return
> > type has been changed to "Trie" to be consistent with other
> > Unmodifiable decorators.
> > * [COLLECTIONS-494] Moved "Equator" interface to base package for
> > consistency. Thanks to Emmanuel Bourg.
> > * improved release notes with suggestions from Emmanuel Bourg
> > * added unit tests for TrieUtils and QueueUtils and factory methods
> > for all Unmodifiable decorators
> > * added more unit tests for the Queue interface
> > * cleanup of many test classes: removed unused imports, unneeded
> > constructors
> >
> > Changes since RC1:
> >
> > * release notes are now also included in the binary distribution
> > * removed spurious hashCode() method in AbstractPatriciaTrie, the
> > inherited one from AbstractMap will be used instead
> >
> >
> > Collections 4.0 RC3 is available for review here:
> > https://dist.apache.org/repos/dist/dev/commons/collections/
> > (svn revision 3477)
> >
> > Maven artifacts are here:
> >
> >
>
> https://repository.apache.org/content/repositories/orgapachecommons-118/org/apache/commons/commons-collections4/4.0/
> >
> > The tag is here:
> >
> >
>
> https://svn.apache.org/repos/asf/commons/proper/collections/tags/COLLECTIONS_4_0_RC3/
> > (svn revision 1540843)
> >
> > Site:
> > http://people.apache.org/builds/commons/collections/4.0/RC3/
> >
> > Details of changes can be found in the release notes:
> >
> >
> https://dist.apache.org/repos/dist/dev/commons/collections/RELEASE-NOTES.txt
> >
> >
> http://people.apache.org/builds/commons/collections/4.0/RC3/changes-report.html
> >
> > Please review the release candidate and vote.
> > This vote will close no sooner than 72 hours from now.
> >
> > [ ] +1 Release these artifacts
> > [ ] +0 OK, but...
> > [ ] -0 OK, but really should fix...
> > [ ] -1 I oppose this release because...
> >
> > Note: the clirr report is generated against 4.0-alpha1 and it is also
> > highlighted in the release notes that this release is not compatible
> > with any previous release.
> >
> > Note2: there have been reports in the past that some unit tests fail
> > with certain versions of the IBM Java 6 VM. Some tests have been
> > disabled when run with a IBM Java 6 VM due to some bugs in the
> > java.util.TreeMap implementation, but it may still fail for other
> > versions.
> >
> > Thank you for your reviews,
> >
> > Thomas
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
Re: [VOTE] Release of Commons Collections 4.0 based on RC3
Posted by Jörg Schaible <jo...@gmx.de>.
Hi Thomas,
I've downloaded the source tar.gz and tested it with my compiler zoo.
1/ IBM JDK 1.5 fails with compilation error (without telling where or why).
2/ Sun JDK 1.5 compiles and runs tests fine, using these class files to run
the tests:
2.1/ IBM JDK 1.6 runs tests with 5 failures / 15 errors
2.2/ IBM JDK 1.7 runs tests successful
2.3/ IcedTea 6 / OpenJDK runs tests successful
2.4/ IcedTea 7 / OpenJDK runs tests successful
2.5/ Oracle JDK 1.7 runs tests successful
2.6/ Oracle JDK 1.8 (b109) runs tests successful
2.7/ Sun JDK 1.6 runs tests successful
3/ IBM JDK 1.6 compiles and runs tests with 5 failures / 15 errors
4/ IBM JDK 1.7 compiles and runs tests successful
5/ IcedTea 6 compiles and runs tests successful
6/ IcedTea 7 compiles and runs tests successful
7/ Sun JDK 1.6 compiles and runs tests successful
8/ Oracle JDK 1.7 compiles and runs tests successful
9/ Oracle JDK 1.8 (b109) fails to compile:
======================= %< =========================
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-
plugin:3.1:compile (default-compile) on project commons-collections4:
Compilation failure: Compilation failure:
[ERROR] /home/joehni/tmp/download/commons-collections4-4.0-
src/src/main/java/org/apache/commons/collections4/map/MultiValueMap.java:
[211,14] remove(java.lang.Object,java.lang.Object) in
org.apache.commons.collections4.map.MultiValueMap cannot implement
remove(java.lang.Object,java.lang.Object) in java.util.Map
[ERROR] return type V is not compatible with boolean
[ERROR] /home/joehni/tmp/download/commons-collections4-4.0-
src/src/main/java/org/apache/commons/collections4/MultiMap.java:[64,14] name
clash: remove(K,V) in org.apache.commons.collections4.MultiMap and
remove(java.lang.Object,java.lang.Object) in java.util.Map have the same
erasure, yet neither overrides the other
[ERROR] /home/joehni/tmp/download/commons-collections4-4.0-
src/src/main/java/org/apache/commons/collections4/map/MultiKeyMap.java:
[199,14] remove(java.lang.Object,java.lang.Object) in
org.apache.commons.collections4.map.MultiKeyMap cannot implement
remove(java.lang.Object,java.lang.Object) in java.util.Map
[ERROR] return type V is not compatible with boolean
======================= %< =========================
Actually I don't know, if the older IBM compilers simply have problems with
generics or if J8 is representative here - at least it runs.
Cheers,
Jörg
Thomas Neidhart wrote:
> Hi,
>
> I'd like to call a vote for releasing Commons Collections 4.0 based on
> RC3.
>
> Changes since RC2:
>
> * [COLLECTIONS-499] Refactored the test framework for Bag
> implementations to extend from "AbstractCollectionTest" by
> decorating the concrete Bag instance with a CollectionBag or
> CollectionSortedBag.
> * [COLLECTIONS-498] "CollectionBag" will now also respect the
> contract of the decorated bag in case a null argument is provided
> to either removeAll or retainAll.
> * [COLLECTIONS-497] Added bag decorator "CollectionSortedBag" which
> decorates a SortedBag to make it comply with the Collection
> contract.
> * [COLLECTIONS-496] "UnmodifiableBoundedCollection" does now also
> implement the marker interface "Unmodifiable" similar as all other
> unmodifiable decorators.
> * [COLLECTIONS-495] "UnmodifiableTrie#unmodifiableTrie(Trie)" will
> not decorate again an already unmodifiable Trie. Also the return
> type has been changed to "Trie" to be consistent with other
> Unmodifiable decorators.
> * [COLLECTIONS-494] Moved "Equator" interface to base package for
> consistency. Thanks to Emmanuel Bourg.
> * improved release notes with suggestions from Emmanuel Bourg
> * added unit tests for TrieUtils and QueueUtils and factory methods
> for all Unmodifiable decorators
> * added more unit tests for the Queue interface
> * cleanup of many test classes: removed unused imports, unneeded
> constructors
>
> Changes since RC1:
>
> * release notes are now also included in the binary distribution
> * removed spurious hashCode() method in AbstractPatriciaTrie, the
> inherited one from AbstractMap will be used instead
>
>
> Collections 4.0 RC3 is available for review here:
> https://dist.apache.org/repos/dist/dev/commons/collections/
> (svn revision 3477)
>
> Maven artifacts are here:
>
>
https://repository.apache.org/content/repositories/orgapachecommons-118/org/apache/commons/commons-collections4/4.0/
>
> The tag is here:
>
>
https://svn.apache.org/repos/asf/commons/proper/collections/tags/COLLECTIONS_4_0_RC3/
> (svn revision 1540843)
>
> Site:
> http://people.apache.org/builds/commons/collections/4.0/RC3/
>
> Details of changes can be found in the release notes:
>
> https://dist.apache.org/repos/dist/dev/commons/collections/RELEASE-NOTES.txt
>
> http://people.apache.org/builds/commons/collections/4.0/RC3/changes-report.html
>
> Please review the release candidate and vote.
> This vote will close no sooner than 72 hours from now.
>
> [ ] +1 Release these artifacts
> [ ] +0 OK, but...
> [ ] -0 OK, but really should fix...
> [ ] -1 I oppose this release because...
>
> Note: the clirr report is generated against 4.0-alpha1 and it is also
> highlighted in the release notes that this release is not compatible
> with any previous release.
>
> Note2: there have been reports in the past that some unit tests fail
> with certain versions of the IBM Java 6 VM. Some tests have been
> disabled when run with a IBM Java 6 VM due to some bugs in the
> java.util.TreeMap implementation, but it may still fail for other
> versions.
>
> Thank you for your reviews,
>
> Thomas
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[CANCELLED][VOTE] Release of Commons Collections 4.0 based on RC3
Posted by Thomas Neidhart <th...@gmail.com>.
On 11/11/2013 10:12 PM, Thomas Neidhart wrote:
> Hi,
>
> I'd like to call a vote for releasing Commons Collections 4.0 based on RC3.
>
> Changes since RC2:
>
> * [COLLECTIONS-499] Refactored the test framework for Bag
> implementations to extend from "AbstractCollectionTest" by
> decorating the concrete Bag instance with a CollectionBag or
> CollectionSortedBag.
> * [COLLECTIONS-498] "CollectionBag" will now also respect the
> contract of the decorated bag in case a null argument is provided
> to either removeAll or retainAll.
> * [COLLECTIONS-497] Added bag decorator "CollectionSortedBag" which
> decorates a SortedBag to make it comply with the Collection
> contract.
> * [COLLECTIONS-496] "UnmodifiableBoundedCollection" does now also
> implement the marker interface "Unmodifiable" similar as all other
> unmodifiable decorators.
> * [COLLECTIONS-495] "UnmodifiableTrie#unmodifiableTrie(Trie)" will
> not decorate again an already unmodifiable Trie. Also the return
> type has been changed to "Trie" to be consistent with other
> Unmodifiable decorators.
> * [COLLECTIONS-494] Moved "Equator" interface to base package for
> consistency. Thanks to Emmanuel Bourg.
> * improved release notes with suggestions from Emmanuel Bourg
> * added unit tests for TrieUtils and QueueUtils and factory methods
> for all Unmodifiable decorators
> * added more unit tests for the Queue interface
> * cleanup of many test classes: removed unused imports, unneeded
> constructors
>
> Changes since RC1:
>
> * release notes are now also included in the binary distribution
> * removed spurious hashCode() method in AbstractPatriciaTrie, the
> inherited one from AbstractMap will be used instead
>
>
> Collections 4.0 RC3 is available for review here:
> https://dist.apache.org/repos/dist/dev/commons/collections/
> (svn revision 3477)
>
> Maven artifacts are here:
>
> https://repository.apache.org/content/repositories/orgapachecommons-118/org/apache/commons/commons-collections4/4.0/
>
> The tag is here:
>
> https://svn.apache.org/repos/asf/commons/proper/collections/tags/COLLECTIONS_4_0_RC3/
> (svn revision 1540843)
>
> Site:
> http://people.apache.org/builds/commons/collections/4.0/RC3/
>
> Details of changes can be found in the release notes:
>
> https://dist.apache.org/repos/dist/dev/commons/collections/RELEASE-NOTES.txt
>
> http://people.apache.org/builds/commons/collections/4.0/RC3/changes-report.html
>
> Please review the release candidate and vote.
> This vote will close no sooner than 72 hours from now.
>
> [ ] +1 Release these artifacts
> [ ] +0 OK, but...
> [ ] -0 OK, but really should fix...
> [ ] -1 I oppose this release because...
>
> Note: the clirr report is generated against 4.0-alpha1 and it is also
> highlighted in the release notes that this release is not compatible
> with any previous release.
>
> Note2: there have been reports in the past that some unit tests fail
> with certain versions of the IBM Java 6 VM. Some tests have been
> disabled when run with a IBM Java 6 VM due to some bugs in the
> java.util.TreeMap implementation, but it may still fail for other versions.
>
> Thank you for your reviews,
Vote is cancelled to correct the compilation / unit test problems with
our favorite jdk.
Thomas
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org