[GitHub] [hadoop] Hexiaoqiao commented on a diff in pull request #4366: HDFS-16598. All datanodes XXX are bad. Aborting...

[GitBox <gi...@apache.org>]

Hexiaoqiao commented on code in PR #4366:
URL: https://github.com/apache/hadoop/pull/4366#discussion_r895034052


##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java:
##########
@@ -906,14 +906,19 @@ ReplicaInfo getReplicaInfo(String bpid, long blkid)
     return info;
   }
 
+  ReplicaInfo getReplicaInfoForLock(ExtendedBlock b)

Review Comment:
   Great progress here. How about to integrate `getReplicaInfoForLock` ang `getStorageUuid` together to `getStorageUuidForLock`?
   
   ```
     String getStorageUuidForLock(ExtendedBlock b)
         throws ReplicaNotFoundException {
       return getReplicaInfo(b.getBlockPoolId(), b.getBlockId()).getStorageUuid();
     }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org