You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "hsiang-c (via GitHub)" <gi...@apache.org> on 2024/04/22 11:12:43 UTC

[PR] Data: Adopt EncryptingFileIO in Java read API [iceberg]

hsiang-c opened a new pull request, #10201:
URL: https://github.com/apache/iceberg/pull/10201

   ### Note to reviewers
    - One of our customers would like to read PME-encrypted tables in JVM application.
    - Therefore, switching to `EncryptingFileIO` as https://github.com/apache/iceberg/pull/9592 did for `org.apache.iceberg.spark.source.BaseReader.java` in Spark v3.5.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Data: Adopt EncryptingFileIO in Java read API [iceberg]

Posted by "hsiang-c (via GitHub)" <gi...@apache.org>.
hsiang-c closed pull request #10201: Data: Adopt EncryptingFileIO in Java read API
URL: https://github.com/apache/iceberg/pull/10201


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Data: Adopt EncryptingFileIO in Java read API [iceberg]

Posted by "ggershinsky (via GitHub)" <gi...@apache.org>.
ggershinsky commented on code in PR #10201:
URL: https://github.com/apache/iceberg/pull/10201#discussion_r1591933618


##########
data/src/main/java/org/apache/iceberg/data/GenericReader.java:
##########
@@ -45,14 +45,14 @@
 import org.apache.iceberg.util.PartitionUtil;
 
 class GenericReader implements Serializable {
-  private final FileIO io;
+  private final EncryptingFileIO io;
   private final Schema tableSchema;
   private final Schema projection;
   private final boolean caseSensitive;
   private final boolean reuseContainers;
 
   GenericReader(TableScan scan, boolean reuseContainers) {
-    this.io = scan.table().io();
+    this.io = EncryptingFileIO.combine(scan.table().io(), scan.table().encryption());

Review Comment:
   the table.io() comes from the catalog's table operations, and will already be an EncryptingFileIO for encrypted tables.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Data: Adopt EncryptingFileIO in Java read API [iceberg]

Posted by "hsiang-c (via GitHub)" <gi...@apache.org>.
hsiang-c commented on PR #10201:
URL: https://github.com/apache/iceberg/pull/10201#issuecomment-2097719895

   Spoke to Gidon offline and this PR is redundant in the latest design.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Data: Adopt EncryptingFileIO in Java read API [iceberg]

Posted by "hsiang-c (via GitHub)" <gi...@apache.org>.
hsiang-c commented on PR #10201:
URL: https://github.com/apache/iceberg/pull/10201#issuecomment-2069698512

   FYI @ggershinsky


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org