You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benno Evers <be...@mesosphere.com> on 2019/10/29 18:14:54 UTC
Review Request 71688: Reject operator API calls that include
reservation updates.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71688/
-----------------------------------------------------------
Review request for mesos and Benjamin Bannier.
Repository: mesos
Description
-------
Reject operator API calls that include reservation updates.
Diffs
-----
src/master/http.cpp 60765c9b9d6903f6ed94fa8c614055698caad0da
Diff: https://reviews.apache.org/r/71688/diff/1/
Testing
-------
Thanks,
Benno Evers
Re: Review Request 71688: Reject operator API calls that include
reservation updates.
Posted by Benjamin Bannier <bb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71688/#review218458
-----------------------------------------------------------
src/master/http.cpp
Lines 2008-2009 (patched)
<https://reviews.apache.org/r/71688/#comment306185>
nit: fits on a single line.
src/master/http.cpp
Lines 2015 (patched)
<https://reviews.apache.org/r/71688/#comment306184>
nit: `!source.empty()`.
- Benjamin Bannier
On Oct. 29, 2019, 7:14 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71688/
> -----------------------------------------------------------
>
> (Updated Oct. 29, 2019, 7:14 p.m.)
>
>
> Review request for mesos and Benjamin Bannier.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Reject operator API calls that include reservation updates.
>
>
> Diffs
> -----
>
> src/master/http.cpp 60765c9b9d6903f6ed94fa8c614055698caad0da
>
>
> Diff: https://reviews.apache.org/r/71688/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 71688: Reject operator API calls that include
reservation updates.
Posted by Benjamin Bannier <bb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71688/#review218532
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Bannier
On Nov. 1, 2019, 5:01 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71688/
> -----------------------------------------------------------
>
> (Updated Nov. 1, 2019, 5:01 p.m.)
>
>
> Review request for mesos and Benjamin Bannier.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Reject operator API calls that include reservation updates.
>
>
> Diffs
> -----
>
> src/master/http.cpp 60765c9b9d6903f6ed94fa8c614055698caad0da
>
>
> Diff: https://reviews.apache.org/r/71688/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 71688: Reject operator API calls that include
reservation updates.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71688/
-----------------------------------------------------------
(Updated Nov. 1, 2019, 4:01 p.m.)
Review request for mesos and Benjamin Bannier.
Changes
-------
Address style comments.
Repository: mesos
Description
-------
Reject operator API calls that include reservation updates.
Diffs (updated)
-----
src/master/http.cpp 60765c9b9d6903f6ed94fa8c614055698caad0da
Diff: https://reviews.apache.org/r/71688/diff/2/
Changes: https://reviews.apache.org/r/71688/diff/1-2/
Testing
-------
Thanks,
Benno Evers