You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@zeppelin.apache.org by zj...@apache.org on 2021/05/13 14:32:30 UTC
[zeppelin] branch branch-0.9 updated: [ZEPPELIN-5303] Having colon
in notebook name fails zeppelin to start
This is an automated email from the ASF dual-hosted git repository.
zjffdu pushed a commit to branch branch-0.9
in repository https://gitbox.apache.org/repos/asf/zeppelin.git
The following commit(s) were added to refs/heads/branch-0.9 by this push:
new 552c39b [ZEPPELIN-5303] Having colon in notebook name fails zeppelin to start
552c39b is described below
commit 552c39b5ae492b835afae512a43ee1e25eeb057c
Author: Jeff Zhang <zj...@apache.org>
AuthorDate: Fri Apr 23 10:10:55 2021 +0800
[ZEPPELIN-5303] Having colon in notebook name fails zeppelin to start
### What is this PR for?
The root cause in `commons.vfs2`, upgrading `commons.vfs2` can fix this issue.
### What type of PR is it?
[Bug Fix]
### Todos
* [ ] - Task
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-5303
### How should this be tested?
* Manually tested
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
Author: Jeff Zhang <zj...@apache.org>
Closes #4106 from zjffdu/ZEPPELIN-5303 and squashes the following commits:
b85f71b2a [Jeff Zhang] [ZEPPELIN-5303] Having colon in notebook name fails zeppelin to start
(cherry picked from commit 60c5074ecbb10a14c3b3d997bb324fe04939fe4a)
Signed-off-by: Jeff Zhang <zj...@apache.org>
---
zeppelin-zengine/pom.xml | 6 +++++-
.../zeppelin/notebook/repo/VFSNotebookRepoTest.java | 15 +++++++++++++++
2 files changed, 20 insertions(+), 1 deletion(-)
diff --git a/zeppelin-zengine/pom.xml b/zeppelin-zengine/pom.xml
index 3df3689..9158766 100644
--- a/zeppelin-zengine/pom.xml
+++ b/zeppelin-zengine/pom.xml
@@ -42,7 +42,7 @@
<org.reflections.version>0.9.8</org.reflections.version>
<xml.apis.version>1.4.01</xml.apis.version>
<frontend.maven.plugin.version>1.3</frontend.maven.plugin.version>
- <commons.vfs2.version>2.2</commons.vfs2.version>
+ <commons.vfs2.version>2.6.0</commons.vfs2.version>
<eclipse.jgit.version>4.5.4.201711221230-r</eclipse.jgit.version>
<!--test library versions-->
<google.truth.version>0.27</google.truth.version>
@@ -207,6 +207,10 @@
<groupId>org.codehaus.plexus</groupId>
<artifactId>plexus-utils</artifactId>
</exclusion>
+ <exclusion>
+ <groupId>org.apache.hadoop</groupId>
+ <artifactId>hadoop-hdfs-client</artifactId>
+ </exclusion>
</exclusions>
</dependency>
diff --git a/zeppelin-zengine/src/test/java/org/apache/zeppelin/notebook/repo/VFSNotebookRepoTest.java b/zeppelin-zengine/src/test/java/org/apache/zeppelin/notebook/repo/VFSNotebookRepoTest.java
index dee35ec..05c2a67 100644
--- a/zeppelin-zengine/src/test/java/org/apache/zeppelin/notebook/repo/VFSNotebookRepoTest.java
+++ b/zeppelin-zengine/src/test/java/org/apache/zeppelin/notebook/repo/VFSNotebookRepoTest.java
@@ -106,6 +106,21 @@ public class VFSNotebookRepoTest {
}
@Test
+ public void testNoteNameWithColon() throws IOException {
+ assertEquals(0, notebookRepo.list(AuthenticationInfo.ANONYMOUS).size());
+
+ // create note with colon in name
+ Note note1 = new Note();
+ note1.setPath("/my_project/my:note1");
+ Paragraph p1 = note1.insertNewParagraph(0, AuthenticationInfo.ANONYMOUS);
+ p1.setText("%md hello world");
+ p1.setTitle("my title");
+ notebookRepo.save(note1, AuthenticationInfo.ANONYMOUS);
+ Map<String, NoteInfo> noteInfos = notebookRepo.list(AuthenticationInfo.ANONYMOUS);
+ assertEquals(1, noteInfos.size());
+ }
+
+ @Test
public void testUpdateSettings() throws IOException {
List<NotebookRepoSettingsInfo> repoSettings = notebookRepo.getSettings(AuthenticationInfo.ANONYMOUS);
assertEquals(1, repoSettings.size());