[GitHub] [arrow-datafusion] yjshen commented on pull request #7180: Top-K eager batch sorting

["yjshen (via GitHub)" <gi...@apache.org>]

yjshen commented on PR #7180:
URL: https://github.com/apache/arrow-datafusion/pull/7180#issuecomment-1667044811

   Would it be possible to compare the sorting performance of this pull request with the main branch by modifying the test sets in the description of [#6163](https://github.com/apache/arrow-datafusion/pull/6163) with different values of `K`? 
   
   I am interested in these tests because we are reintroducing per-batch sorting (for TopK), which was noted as a source of inefficiency in https://github.com/apache/arrow-datafusion/pull/6163#issuecomment-1529002495:
   > The cost of sorting and copying all the values an additional time far outweighs any cache locality effects.
   
   By analyzing the results of the suggested tests, we can determine whether we need to implement simple heuristics to determine when to use eager sorting (if `K` is similar to `batch_size`) or if the performance improvement in #6163 is mainly due to the adaptive sorting algorithm over index-based sorting, and thus eager sorting will not cause performance regression.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org