You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by robertoandrade <gi...@git.apache.org> on 2016/02/24 17:17:18 UTC
[GitHub] cordova-lib pull request: Fix CB-10034
GitHub user robertoandrade opened a pull request:
https://github.com/apache/cordova-lib/pull/399
Fix CB-10034
- Moved previously committed node-xcode extension to that project. Waiting PR: https://github.com/alunny/node-xcode/pull/79
- Added options and tests for iOS frameworks to not be optionally "embedded" or "linked" depending on the use cases.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/robertoandrade/cordova-lib forkChanges
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/399.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #399
----
commit a309c5bc783ff383889e059291164b344bd7f249
Author: Roberto Andrade <ro...@cloud.com>
Date: 2016-02-24T16:14:11Z
Moved logic into node-xcode. Waiting for PR: https://github.com/alunny/node-xcode/pull/79
commit 851ea65055db60e215f65a3977aedf23547d3f89
Author: Roberto Andrade <ro...@cloud.com>
Date: 2016-02-24T16:15:23Z
Adding embed/link attributes for iOS frameworks to take advantage of optional features in node-xcode.
Addresses https://issues.apache.org/jira/browse/CB-10034
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-10034 Addresses Embedded/Linked/Signe...
Posted by robertoandrade <gi...@git.apache.org>.
Github user robertoandrade commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/399#discussion_r62616494
--- Diff: cordova-lib/package.json ---
@@ -40,7 +40,7 @@
"underscore": "1.7.0",
"unorm": "1.3.3",
"valid-identifier": "0.0.1",
- "xcode": "0.8.0"
+ "xcode": "0.8.6"
--- End diff --
Would you guys prefer I point that by git fork instead just to get the build/tests passing? I'd think pointing at a non-released version would also make it so this is not mergeable, so not sure what the best state is to leave it at.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #399: CB-10034 Addresses Embedded/Linked/Signed Custom Fra...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the issue:
https://github.com/apache/cordova-lib/pull/399
@robertoandrade I want to get this in, any word? If not I can just fork your branch and do the edits needed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #399: CB-10034 Addresses Embedded/Linked/Signed Custom Fra...
Posted by stevengill <gi...@git.apache.org>.
Github user stevengill commented on the issue:
https://github.com/apache/cordova-lib/pull/399
Thoughts on this @shazron? Something still needed?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #399: CB-10034 Addresses Embedded/Linked/Signed Custom Fra...
Posted by robertoandrade <gi...@git.apache.org>.
Github user robertoandrade commented on the issue:
https://github.com/apache/cordova-lib/pull/399
Will check it out let you guys know.
On Fri, Mar 24, 2017 at 9:03 PM Shazron Abdullah <no...@github.com>
wrote:
> @robertoandrade <https://github.com/robertoandrade> I want to get this
> in, any word? If not I can just fork your branch and do the edits needed
>
> \u2014
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/cordova-lib/pull/399#issuecomment-289176694>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AATd-extE_TMcqYkQ-MvmoN9-lwWyQ3Mks5rpGf2gaJpZM4Hh13R>
> .
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request #399: CB-10034 Addresses Embedded/Linked/Signed Cus...
Posted by cusspvz <gi...@git.apache.org>.
Github user cusspvz commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/399#discussion_r94165725
--- Diff: cordova-lib/package.json ---
@@ -40,7 +40,7 @@
"underscore": "1.7.0",
"unorm": "1.3.3",
"valid-identifier": "0.0.1",
- "xcode": "0.8.0"
+ "xcode": "0.8.6"
--- End diff --
Seems it was already merged. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #399: CB-10034 Addresses Embedded/Linked/Signed Custom Fra...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the issue:
https://github.com/apache/cordova-lib/pull/399
I need to get the `embed` attribute feature out and thus will send out a new PR by just enabling:
```
embed: isStrTrue(el.attrib.embed),
```
in `cordova-common/src/PluginInfo/PluginInfo.js`.
The rest of the code will be in the Platform API of cordova-ios. See my last comment on https://issues.apache.org/jira/browse/CB-11233
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-10034 Addresses Embedded/Linked/Signe...
Posted by robertoandrade <gi...@git.apache.org>.
Github user robertoandrade commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/399#discussion_r62616280
--- Diff: cordova-lib/package.json ---
@@ -40,7 +40,7 @@
"underscore": "1.7.0",
"unorm": "1.3.3",
"valid-identifier": "0.0.1",
- "xcode": "0.8.0"
+ "xcode": "0.8.6"
--- End diff --
Will confirm this is indeed the released version as soon as alunny/node-xcode#88 gets merged as a release is pushed out.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #399: CB-10034 Addresses Embedded/Linked/Signed Custom Fra...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the issue:
https://github.com/apache/cordova-lib/pull/399
@stevengill yes. it adds the attribute, which can't be in the Platform API and must be in cordova-lib
The PR needs a rebase and/or resolution of conflicts - pinging @robertoandrade
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org