[GitHub] [pulsar] merlimat commented on a change in pull request #7011: Fix break changes in namespace offload policy and RabbitMQ sink.

[GitBox <gi...@apache.org>]

merlimat commented on a change in pull request #7011:
URL: https://github.com/apache/pulsar/pull/7011#discussion_r428760906



##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
##########
@@ -1062,17 +1062,6 @@ public void openLedgerFailed(ManagedLedgerException exception, Object ctx) {
             managedLedgerConfig.setRetentionSizeInMB(retentionPolicies.getRetentionSizeInMB());
             managedLedgerConfig.setAutoSkipNonRecoverableData(serviceConfig.isAutoSkipNonRecoverableData());
             OffloadPolicies offloadPolicies = policies.map(p -> p.offload_policies).orElse(null);
-
-            if (offloadPolicies == null) {

Review comment:
       This code was there to fallback to defaults in case there is no special offload policy for a given namespace. How is this behavior maintained?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org