You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mina.apache.org by Jeff MAURY <je...@jeffmaury.com> on 2014/12/22 10:28:01 UTC
Re: mina git commit: [maven-release-plugin] prepare for next
development iteration
Given the fact that we introduced some kind of incompatibility (with 2.0.9
or 2.0.10), don't you think it would be valuable to witch to 2.1.X ?
Jeff
On Mon, Dec 22, 2014 at 10:25 AM, <el...@apache.org> wrote:
> Repository: mina
> Updated Branches:
> refs/heads/2.0 ea26057d8 -> 4bb91e3d5
>
>
> [maven-release-plugin] prepare for next development iteration
>
>
> Project: http://git-wip-us.apache.org/repos/asf/mina/repo
> Commit: http://git-wip-us.apache.org/repos/asf/mina/commit/4bb91e3d
> Tree: http://git-wip-us.apache.org/repos/asf/mina/tree/4bb91e3d
> Diff: http://git-wip-us.apache.org/repos/asf/mina/diff/4bb91e3d
>
> Branch: refs/heads/2.0
> Commit: 4bb91e3d51e24b02b180f779079a1f7f6fe8e2fb
> Parents: ea26057
> Author: Emmanuel Lécharny <el...@symas.com>
> Authored: Mon Dec 22 10:25:02 2014 +0100
> Committer: Emmanuel Lécharny <el...@symas.com>
> Committed: Mon Dec 22 10:25:02 2014 +0100
>
> ----------------------------------------------------------------------
> distribution/pom.xml | 2 +-
> mina-core/pom.xml | 2 +-
> mina-example/pom.xml | 2 +-
> mina-filter-compression/pom.xml | 2 +-
> mina-http/pom.xml | 2 +-
> mina-integration-beans/pom.xml | 2 +-
> mina-integration-jmx/pom.xml | 2 +-
> mina-integration-ognl/pom.xml | 2 +-
> mina-integration-xbean/pom.xml | 2 +-
> mina-legal/pom.xml | 2 +-
> mina-statemachine/pom.xml | 2 +-
> mina-transport-apr/pom.xml | 2 +-
> mina-transport-serial/pom.xml | 2 +-
> pom.xml | 4 ++--
> 14 files changed, 15 insertions(+), 15 deletions(-)
> ----------------------------------------------------------------------
>
>
>
> http://git-wip-us.apache.org/repos/asf/mina/blob/4bb91e3d/distribution/pom.xml
> ----------------------------------------------------------------------
> diff --git a/distribution/pom.xml b/distribution/pom.xml
> index 3d77f1d..4f818ef 100644
> --- a/distribution/pom.xml
> +++ b/distribution/pom.xml
> @@ -24,7 +24,7 @@
> <parent>
> <artifactId>mina-parent</artifactId>
> <groupId>org.apache.mina</groupId>
> - <version>2.0.10</version>
> + <version>2.0.11-SNAPSHOT</version>
> </parent>
>
> <artifactId>distribution</artifactId>
>
> http://git-wip-us.apache.org/repos/asf/mina/blob/4bb91e3d/mina-core/pom.xml
> ----------------------------------------------------------------------
> diff --git a/mina-core/pom.xml b/mina-core/pom.xml
> index d1c781c..4078925 100644
> --- a/mina-core/pom.xml
> +++ b/mina-core/pom.xml
> @@ -24,7 +24,7 @@
> <parent>
> <groupId>org.apache.mina</groupId>
> <artifactId>mina-parent</artifactId>
> - <version>2.0.10</version>
> + <version>2.0.11-SNAPSHOT</version>
> </parent>
>
> <artifactId>mina-core</artifactId>
>
>
> http://git-wip-us.apache.org/repos/asf/mina/blob/4bb91e3d/mina-example/pom.xml
> ----------------------------------------------------------------------
> diff --git a/mina-example/pom.xml b/mina-example/pom.xml
> index bffdfaa..744e189 100644
> --- a/mina-example/pom.xml
> +++ b/mina-example/pom.xml
> @@ -21,7 +21,7 @@
> <parent>
> <groupId>org.apache.mina</groupId>
> <artifactId>mina-parent</artifactId>
> - <version>2.0.10</version>
> + <version>2.0.11-SNAPSHOT</version>
> </parent>
>
> <artifactId>mina-example</artifactId>
>
>
> http://git-wip-us.apache.org/repos/asf/mina/blob/4bb91e3d/mina-filter-compression/pom.xml
> ----------------------------------------------------------------------
> diff --git a/mina-filter-compression/pom.xml
> b/mina-filter-compression/pom.xml
> index 2522672..63537c0 100644
> --- a/mina-filter-compression/pom.xml
> +++ b/mina-filter-compression/pom.xml
> @@ -24,7 +24,7 @@
> <parent>
> <groupId>org.apache.mina</groupId>
> <artifactId>mina-parent</artifactId>
> - <version>2.0.10</version>
> + <version>2.0.11-SNAPSHOT</version>
> </parent>
>
> <artifactId>mina-filter-compression</artifactId>
>
> http://git-wip-us.apache.org/repos/asf/mina/blob/4bb91e3d/mina-http/pom.xml
> ----------------------------------------------------------------------
> diff --git a/mina-http/pom.xml b/mina-http/pom.xml
> index 6f0a124..165b4ec 100644
> --- a/mina-http/pom.xml
> +++ b/mina-http/pom.xml
> @@ -24,7 +24,7 @@
> <parent>
> <groupId>org.apache.mina</groupId>
> <artifactId>mina-parent</artifactId>
> - <version>2.0.10</version>
> + <version>2.0.11-SNAPSHOT</version>
> </parent>
>
> <artifactId>mina-http</artifactId>
>
>
> http://git-wip-us.apache.org/repos/asf/mina/blob/4bb91e3d/mina-integration-beans/pom.xml
> ----------------------------------------------------------------------
> diff --git a/mina-integration-beans/pom.xml
> b/mina-integration-beans/pom.xml
> index 84f7cc8..8d54d2b 100644
> --- a/mina-integration-beans/pom.xml
> +++ b/mina-integration-beans/pom.xml
> @@ -24,7 +24,7 @@
> <parent>
> <groupId>org.apache.mina</groupId>
> <artifactId>mina-parent</artifactId>
> - <version>2.0.10</version>
> + <version>2.0.11-SNAPSHOT</version>
> </parent>
>
> <artifactId>mina-integration-beans</artifactId>
>
>
> http://git-wip-us.apache.org/repos/asf/mina/blob/4bb91e3d/mina-integration-jmx/pom.xml
> ----------------------------------------------------------------------
> diff --git a/mina-integration-jmx/pom.xml b/mina-integration-jmx/pom.xml
> index cfe9c02..790d689 100644
> --- a/mina-integration-jmx/pom.xml
> +++ b/mina-integration-jmx/pom.xml
> @@ -24,7 +24,7 @@
> <parent>
> <groupId>org.apache.mina</groupId>
> <artifactId>mina-parent</artifactId>
> - <version>2.0.10</version>
> + <version>2.0.11-SNAPSHOT</version>
> </parent>
>
> <artifactId>mina-integration-jmx</artifactId>
>
>
> http://git-wip-us.apache.org/repos/asf/mina/blob/4bb91e3d/mina-integration-ognl/pom.xml
> ----------------------------------------------------------------------
> diff --git a/mina-integration-ognl/pom.xml b/mina-integration-ognl/pom.xml
> index 7badf44..0aeaa34 100644
> --- a/mina-integration-ognl/pom.xml
> +++ b/mina-integration-ognl/pom.xml
> @@ -24,7 +24,7 @@
> <parent>
> <groupId>org.apache.mina</groupId>
> <artifactId>mina-parent</artifactId>
> - <version>2.0.10</version>
> + <version>2.0.11-SNAPSHOT</version>
> </parent>
>
> <artifactId>mina-integration-ognl</artifactId>
>
>
> http://git-wip-us.apache.org/repos/asf/mina/blob/4bb91e3d/mina-integration-xbean/pom.xml
> ----------------------------------------------------------------------
> diff --git a/mina-integration-xbean/pom.xml
> b/mina-integration-xbean/pom.xml
> index cdeed1f..0b48a60 100644
> --- a/mina-integration-xbean/pom.xml
> +++ b/mina-integration-xbean/pom.xml
> @@ -24,7 +24,7 @@
> <parent>
> <groupId>org.apache.mina</groupId>
> <artifactId>mina-parent</artifactId>
> - <version>2.0.10</version>
> + <version>2.0.11-SNAPSHOT</version>
> </parent>
> <modelVersion>4.0.0</modelVersion>
>
>
>
> http://git-wip-us.apache.org/repos/asf/mina/blob/4bb91e3d/mina-legal/pom.xml
> ----------------------------------------------------------------------
> diff --git a/mina-legal/pom.xml b/mina-legal/pom.xml
> index e855a9c..aac8821 100644
> --- a/mina-legal/pom.xml
> +++ b/mina-legal/pom.xml
> @@ -21,7 +21,7 @@
> <parent>
> <groupId>org.apache.mina</groupId>
> <artifactId>mina-parent</artifactId>
> - <version>2.0.10</version>
> + <version>2.0.11-SNAPSHOT</version>
> </parent>
>
> <artifactId>mina-legal</artifactId>
>
>
> http://git-wip-us.apache.org/repos/asf/mina/blob/4bb91e3d/mina-statemachine/pom.xml
> ----------------------------------------------------------------------
> diff --git a/mina-statemachine/pom.xml b/mina-statemachine/pom.xml
> index 1f4a2fb..ce9701d 100644
> --- a/mina-statemachine/pom.xml
> +++ b/mina-statemachine/pom.xml
> @@ -24,7 +24,7 @@
> <parent>
> <groupId>org.apache.mina</groupId>
> <artifactId>mina-parent</artifactId>
> - <version>2.0.10</version>
> + <version>2.0.11-SNAPSHOT</version>
> </parent>
>
> <artifactId>mina-statemachine</artifactId>
>
>
> http://git-wip-us.apache.org/repos/asf/mina/blob/4bb91e3d/mina-transport-apr/pom.xml
> ----------------------------------------------------------------------
> diff --git a/mina-transport-apr/pom.xml b/mina-transport-apr/pom.xml
> index fb031f3..f1bdfe5 100644
> --- a/mina-transport-apr/pom.xml
> +++ b/mina-transport-apr/pom.xml
> @@ -22,7 +22,7 @@
> <parent>
> <groupId>org.apache.mina</groupId>
> <artifactId>mina-parent</artifactId>
> - <version>2.0.10</version>
> + <version>2.0.11-SNAPSHOT</version>
> </parent>
>
> <artifactId>mina-transport-apr</artifactId>
>
>
> http://git-wip-us.apache.org/repos/asf/mina/blob/4bb91e3d/mina-transport-serial/pom.xml
> ----------------------------------------------------------------------
> diff --git a/mina-transport-serial/pom.xml b/mina-transport-serial/pom.xml
> index c52838c..589111e 100644
> --- a/mina-transport-serial/pom.xml
> +++ b/mina-transport-serial/pom.xml
> @@ -24,7 +24,7 @@
> <parent>
> <groupId>org.apache.mina</groupId>
> <artifactId>mina-parent</artifactId>
> - <version>2.0.10</version>
> + <version>2.0.11-SNAPSHOT</version>
> </parent>
>
> <artifactId>mina-transport-serial</artifactId>
>
> http://git-wip-us.apache.org/repos/asf/mina/blob/4bb91e3d/pom.xml
> ----------------------------------------------------------------------
> diff --git a/pom.xml b/pom.xml
> index 34f7617..1ad8ee6 100644
> --- a/pom.xml
> +++ b/pom.xml
> @@ -38,7 +38,7 @@
> </organization>
>
> <groupId>org.apache.mina</groupId>
> - <version>2.0.10</version>
> + <version>2.0.11-SNAPSHOT</version>
> <artifactId>mina-parent</artifactId>
> <name>Apache MINA</name>
> <packaging>pom</packaging>
> @@ -55,7 +55,7 @@
> <connection>scm:git:https://git-wip-us.apache.org/repos/asf/mina.git
> </connection>
> <url>https://github.com/apache/mina/tree/2.0</url>
> <developerConnection>scm:git:
> https://git-wip-us.apache.org/repos/asf/mina.git</developerConnection>
> - <tag>2.0.10</tag>
> + <tag>HEAD</tag>
> </scm>
>
> <distributionManagement>
>
>
--
Jeff MAURY
"Legacy code" often differs from its suggested alternative by actually
working and scaling.
- Bjarne Stroustrup
http://www.jeffmaury.com
http://riadiscuss.jeffmaury.com
http://www.twitter.com/jeffmaury
Re: mina git commit: [maven-release-plugin] prepare for next development
iteration
Posted by Emmanuel Lécharny <el...@gmail.com>.
Le 22/12/14 11:39, Jeff MAURY a écrit :
> +1 for 2 interfaces
Ok, now that's complicated...
Now that 2.0.9 is out, we have many users that have already change their
code to fit with the broken interface.
If we rollback this change, we will break again the API, and we will
upset tehm once more.
The alternative would be to have two 2.0.10 branches, which would be a
total mess...
Sadly, the change which broke the API for 2.0 was done months ago, and
we probably can assume that we must carry on at this point, as I don't
see any way to mitigate the pb without hurting more our current
2.0.8/2.0.9 users...
wdyt ?
Re: mina git commit: [maven-release-plugin] prepare for next
development iteration
Posted by Jeff MAURY <je...@jeffmaury.com>.
Done
Jeff
On Mon, Dec 22, 2014 at 11:57 AM, Emmanuel Lécharny <el...@gmail.com>
wrote:
> Le 22/12/14 11:39, Jeff MAURY a écrit :
> > +1 for 2 interfaces
>
> Ok, I'll do that.
>
> Jeff, can you delete the tag I just created for MINA 2.0.10 ?
>
> Thanks !
>
--
Jeff MAURY
"Legacy code" often differs from its suggested alternative by actually
working and scaling.
- Bjarne Stroustrup
http://www.jeffmaury.com
http://riadiscuss.jeffmaury.com
http://www.twitter.com/jeffmaury
Re: mina git commit: [maven-release-plugin] prepare for next development
iteration
Posted by Emmanuel Lécharny <el...@gmail.com>.
Le 22/12/14 11:39, Jeff MAURY a écrit :
> +1 for 2 interfaces
Ok, I'll do that.
Jeff, can you delete the tag I just created for MINA 2.0.10 ?
Thanks !
Re: mina git commit: [maven-release-plugin] prepare for next
development iteration
Posted by Jeff MAURY <je...@jeffmaury.com>.
+1 for 2 interfaces
Jeff
On Mon, Dec 22, 2014 at 11:36 AM, Emmanuel Lécharny <el...@gmail.com>
wrote:
> Le 22/12/14 11:26, Emmanuel Lécharny a écrit :
> > Le 22/12/14 11:05, Emmanuel Lécharny a écrit :
> >> Le 22/12/14 10:28, Jeff MAURY a écrit :
> >>> Given the fact that we introduced some kind of incompatibility (with
> 2.0.9
> >>> or 2.0.10), don't you think it would be valuable to witch to 2.1.X ?
> >> We probably should. My mistake would then be fixed.
> >>
> >>
> > The real pb is that MOINA 2.0.8 broke the API, and if we switch to 2.1.0
> > - the move we should have made back then - that would mean we should
> > create a new branch 2.0.10 where we remove the change I intriduced in
> > 2.0.8. Here is the
> >
> >
> > 2.0.7 -+-> 2.0.8 (whith API change, wrong) --> 2.0.9 (still wrong) -->
> > 2.0.10 (dead branch)
> > | \ | \
> > | \ | \
> > +-------+------------------------------------+---------------->
> > 2.0.10 (with a revert on the changed API)
> > |
> |
> >
> +---------------------------------------------+
> >
> > +--> 2.1.0 ( with the API change)
> >
> > So if we cut 2 releases :
> > * 2.0.10 which contains the change done in 2.0.8 and 2.0.9 but rollback
> > the changes in teh API done in 2.0.8
> > * 2.1.0 which is a branch done based on 2.0.10 but with the change done
> > in the API
> >
> > do you think that is a viable solution ?
> >
> >
> Another option would be to add a new Interface in 2.0.10 that those who
> want to benefit from the /inputClosed() event will have to implement. We
> roll back the previous interface to what it was.
> /
>
--
Jeff MAURY
"Legacy code" often differs from its suggested alternative by actually
working and scaling.
- Bjarne Stroustrup
http://www.jeffmaury.com
http://riadiscuss.jeffmaury.com
http://www.twitter.com/jeffmaury
Re: mina git commit: [maven-release-plugin] prepare for next development
iteration
Posted by Emmanuel Lécharny <el...@gmail.com>.
Le 22/12/14 11:26, Emmanuel Lécharny a écrit :
> Le 22/12/14 11:05, Emmanuel Lécharny a écrit :
>> Le 22/12/14 10:28, Jeff MAURY a écrit :
>>> Given the fact that we introduced some kind of incompatibility (with 2.0.9
>>> or 2.0.10), don't you think it would be valuable to witch to 2.1.X ?
>> We probably should. My mistake would then be fixed.
>>
>>
> The real pb is that MOINA 2.0.8 broke the API, and if we switch to 2.1.0
> - the move we should have made back then - that would mean we should
> create a new branch 2.0.10 where we remove the change I intriduced in
> 2.0.8. Here is the
>
>
> 2.0.7 -+-> 2.0.8 (whith API change, wrong) --> 2.0.9 (still wrong) -->
> 2.0.10 (dead branch)
> | \ | \
> | \ | \
> +-------+------------------------------------+---------------->
> 2.0.10 (with a revert on the changed API)
> | |
> +---------------------------------------------+
>
> +--> 2.1.0 ( with the API change)
>
> So if we cut 2 releases :
> * 2.0.10 which contains the change done in 2.0.8 and 2.0.9 but rollback
> the changes in teh API done in 2.0.8
> * 2.1.0 which is a branch done based on 2.0.10 but with the change done
> in the API
>
> do you think that is a viable solution ?
>
>
Another option would be to add a new Interface in 2.0.10 that those who
want to benefit from the /inputClosed() event will have to implement. We
roll back the previous interface to what it was.
/
Re: mina git commit: [maven-release-plugin] prepare for next development
iteration
Posted by Emmanuel Lécharny <el...@gmail.com>.
Le 22/12/14 11:05, Emmanuel Lécharny a écrit :
> Le 22/12/14 10:28, Jeff MAURY a écrit :
>> Given the fact that we introduced some kind of incompatibility (with 2.0.9
>> or 2.0.10), don't you think it would be valuable to witch to 2.1.X ?
> We probably should. My mistake would then be fixed.
>
>
The real pb is that MOINA 2.0.8 broke the API, and if we switch to 2.1.0
- the move we should have made back then - that would mean we should
create a new branch 2.0.10 where we remove the change I intriduced in
2.0.8. Here is the
2.0.7 -+-> 2.0.8 (whith API change, wrong) --> 2.0.9 (still wrong) -->
2.0.10 (dead branch)
| \ | \
| \ | \
+-------+------------------------------------+---------------->
2.0.10 (with a revert on the changed API)
| |
+---------------------------------------------+
+--> 2.1.0 ( with the API change)
So if we cut 2 releases :
* 2.0.10 which contains the change done in 2.0.8 and 2.0.9 but rollback
the changes in teh API done in 2.0.8
* 2.1.0 which is a branch done based on 2.0.10 but with the change done
in the API
do you think that is a viable solution ?
Re: mina git commit: [maven-release-plugin] prepare for next development
iteration
Posted by Emmanuel Lécharny <el...@gmail.com>.
Le 22/12/14 10:28, Jeff MAURY a écrit :
> Given the fact that we introduced some kind of incompatibility (with 2.0.9
> or 2.0.10), don't you think it would be valuable to witch to 2.1.X ?
We probably should. My mistake would then be fixed.