[GitHub] [arrow-rs] tustvold commented on a diff in pull request #4064: Add StructArray Constructors (#3879)

["tustvold (via GitHub)" <gi...@apache.org>]

tustvold commented on code in PR #4064:
URL: https://github.com/apache/arrow-rs/pull/4064#discussion_r1176696424


##########
arrow-array/src/array/struct_array.rs:
##########
@@ -309,66 +309,18 @@ impl TryFrom<Vec<(&str, ArrayRef)>> for StructArray {
     type Error = ArrowError;
 
     /// builds a StructArray from a vector of names and arrays.
-    /// This errors if the values have a different length.
-    /// An entry is set to Null when all values are null.

Review Comment:
   This doc comment isn't rendered in docs.rs so this somewhat peculiar behaviour was effectively not documented



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org