[incubator-plc4x] branch develop updated (9db9e6b -> 316fdbd)

[cd...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

cdutz pushed a change to branch develop
in repository https://gitbox.apache.org/repos/asf/incubator-plc4x.git.


    from 9db9e6b  - Found another place where tests fail on systems with DNS providers that return default IPs
     new 232bef5  - Disabled one test we simply can't check reliably in case of DNS providers returning default IP addresses for unknown domain names
     new 316fdbd  - Replaced the hostname we expect not to exist with one a little more obvious.

The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 .../src/test/java/org/apache/plc4x/java/modbus/ModbusPlcDriverTest.java | 2 +-
 .../s7/src/test/java/org/apache/plc4x/java/s7/S7PlcDriverTest.java      | 2 ++
 2 files changed, 3 insertions(+), 1 deletion(-)

[incubator-plc4x] 02/02: - Replaced the hostname we expect not to exist with one a little more obvious.

[cd...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

cdutz pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/incubator-plc4x.git

commit 316fdbd67e6059518329c436aaf1c7ba4f9d9d20
Author: Christofer Dutz <ch...@c-ware.de>
AuthorDate: Thu Jan 17 12:57:17 2019 +0100

    - Replaced the hostname we expect not to exist with one a little more obvious.
---
 .../src/test/java/org/apache/plc4x/java/modbus/ModbusPlcDriverTest.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/plc4j/drivers/modbus/src/test/java/org/apache/plc4x/java/modbus/ModbusPlcDriverTest.java b/plc4j/drivers/modbus/src/test/java/org/apache/plc4x/java/modbus/ModbusPlcDriverTest.java
index 39364a5..d2bea5e 100644
--- a/plc4j/drivers/modbus/src/test/java/org/apache/plc4x/java/modbus/ModbusPlcDriverTest.java
+++ b/plc4j/drivers/modbus/src/test/java/org/apache/plc4x/java/modbus/ModbusPlcDriverTest.java
@@ -96,7 +96,7 @@ public class ModbusPlcDriverTest {
 
     @Test(expected = PlcConnectionException.class)
     public void getConnectionUnknownHost() throws Exception {
-        new PlcDriverManager().getConnection("modbus:tcp://nowhere:8080");
+        new PlcDriverManager().getConnection("modbus:tcp://IHopeThisHostDoesntExistAAAAAAAAhhhhhhh:8080");
     }
 
     @Test(expected = PlcConnectionException.class)

[incubator-plc4x] 01/02: - Disabled one test we simply can't check reliably in case of DNS providers returning default IP addresses for unknown domain names

[cd...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

cdutz pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/incubator-plc4x.git

commit 232bef574fde9923323382f27fd201a35bba0a9f
Author: Christofer Dutz <ch...@c-ware.de>
AuthorDate: Thu Jan 17 12:56:47 2019 +0100

    - Disabled one test we simply can't check reliably in case of DNS providers returning default IP addresses for unknown domain names
---
 .../s7/src/test/java/org/apache/plc4x/java/s7/S7PlcDriverTest.java      | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/plc4j/drivers/s7/src/test/java/org/apache/plc4x/java/s7/S7PlcDriverTest.java b/plc4j/drivers/s7/src/test/java/org/apache/plc4x/java/s7/S7PlcDriverTest.java
index a93fe0f..76329e9 100644
--- a/plc4j/drivers/s7/src/test/java/org/apache/plc4x/java/s7/S7PlcDriverTest.java
+++ b/plc4j/drivers/s7/src/test/java/org/apache/plc4x/java/s7/S7PlcDriverTest.java
@@ -23,6 +23,7 @@ import org.apache.plc4x.java.api.exceptions.PlcConnectionException;
 import org.apache.plc4x.java.api.exceptions.PlcException;
 import org.apache.plc4x.java.s7.connection.S7PlcConnection;
 import org.apache.plc4x.test.FastTests;
+import org.junit.Ignore;
 import org.junit.Test;
 import org.junit.experimental.categories.Category;
 
@@ -53,6 +54,7 @@ public class S7PlcDriverTest {
 
     @Test(expected = PlcConnectionException.class)
     @Category(FastTests.class)
+    @Ignore("This test tends to fail on systems with DNS providers that proivde default IPs")
     public void getConnectionToUnknownHost() throws PlcException {
         new S7PlcDriver().connect("s7://IHopeThisHostDoesntExistAAAAAAAAhhhhhhh/1/2");
     }