[jira] [Closed] (GEODE-9109) The local filter (CQ/Interest) computation code seems to be not needed

["Owen Nichols (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/GEODE-9109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Owen Nichols closed GEODE-9109.
-------------------------------

> The local filter (CQ/Interest) computation code seems to be not needed
> ----------------------------------------------------------------------
>
>                 Key: GEODE-9109
>                 URL: https://issues.apache.org/jira/browse/GEODE-9109
>             Project: Geode
>          Issue Type: Bug
>          Components: transactions
>    Affects Versions: 1.15.0
>            Reporter: Anilkumar Gingade
>            Assignee: Eric Shu
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.15.0
>
>
> In TxCallbackEventFactoryImpl.createCallbackEvent() there is logic which looks to see if filters (CQ/Interests) needs to be computed after receiving the TX commit message from remote. Since with GEODE-8926 the computation for remote nodes happen in primary only the logic here looks like unnecessary.
> {code:java}
> boolean computeFilterInfo = false;
>       if (filterRoutingInfo != null) {
>         localRouting = filterRoutingInfo.getLocalFilterInfo();
>         if (localRouting != null) {
>           // routing was computed in this VM but may need to perform local interest processing
>           computeFilterInfo = !filterRoutingInfo.hasLocalInterestBeenComputed()
>               && !localRouting.filterProcessedLocally;
>         } else {
>           // routing was computed elsewhere and is in the "remote" routing table
>           localRouting = filterRoutingInfo.getFilterInfo(internalRegion.getMyId());
>         }
>         if (localRouting != null) {
>           if (!computeFilterInfo) {
>             retVal.setLocalFilterInfo(localRouting);
>           }
>         }
>       }
> {code}
> Check with computeFilterInfo.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)