[GitHub] [incubator-superset] mistercrunch commented on pull request #10104: style: dataset modal view

[GitBox <gi...@apache.org>]

mistercrunch commented on pull request #10104:
URL: https://github.com/apache/incubator-superset/pull/10104#issuecomment-647048156


   I wanted to point to the similarity with `<TableSelector/>` that is used in SQL Lab left pane and in the current Datasource editor. Eventually I think we'll want a single components for all 3 contexts.
   
   <img width="530" alt="Screen Shot 2020-06-20 at 2 33 52 PM" src="https://user-images.githubusercontent.com/487433/85211980-1792ec80-b303-11ea-89a7-6dc0c4a8a952.png">
   <img width="427" alt="Screen Shot 2020-06-20 at 2 33 16 PM" src="https://user-images.githubusercontent.com/487433/85211982-195cb000-b303-11ea-8fc5-c57e87c7c816.png">
   
   Let's make sure we don't end up with twice the components and twice the endpoints as we rebuild things.
   
   We should talk about how to approach the `<TableEditor/>`. It's fairly complex and quite a bit of work went in the current one. Also note that we haven't fully deprecated the FAB CRUD there too, let's not add a 3rd implementation of the same thing.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org