You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "HuaHuaY (via GitHub)" <gi...@apache.org> on 2026/02/10 04:05:01 UTC

[PR] GH-49081: [C++][Parquet][FOLLOWUP] Correct variant's extension name [arrow]

HuaHuaY opened a new pull request, #49211:
URL: https://github.com/apache/arrow/pull/49211

   ### Rationale for this change
   
   Previous PR moved one file, modified the CMakeLists but didn't modify the meson file. Fix meson build failure.
   
   ### What changes are included in this PR?
   
   Modified the meson configuration files.
   
   ### Are these changes tested?
   
   Yes.
   
   ### Are there any user-facing changes?
   
   No.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-49081: [C++][Parquet][FOLLOWUP] Correct variant's extension name [arrow]

Posted by "HuaHuaY (via GitHub)" <gi...@apache.org>.
HuaHuaY commented on PR #49211:
URL: https://github.com/apache/arrow/pull/49211#issuecomment-3875200483

   @WillAyd Current CI does not check whether code can be compiled by meson successfully. Do we need to add a CI to check this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-49081: [C++][Parquet][FOLLOWUP] Correct variant's extension name [arrow]

Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac merged PR #49211:
URL: https://github.com/apache/arrow/pull/49211


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-49081: [C++][Parquet][FOLLOWUP] Correct variant's extension name [arrow]

Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #49211:
URL: https://github.com/apache/arrow/pull/49211#discussion_r2785684118


##########
cpp/src/arrow/meson.build:
##########
@@ -141,6 +141,7 @@ arrow_components = {
             'extension_type.cc',
             'extension/bool8.cc',
             'extension/json.cc',
+            'extension/parquet_variant.cc',
             'extension/uuid.cc',

Review Comment:
   Meson currently installs only a fixed list of headers for `arrow/extension` (see `cpp/src/arrow/extension/meson.build`), and `parquet_variant.h` isn’t in that list. After adding `extension/parquet_variant.cc` to the build here, `meson install` will still omit the public header, which makes downstream includes like `#include "arrow/extension/parquet_variant.h"` fail for Meson-based installations. Please also update the Meson header install list (and any related extension test lists if applicable) to include `parquet_variant.h` so Meson matches CMake’s `arrow_install_all_headers("arrow/extension")` behavior.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-49081: [C++][Parquet][FOLLOWUP] Correct variant's extension name [arrow]

Posted by "WillAyd (via GitHub)" <gi...@apache.org>.
WillAyd commented on PR #49211:
URL: https://github.com/apache/arrow/pull/49211#issuecomment-3877600469

   > @WillAyd Current CI does not check whether code can be compiled by meson successfully. Do we need to add a CI to check this?
   
   For Meson to run the C++ Extra tag has to be used


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org