You are viewing a plain text version of this content. The canonical link for it is here.

Posted to oak-issues@jackrabbit.apache.org by "Michael Dürig (JIRA)" <ji...@apache.org> on 2016/06/15 10:34:09 UTC

[jira] [Resolved] (OAK-4472) Decouple SegmentReader from Revisions

     [ https://issues.apache.org/jira/browse/OAK-4472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Dürig resolved OAK-4472.
--------------------------------
    Resolution: Fixed

Fixed at http://svn.apache.org/viewvc?rev=1748542&view=rev

> Decouple SegmentReader from Revisions
> -------------------------------------
>
>                 Key: OAK-4472
>                 URL: https://issues.apache.org/jira/browse/OAK-4472
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: segment-tar
>            Reporter: Michael Dürig
>            Assignee: Michael Dürig
>              Labels: technical_debt
>             Fix For: 1.6
>
>
> The {{SegmentReader.readHeadState()}} introduces a de-facto dependency to {{Revisions}} as access to the latter is required for obtaining the record id of the head. 
> To decouple SegmentReader from Revisions I propose to replace {{SegmentReader.readHeadState()}} with {{SegmentReader.readHeadState(Revisions revisions)}}. As this results in a lot of boilerplate for callers (i.e. {{fileStore.getReader().getHeadState(fileStore.getRevisions())}}), we should also introduce a convenience method {{FileStore.getHead()}} clients could use to that matter.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)