You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/11/17 06:17:29 UTC
[GitHub] [flink] danny0405 opened a new pull request #14091: [FLINK-20142][doc] Update the document for CREATE TABLE LIKE that sou…
danny0405 opened a new pull request #14091:
URL: https://github.com/apache/flink/pull/14091
…rce table from different catalog is supported
## What is the purpose of the change
Update the document to specify `CREATE TABLE LIKE` supports compound identifier as source table.
## Brief change log
*(for example:)*
- Modify `create.md` and `create_zh.md`.
## Verifying this change
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
Build with the local changes
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? docs
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] danny0405 commented on pull request #14091: [FLINK-20142][doc] Update the document for CREATE TABLE LIKE that sou…
Posted by GitBox <gi...@apache.org>.
danny0405 commented on pull request #14091:
URL: https://github.com/apache/flink/pull/14091#issuecomment-728717364
Hi, @dawidwys , can you take a look for this ? Thanks in advance ~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14091: [FLINK-20142][doc] Update the document for CREATE TABLE LIKE that sou…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14091:
URL: https://github.com/apache/flink/pull/14091#issuecomment-728721890
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "12fe0a5dc44839696ec045e8477c3dd814bd4bf8",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "12fe0a5dc44839696ec045e8477c3dd814bd4bf8",
"triggerType" : "PUSH"
}, {
"hash" : "a04aee439abb85a7e1cfac9c15d192e8d159df9c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9682",
"triggerID" : "a04aee439abb85a7e1cfac9c15d192e8d159df9c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 12fe0a5dc44839696ec045e8477c3dd814bd4bf8 UNKNOWN
* a04aee439abb85a7e1cfac9c15d192e8d159df9c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9682)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14091: [FLINK-20142][doc] Update the document for CREATE TABLE LIKE that sou…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14091:
URL: https://github.com/apache/flink/pull/14091#issuecomment-728721890
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "12fe0a5dc44839696ec045e8477c3dd814bd4bf8",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "12fe0a5dc44839696ec045e8477c3dd814bd4bf8",
"triggerType" : "PUSH"
}, {
"hash" : "a04aee439abb85a7e1cfac9c15d192e8d159df9c",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9682",
"triggerID" : "a04aee439abb85a7e1cfac9c15d192e8d159df9c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 12fe0a5dc44839696ec045e8477c3dd814bd4bf8 UNKNOWN
* a04aee439abb85a7e1cfac9c15d192e8d159df9c Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9682)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14091: [FLINK-20142][doc] Update the document for CREATE TABLE LIKE that sou…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14091:
URL: https://github.com/apache/flink/pull/14091#issuecomment-728721890
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "12fe0a5dc44839696ec045e8477c3dd814bd4bf8",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "12fe0a5dc44839696ec045e8477c3dd814bd4bf8",
"triggerType" : "PUSH"
}, {
"hash" : "a04aee439abb85a7e1cfac9c15d192e8d159df9c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a04aee439abb85a7e1cfac9c15d192e8d159df9c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 12fe0a5dc44839696ec045e8477c3dd814bd4bf8 UNKNOWN
* a04aee439abb85a7e1cfac9c15d192e8d159df9c UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dawidwys merged pull request #14091: [FLINK-20142][doc] Update the document for CREATE TABLE LIKE that sou…
Posted by GitBox <gi...@apache.org>.
dawidwys merged pull request #14091:
URL: https://github.com/apache/flink/pull/14091
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14091: [FLINK-20142][doc] Update the document for CREATE TABLE LIKE that sou…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14091:
URL: https://github.com/apache/flink/pull/14091#issuecomment-728721890
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "12fe0a5dc44839696ec045e8477c3dd814bd4bf8",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "12fe0a5dc44839696ec045e8477c3dd814bd4bf8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 12fe0a5dc44839696ec045e8477c3dd814bd4bf8 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14091: [FLINK-20142][doc] Update the document for CREATE TABLE LIKE that sou…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14091:
URL: https://github.com/apache/flink/pull/14091#issuecomment-728712958
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 12fe0a5dc44839696ec045e8477c3dd814bd4bf8 (Tue Nov 17 06:19:14 UTC 2020)
**Warnings:**
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-20142).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org