You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/10/12 06:52:33 UTC

[GitHub] [netbeans] JaroslavTulach opened a new pull request #2447: Adding debugging support to the Apache NetBeans VSCode Extension

JaroslavTulach opened a new pull request #2447:
URL: https://github.com/apache/netbeans/pull/2447

I'd like to propose an addition over the initial work of @jlahoda that enhances the existing VSCode extension with support for debugging. @dbalek contributed enhancements to the typescript glue code and upgraded Eclipse LSP libraries to version 0.9 together with adding support for debug adapter protocol. @entlicher connected the protocol with the NetBeans debugging APIs. I organized the code into suite and standardized the CLI options.

### Architecture

#### CLI Options

The `java/java.lsp.server` module provides the `--start-java-language-server` as well as `--start-java-debug-adapter-server` options that provide a generally usable server for any LSP/DAP client. These options are available in standard NetBeans distribution.

#### Integration Suite

The `java/java.lsp.server/nbcode` suite is an NetBeans application suite that selects only some NetBeans modules and provides additional integration services - right now there is support for `IOProvider` and `StatusDisplayer` that forward the UI over the LSP protocol. Better and additional (think of `DialogDisplayer`) support is welcomed in the future.

#### Actual VSCode Extension

Then there is a `java/java.lsp.server/vscode` typescript project (btw. can be opened, edited, compiled from NetBeans IDE) which takes the ZIP generated by the `nbcode` suite and includes it in a `.vsix` file - e.g. the VSCode extension. The extension can then be installed into VSCode.

#### Launcher

The idea is that when a Java support is needed, the VSCode extension launches headless NetBeans application behind the scene and establishes LSP and DAP connections. Whenever new VSCode UI is launched, it shares the NetBeans backend and reuses it. Closing all VSCode UIs closes the NetBeans backend as well.

The launcher attempts to support extensibility. `nbcode.ts` scans all activated extensions and collects clusters from `nbcode` subdirectory. As such it is possible for various VSCode extensions to contribute modules into the same backend and enhance its functionality.

### Working with the code

See [java/java.lsp.server/vscode/README.md](https://github.com/apache/netbeans/blob/master/java/java.lsp.server/vscode/README.md) for instructions how to develop & build the VSCode extension.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] JaroslavTulach commented on pull request #2447: Adding debugging support to the Apache NetBeans VSCode Extension

Posted by GitBox <gi...@apache.org>.

JaroslavTulach commented on pull request #2447:
URL: https://github.com/apache/netbeans/pull/2447#issuecomment-707430139

> I am fine with this, I guess.

Thanks. I integrate today then. There are some other changes in the queue (Martin has some and clearly #2389 contains a merge conflict) and it'd be better to have them in by feature freeze.

> Some files are likely to need license headers (e.g. build-impl.xml, the build should say which ones). Otherwise,

I [have added headers](https://github.com/apache/netbeans/pull/2447/commits/56ac003b76f2c4fcc7af0dca52e1cc18c20f9413#diff-54bf8b48fd1ceeba5f9d7252feaf812a357e9ca64489296b233d7e6dd6d3ebb1R1) to files where the Travis check complained. The `build-impl.xml` is excluded from the RAT check:
```bash
netbeans$ cat nbbuild/rat-exclusions.txt | grep build-impl
**/nbproject/build-impl.xml
nbi/engine/nbproject/profiler-build-impl.xml
```
The `build-impl.xml` in question was created by me and fully belongs to Apache.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] ahmednrana commented on pull request #2447: Adding debugging support to the Apache NetBeans VSCode Extension

Posted by GitBox <gi...@apache.org>.

ahmednrana commented on pull request #2447:
URL: https://github.com/apache/netbeans/pull/2447#issuecomment-766195567


   Does this add Remote debugging support as well?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] JaroslavTulach merged pull request #2447: Adding debugging support to the Apache NetBeans VSCode Extension

Posted by GitBox <gi...@apache.org>.

JaroslavTulach merged pull request #2447:
URL: https://github.com/apache/netbeans/pull/2447


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists