You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by no...@apache.org on 2007/02/22 13:32:49 UTC

svn commit: r510480 - in /james/mime4j/trunk/src/main/java/org/mime4j: AbstractContentHandler.java BodyDescriptor.java SimpleContentHandler.java message/Header.java

Author: norman
Date: Thu Feb 22 04:32:48 2007
New Revision: 510480

URL: http://svn.apache.org/viewvc?view=rev&rev=510480
Log:
Add javadocs
Remove duplicate code
Header.toString() representation needs to have CRLFCRLF 

Modified:
    james/mime4j/trunk/src/main/java/org/mime4j/AbstractContentHandler.java
    james/mime4j/trunk/src/main/java/org/mime4j/BodyDescriptor.java
    james/mime4j/trunk/src/main/java/org/mime4j/SimpleContentHandler.java
    james/mime4j/trunk/src/main/java/org/mime4j/message/Header.java

Modified: james/mime4j/trunk/src/main/java/org/mime4j/AbstractContentHandler.java
URL: http://svn.apache.org/viewvc/james/mime4j/trunk/src/main/java/org/mime4j/AbstractContentHandler.java?view=diff&rev=510480&r1=510479&r2=510480
==============================================================================
--- james/mime4j/trunk/src/main/java/org/mime4j/AbstractContentHandler.java (original)
+++ james/mime4j/trunk/src/main/java/org/mime4j/AbstractContentHandler.java Thu Feb 22 04:32:48 2007
@@ -31,30 +31,81 @@
  */
 public abstract class AbstractContentHandler implements ContentHandler {
     
+    /**
+     * @see org.mime4j.ContentHandler#endMultipart()
+     */
     public void endMultipart() {
     }
+    
+    /**
+     * @see org.mime4j.ContentHandler#startMultipart(org.mime4j.BodyDescriptor)
+     */
     public void startMultipart(BodyDescriptor bd) {
     }
+    
+    /**
+     * @see org.mime4j.ContentHandler#body(org.mime4j.BodyDescriptor, java.io.InputStream)
+     */
     public void body(BodyDescriptor bd, InputStream is) throws IOException {
     }
+    
+    /**
+     * @see org.mime4j.ContentHandler#endBodyPart()
+     */
     public void endBodyPart() {
     }
+    
+    /**
+     * @see org.mime4j.ContentHandler#endHeader()
+     */
     public void endHeader() {
     }
+    
+    /**
+     * @see org.mime4j.ContentHandler#endMessage()
+     */
     public void endMessage() {
     }
+    
+    /**
+     * @see org.mime4j.ContentHandler#epilogue(java.io.InputStream)
+     */
     public void epilogue(InputStream is) throws IOException {
     }
+    
+    /**
+     * @see org.mime4j.ContentHandler#field(java.lang.String)
+     */
     public void field(String fieldData) {
     }
+    
+    /**
+     * @see org.mime4j.ContentHandler#preamble(java.io.InputStream)
+     */
     public void preamble(InputStream is) throws IOException {
     }
+    
+    /**
+     * @see org.mime4j.ContentHandler#startBodyPart()
+     */
     public void startBodyPart() {
     }
+    
+    /**
+     * @see org.mime4j.ContentHandler#startHeader()
+     */
     public void startHeader() {
     }
+    
+    /**
+     * @see org.mime4j.ContentHandler#startMessage()
+     */
     public void startMessage() {
     }
+    
+    /**
+     * @see org.mime4j.ContentHandler#raw(java.io.InputStream)
+     */
     public void raw(InputStream is) throws IOException {
     }
 }

Modified: james/mime4j/trunk/src/main/java/org/mime4j/BodyDescriptor.java
URL: http://svn.apache.org/viewvc/james/mime4j/trunk/src/main/java/org/mime4j/BodyDescriptor.java?view=diff&rev=510480&r1=510479&r2=510480
==============================================================================
--- james/mime4j/trunk/src/main/java/org/mime4j/BodyDescriptor.java (original)
+++ james/mime4j/trunk/src/main/java/org/mime4j/BodyDescriptor.java Thu Feb 22 04:32:48 2007
@@ -319,42 +319,92 @@
         return result;
     }
     
+    /**
+     * Ret
+     * @param mimeType
+     * @return
+     */
     public boolean isMimeType(String mimeType) {
         return this.mimeType.equals(mimeType.toLowerCase());
     }
     
+    /**
+     * Return true if the BodyDescriptor belongs to a message 
+     * 
+     * @return
+     */
     public boolean isMessage() {
         return mimeType.equals("message/rfc822");
     }
     
+    /**
+     * Retrun true if the BodyDescripotro belogns to a multipart
+     * 
+     * @return
+     */
     public boolean isMultipart() {
         return mimeType.startsWith("multipart/");
     }
     
+    /**
+     * Return the MimeType 
+     * 
+     * @return mimeType
+     */
     public String getMimeType() {
         return mimeType;
     }
     
+    /**
+     * Return the boundary
+     * 
+     * @return boundary
+     */
     public String getBoundary() {
         return boundary;
     }
     
+    /**
+     * Return the charset
+     * 
+     * @return charset
+     */
     public String getCharset() {
         return charset;
     }
     
+    /**
+     * Return all parameters for the BodyDescriptor
+     * 
+     * @return parameters
+     */
     public Map getParameters() {
         return parameters;
     }
     
+    /**
+     * Return the TransferEncoding
+     * 
+     * @return transferEncoding
+     */
     public String getTransferEncoding() {
         return transferEncoding;
     }
     
+    /**
+     * Return true if it's base64 encoded
+     * 
+     * @return
+     * 
+     */
     public boolean isBase64Encoded() {
         return "base64".equals(transferEncoding);
     }
     
+    /**
+     * Return true if it's quoted-printable
+     * @return
+     */
     public boolean isQuotedPrintableEncoded() {
         return "quoted-printable".equals(transferEncoding);
     }

Modified: james/mime4j/trunk/src/main/java/org/mime4j/SimpleContentHandler.java
URL: http://svn.apache.org/viewvc/james/mime4j/trunk/src/main/java/org/mime4j/SimpleContentHandler.java?view=diff&rev=510480&r1=510479&r2=510480
==============================================================================
--- james/mime4j/trunk/src/main/java/org/mime4j/SimpleContentHandler.java (original)
+++ james/mime4j/trunk/src/main/java/org/mime4j/SimpleContentHandler.java Thu Feb 22 04:32:48 2007
@@ -34,7 +34,7 @@
  *
  * 
  */
-public abstract class SimpleContentHandler implements ContentHandler {
+public abstract class SimpleContentHandler extends  AbstractContentHandler {
 
     /**
      * Called after headers are parsed.
@@ -54,63 +54,6 @@
      * @throws IOException should be thrown on I/O errors.
      */
     public abstract void bodyDecoded(BodyDescriptor bd, InputStream is) throws IOException;
-
-    /* Subclassers: override these as necessary. */
-
-    /**
-     * @see ContentHandler#startMessage()
-     */
-    public void startMessage() {
-    }
-
-    /**
-     * @see ContentHandler#endMessage()
-     */
-    public void endMessage() {
-    }
-
-    /**
-     * @see ContentHandler#startBodyPart()
-     */
-    public void startBodyPart() {
-    }
-
-    /**
-     * @see ContentHandler#endBodyPart()
-     */
-    public void endBodyPart() {
-    }
-
-    /**
-     * @see ContentHandler#preamble(java.io.InputStream)
-     */
-    public void preamble(InputStream is) throws IOException {
-    }
-
-    /**
-     * @see ContentHandler#epilogue(java.io.InputStream)
-     */
-    public void epilogue(InputStream is) throws IOException {
-    }
-
-    /**
-     * @see ContentHandler#startMultipart(BodyDescriptor)
-     */
-    public void startMultipart(BodyDescriptor bd) {
-    }
-
-    /**
-     * @see ContentHandler#endMultipart()
-     */
-    public void endMultipart() {
-    }
-
-    /**
-     * @see ContentHandler#raw(java.io.InputStream)  
-     */
-    public void raw(InputStream is) throws IOException {
-    }
-
 
 
     /* Implement introduced callbacks. */

Modified: james/mime4j/trunk/src/main/java/org/mime4j/message/Header.java
URL: http://svn.apache.org/viewvc/james/mime4j/trunk/src/main/java/org/mime4j/message/Header.java?view=diff&rev=510480&r1=510479&r2=510480
==============================================================================
--- james/mime4j/trunk/src/main/java/org/mime4j/message/Header.java (original)
+++ james/mime4j/trunk/src/main/java/org/mime4j/message/Header.java Thu Feb 22 04:32:48 2007
@@ -129,6 +129,7 @@
             str.append(it.next().toString());
             str.append("\r\n");
         }
+        str.append("\r\n");
         return str.toString();
     }
 



---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org