You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "xiangfu0 (via GitHub)" <gi...@apache.org> on 2026/04/18 08:45:47 UTC
[PR] Fix flaky testRealtimeTableProcessAllModeMultiLevelConcat [pinot]
xiangfu0 opened a new pull request, #18253:
URL: https://github.com/apache/pinot/pull/18253
## Summary
- Fixes flaky `MergeRollupMinionClusterIntegrationTest.testRealtimeTableProcessAllModeMultiLevelConcat`, which occasionally fails at `assertTrue(MetricValueUtils.gaugeExists(...))` for `mergeRollupTaskNumBucketsToProcess.myTable6_REALTIME.100days`.
- Root cause: the `mergeRollupTaskNumBucketsToProcess.*` gauges are (re)registered and updated only when `PinotTaskManager.scheduleTasks` runs for a merge level with no in-flight task. The per-iteration check in the test races with (a) the in-flight task's Helix `COMPLETED` transition and (b) the segment-lineage commit that follows — producing either a stale value or, more rarely, a missed gauge registration.
- Fix: extract the gauge check into `waitForExpectedNumBucketsToProcess`, which polls via `TestUtils.waitForCondition` until both gauges exist and their values match the expected tuple. This absorbs the short race window and replaces the duplicated inline assertions in both for-loops.
## Test plan
- [x] `./mvnw test-compile -pl pinot-integration-tests` passes.
- [x] `./mvnw spotless:apply checkstyle:check license:format license:check -pl pinot-integration-tests` clean.
- [ ] CI runs `MergeRollupMinionClusterIntegrationTest.testRealtimeTableProcessAllModeMultiLevelConcat` successfully across multiple runs.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Fix flaky testRealtimeTableProcessAllModeMultiLevelConcat [pinot]
Posted by "xiangfu0 (via GitHub)" <gi...@apache.org>.
xiangfu0 merged PR #18253:
URL: https://github.com/apache/pinot/pull/18253
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Fix flaky testRealtimeTableProcessAllModeMultiLevelConcat [pinot]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18253:
URL: https://github.com/apache/pinot/pull/18253#issuecomment-4273359551
## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/18253?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 55.41%. Comparing base ([`ade9f6c`](https://app.codecov.io/gh/apache/pinot/commit/ade9f6c3dc679707f99109844f425778f4f47724?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`6c191cc`](https://app.codecov.io/gh/apache/pinot/commit/6c191cc7bd6492f664bea760df4c9bf3d5d429ec?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
> :exclamation: There is a different number of reports uploaded between BASE (ade9f6c) and HEAD (6c191cc). Click for more details.
>
> <details><summary>HEAD has 20 uploads less than BASE</summary>
>
>| Flag | BASE (ade9f6c) | HEAD (6c191cc) |
>|------|------|------|
>|java-21|4|1|
>|unittests1|2|1|
>|unittests|4|1|
>|temurin|6|1|
>|java-11|2|0|
>|unittests2|2|0|
>|integration|2|0|
>|integration1|1|0|
>|integration2|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18253 +/- ##
============================================
- Coverage 63.48% 55.41% -8.08%
+ Complexity 1627 837 -790
============================================
Files 3244 2549 -695
Lines 197342 146173 -51169
Branches 30529 23506 -7023
============================================
- Hits 125285 81001 -44284
+ Misses 62014 58177 -3837
+ Partials 10043 6995 -3048
```
| [Flag](https://app.codecov.io/gh/apache/pinot/pull/18253/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [integration](https://app.codecov.io/gh/apache/pinot/pull/18253/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration1](https://app.codecov.io/gh/apache/pinot/pull/18253/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration2](https://app.codecov.io/gh/apache/pinot/pull/18253/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [java-11](https://app.codecov.io/gh/apache/pinot/pull/18253/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [java-21](https://app.codecov.io/gh/apache/pinot/pull/18253/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `55.41% <ø> (-8.03%)` | :arrow_down: |
| [temurin](https://app.codecov.io/gh/apache/pinot/pull/18253/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `55.41% <ø> (-8.08%)` | :arrow_down: |
| [unittests](https://app.codecov.io/gh/apache/pinot/pull/18253/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `55.41% <ø> (-8.07%)` | :arrow_down: |
| [unittests1](https://app.codecov.io/gh/apache/pinot/pull/18253/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `55.41% <ø> (-0.05%)` | :arrow_down: |
| [unittests2](https://app.codecov.io/gh/apache/pinot/pull/18253/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/pinot/pull/18253?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org