[jira] [Updated] (OAK-5121) review CommitInfo==null in BackgroundObserver with isExternal change

["Stefan Egli (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/OAK-5121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stefan Egli updated OAK-5121:
-----------------------------
    Attachment: OAK-5121.patch

Attaching [^OAK-5121.patch] with an illustration of what I had in mind. Basically to have a new flag {{isCompacted}} on the CommitInfo and thus a new {{CommitInfo.EMPTY_COMPACTED}}. At the moment the code would be identical as {{isExternal()}} is replaced with {{isExternal() || isCompacted}}. But we could distinguish these two cases more fine-grained going further, eg also in the stats.

> review CommitInfo==null in BackgroundObserver with isExternal change
> --------------------------------------------------------------------
>
>                 Key: OAK-5121
>                 URL: https://issues.apache.org/jira/browse/OAK-5121
>             Project: Jackrabbit Oak
>          Issue Type: Task
>          Components: core
>    Affects Versions: 1.5.13
>            Reporter: Stefan Egli
>            Assignee: Stefan Egli
>             Fix For: 1.6
>
>         Attachments: OAK-5121.patch
>
>
> OAK-4898 changes CommitInfo to be never null. This is the case outside of the BackgroundObserver - but in the BackgroundObserver itself it is explicitly set to null when compacting. 
> Once OAK-4898 is committed this task is about reviewing the implications in BackgroundObserver wrt compaction and CommitInfo==null



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)