[GitHub] [cassandra] bereng commented on a change in pull request #1348: Cassandra 17171 trunk

[GitBox <gi...@apache.org>]

bereng commented on a change in pull request #1348:
URL: https://github.com/apache/cassandra/pull/1348#discussion_r760044869



##########
File path: test/unit/org/apache/cassandra/db/compaction/CompactionsBytemanTest.java
##########
@@ -127,9 +128,10 @@ public void testCompactingCFCounting() throws Throwable
         cfs.enableAutoCompaction();
 
         execute("INSERT INTO %s (k, c, v) VALUES (?, ?, ?)", 0, 1, 1);
-        assertEquals(0, CompactionManager.instance.compactingCF.count(cfs));
+        Util.spinAssertEquals(true, () -> {return CompactionManager.instance.compactingCF.count(cfs) == 0;}, 1);

Review comment:
       Given in 17169 we've had timeouts on 1s tasks maybe I should do 10s here. Serves the same purpose and will avoid false flaky positives.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org