[jira] [Commented] (HIVE-13966) DbNotificationListener: can loose DDL operation notifications

["Sushanth Sowmyan (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-13966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15402519#comment-15402519 ] 

Sushanth Sowmyan commented on HIVE-13966:
-----------------------------------------

Sorry for the late response, I've been tied on a bunch of other issues off late. I will look at this and review in the next couple of days. This is an issue that is important to fix, and I'm glad you have a patch up for it. :)

> DbNotificationListener: can loose DDL operation notifications
> -------------------------------------------------------------
>
>                 Key: HIVE-13966
>                 URL: https://issues.apache.org/jira/browse/HIVE-13966
>             Project: Hive
>          Issue Type: Bug
>          Components: HCatalog
>            Reporter: Nachiket Vaidya
>            Assignee: Rahul Sharma
>            Priority: Critical
>         Attachments: HIVE-13966.1.patch, HIVE-13966.2.patch
>
>
> The code for each API in HiveMetaStore.java is like this:
> 1. openTransaction()
> 2. -- operation--
> 3. commit() or rollback() based on result of the operation.
> 4. add entry to notification log (unconditionally)
> If the operation is failed (in step 2), we still add entry to notification log. Found this issue in testing.
> It is still ok as this is the case of false positive.
> If the operation is successful and adding to notification log failed, the user will get an MetaException. It will not rollback the operation, as it is already committed. We need to handle this case so that we will not have false negatives.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)