You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/06/26 21:12:39 UTC
[GitHub] [incubator-superset] bkyryliuk opened a new pull request #10177: [WIP] Switch from nosetest to pytest
bkyryliuk opened a new pull request #10177:
URL: https://github.com/apache/incubator-superset/pull/10177
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] bkyryliuk commented on pull request #10177: feat: Switch from nosetest to pytest
Posted by GitBox <gi...@apache.org>.
bkyryliuk commented on pull request #10177:
URL: https://github.com/apache/incubator-superset/pull/10177#issuecomment-650450453
> 1. Code coverage is missing
> <img alt="" width="300" src="https://user-images.githubusercontent.com/335541/85908543-5b399a80-b7ca-11ea-9e57-b90ec0206069.png">
> 2. Might want to remove `nosetests` from pip dependencies and clean [this](https://github.com/apache/incubator-superset/blob/master/setup.cfg#L36-L41) up as well.
@ktmud good catch. Will do the 1. As for point 2 - I changed nosetests there to the tool:pytest
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on pull request #10177: feat: Switch from nosetest to pytest
Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #10177:
URL: https://github.com/apache/incubator-superset/pull/10177#issuecomment-650451164
Ah, sorry for missing that. Are those nosetests options in `setup.cfg` also valid for pytest as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter commented on pull request #10177: feat: Switch from nosetest to pytest
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #10177:
URL: https://github.com/apache/incubator-superset/pull/10177#issuecomment-650469503
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10177?src=pr&el=h1) Report
> Merging [#10177](https://codecov.io/gh/apache/incubator-superset/pull/10177?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f888656e6de671069d7d04d511a215cc90327bd4&el=desc) will **decrease** coverage by `17.76%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10177?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10177 +/- ##
===========================================
- Coverage 70.55% 52.79% -17.77%
===========================================
Files 594 593 -1
Lines 31470 31434 -36
Branches 3228 3228
===========================================
- Hits 22204 16595 -5609
- Misses 9150 14723 +5573
Partials 116 116
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.57% <ø> (+0.07%)` | :arrow_up: |
| #javascript | `59.61% <ø> (ø)` | |
| #python | `39.88% <ø> (-30.49%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10177?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/utils/import\_datasource.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvaW1wb3J0X2RhdGFzb3VyY2UucHk=) | `16.66% <0.00%> (-83.34%)` | :arrow_down: |
| [superset/tasks/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvY2FjaGUucHk=) | `0.00% <0.00%> (-73.92%)` | :arrow_down: |
| [superset/sql\_parse.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | `29.65% <0.00%> (-69.66%)` | :arrow_down: |
| [superset/dashboards/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9kYW8ucHk=) | `23.30% <0.00%> (-68.19%)` | :arrow_down: |
| [superset/datasets/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvY3JlYXRlLnB5) | `31.48% <0.00%> (-66.67%)` | :arrow_down: |
| [superset/datasets/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvdXBkYXRlLnB5) | `27.38% <0.00%> (-66.67%)` | :arrow_down: |
| [superset/utils/pandas\_postprocessing.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvcGFuZGFzX3Bvc3Rwcm9jZXNzaW5nLnB5) | `25.54% <0.00%> (-62.78%)` | :arrow_down: |
| [superset/commands/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvdXRpbHMucHk=) | `37.50% <0.00%> (-62.50%)` | :arrow_down: |
| [superset/views/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdXRpbHMucHk=) | `23.07% <0.00%> (-60.58%)` | :arrow_down: |
| [superset/dao/base.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFvL2Jhc2UucHk=) | `36.36% <0.00%> (-60.01%)` | :arrow_down: |
| ... and [111 more](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10177?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10177?src=pr&el=footer). Last update [f888656...2a41041](https://codecov.io/gh/apache/incubator-superset/pull/10177?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10177: feat: Switch from nosetest to pytest
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10177:
URL: https://github.com/apache/incubator-superset/pull/10177#issuecomment-650469503
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10177?src=pr&el=h1) Report
> Merging [#10177](https://codecov.io/gh/apache/incubator-superset/pull/10177?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f888656e6de671069d7d04d511a215cc90327bd4&el=desc) will **decrease** coverage by `17.76%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10177?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10177 +/- ##
===========================================
- Coverage 70.55% 52.79% -17.77%
===========================================
Files 594 593 -1
Lines 31470 31434 -36
Branches 3228 3228
===========================================
- Hits 22204 16595 -5609
- Misses 9150 14723 +5573
Partials 116 116
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.57% <ø> (+0.07%)` | :arrow_up: |
| #javascript | `59.61% <ø> (ø)` | |
| #python | `39.88% <ø> (-30.49%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10177?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/utils/import\_datasource.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvaW1wb3J0X2RhdGFzb3VyY2UucHk=) | `16.66% <0.00%> (-83.34%)` | :arrow_down: |
| [superset/tasks/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvY2FjaGUucHk=) | `0.00% <0.00%> (-73.92%)` | :arrow_down: |
| [superset/sql\_parse.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | `29.65% <0.00%> (-69.66%)` | :arrow_down: |
| [superset/dashboards/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9kYW8ucHk=) | `23.30% <0.00%> (-68.19%)` | :arrow_down: |
| [superset/datasets/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvY3JlYXRlLnB5) | `31.48% <0.00%> (-66.67%)` | :arrow_down: |
| [superset/datasets/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvdXBkYXRlLnB5) | `27.38% <0.00%> (-66.67%)` | :arrow_down: |
| [superset/utils/pandas\_postprocessing.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvcGFuZGFzX3Bvc3Rwcm9jZXNzaW5nLnB5) | `25.54% <0.00%> (-62.78%)` | :arrow_down: |
| [superset/commands/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvdXRpbHMucHk=) | `37.50% <0.00%> (-62.50%)` | :arrow_down: |
| [superset/views/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdXRpbHMucHk=) | `23.07% <0.00%> (-60.58%)` | :arrow_down: |
| [superset/dao/base.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFvL2Jhc2UucHk=) | `36.36% <0.00%> (-60.01%)` | :arrow_down: |
| ... and [111 more](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10177?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10177?src=pr&el=footer). Last update [f888656...2a41041](https://codecov.io/gh/apache/incubator-superset/pull/10177?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10177: feat: Switch from nosetest to pytest
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10177:
URL: https://github.com/apache/incubator-superset/pull/10177#issuecomment-650408254
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10177?src=pr&el=h1) Report
> Merging [#10177](https://codecov.io/gh/apache/incubator-superset/pull/10177?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f888656e6de671069d7d04d511a215cc90327bd4&el=desc) will **decrease** coverage by `17.79%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10177?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10177 +/- ##
===========================================
- Coverage 70.55% 52.75% -17.80%
===========================================
Files 594 593 -1
Lines 31470 31416 -54
Branches 3228 3228
===========================================
- Hits 22204 16575 -5629
- Misses 9150 14725 +5575
Partials 116 116
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.49% <ø> (ø)` | |
| #javascript | `59.60% <ø> (-0.01%)` | :arrow_down: |
| #python | `39.84% <ø> (-30.53%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10177?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/utils/import\_datasource.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvaW1wb3J0X2RhdGFzb3VyY2UucHk=) | `16.66% <0.00%> (-83.34%)` | :arrow_down: |
| [superset/tasks/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvY2FjaGUucHk=) | `0.00% <0.00%> (-73.92%)` | :arrow_down: |
| [superset/sql\_parse.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | `29.65% <0.00%> (-69.66%)` | :arrow_down: |
| [superset/dashboards/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9kYW8ucHk=) | `23.30% <0.00%> (-68.19%)` | :arrow_down: |
| [superset/datasets/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvY3JlYXRlLnB5) | `31.48% <0.00%> (-66.67%)` | :arrow_down: |
| [superset/datasets/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvdXBkYXRlLnB5) | `27.38% <0.00%> (-66.67%)` | :arrow_down: |
| [superset/utils/pandas\_postprocessing.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvcGFuZGFzX3Bvc3Rwcm9jZXNzaW5nLnB5) | `25.54% <0.00%> (-62.78%)` | :arrow_down: |
| [superset/commands/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvdXRpbHMucHk=) | `37.50% <0.00%> (-62.50%)` | :arrow_down: |
| [superset/views/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdXRpbHMucHk=) | `23.07% <0.00%> (-60.58%)` | :arrow_down: |
| [superset/dao/base.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFvL2Jhc2UucHk=) | `36.36% <0.00%> (-60.01%)` | :arrow_down: |
| ... and [109 more](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10177?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10177?src=pr&el=footer). Last update [f888656...93b4012](https://codecov.io/gh/apache/incubator-superset/pull/10177?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10177: feat: Switch from nosetest to pytest
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10177:
URL: https://github.com/apache/incubator-superset/pull/10177#issuecomment-650480851
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10177?src=pr&el=h1) Report
> Merging [#10177](https://codecov.io/gh/apache/incubator-superset/pull/10177?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f888656e6de671069d7d04d511a215cc90327bd4&el=desc) will **decrease** coverage by `30.33%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10177?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10177 +/- ##
===========================================
- Coverage 70.55% 40.21% -30.34%
===========================================
Files 594 189 -405
Lines 31470 18302 -13168
Branches 3228 0 -3228
===========================================
- Hits 22204 7361 -14843
- Misses 9150 10941 +1791
+ Partials 116 0 -116
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `40.21% <ø> (-30.16%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10177?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/utils/import\_datasource.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvaW1wb3J0X2RhdGFzb3VyY2UucHk=) | `16.66% <0.00%> (-83.34%)` | :arrow_down: |
| [superset/tasks/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvY2FjaGUucHk=) | `0.00% <0.00%> (-73.92%)` | :arrow_down: |
| [superset/sql\_parse.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | `29.16% <0.00%> (-70.15%)` | :arrow_down: |
| [superset/dashboards/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9kYW8ucHk=) | `23.30% <0.00%> (-68.19%)` | :arrow_down: |
| [superset/datasets/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvY3JlYXRlLnB5) | `31.48% <0.00%> (-66.67%)` | :arrow_down: |
| [superset/datasets/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvdXBkYXRlLnB5) | `27.38% <0.00%> (-66.67%)` | :arrow_down: |
| [superset/utils/pandas\_postprocessing.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvcGFuZGFzX3Bvc3Rwcm9jZXNzaW5nLnB5) | `25.54% <0.00%> (-62.78%)` | :arrow_down: |
| [superset/commands/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvdXRpbHMucHk=) | `37.50% <0.00%> (-62.50%)` | :arrow_down: |
| [superset/views/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdXRpbHMucHk=) | `23.07% <0.00%> (-60.58%)` | :arrow_down: |
| [superset/dao/base.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFvL2Jhc2UucHk=) | `36.36% <0.00%> (-60.01%)` | :arrow_down: |
| ... and [509 more](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10177?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10177?src=pr&el=footer). Last update [f888656...d0f950a](https://codecov.io/gh/apache/incubator-superset/pull/10177?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter removed a comment on pull request #10177: feat: Switch from nosetest to pytest
Posted by GitBox <gi...@apache.org>.
codecov-commenter removed a comment on pull request #10177:
URL: https://github.com/apache/incubator-superset/pull/10177#issuecomment-650469503
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10177?src=pr&el=h1) Report
> Merging [#10177](https://codecov.io/gh/apache/incubator-superset/pull/10177?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f888656e6de671069d7d04d511a215cc90327bd4&el=desc) will **decrease** coverage by `17.76%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10177?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10177 +/- ##
===========================================
- Coverage 70.55% 52.79% -17.77%
===========================================
Files 594 593 -1
Lines 31470 31434 -36
Branches 3228 3228
===========================================
- Hits 22204 16595 -5609
- Misses 9150 14723 +5573
Partials 116 116
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.57% <ø> (+0.07%)` | :arrow_up: |
| #javascript | `59.61% <ø> (ø)` | |
| #python | `39.88% <ø> (-30.49%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10177?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/utils/import\_datasource.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvaW1wb3J0X2RhdGFzb3VyY2UucHk=) | `16.66% <0.00%> (-83.34%)` | :arrow_down: |
| [superset/tasks/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvY2FjaGUucHk=) | `0.00% <0.00%> (-73.92%)` | :arrow_down: |
| [superset/sql\_parse.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | `29.65% <0.00%> (-69.66%)` | :arrow_down: |
| [superset/dashboards/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9kYW8ucHk=) | `23.30% <0.00%> (-68.19%)` | :arrow_down: |
| [superset/datasets/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvY3JlYXRlLnB5) | `31.48% <0.00%> (-66.67%)` | :arrow_down: |
| [superset/datasets/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvdXBkYXRlLnB5) | `27.38% <0.00%> (-66.67%)` | :arrow_down: |
| [superset/utils/pandas\_postprocessing.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvcGFuZGFzX3Bvc3Rwcm9jZXNzaW5nLnB5) | `25.54% <0.00%> (-62.78%)` | :arrow_down: |
| [superset/commands/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvdXRpbHMucHk=) | `37.50% <0.00%> (-62.50%)` | :arrow_down: |
| [superset/views/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdXRpbHMucHk=) | `23.07% <0.00%> (-60.58%)` | :arrow_down: |
| [superset/dao/base.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFvL2Jhc2UucHk=) | `36.36% <0.00%> (-60.01%)` | :arrow_down: |
| ... and [111 more](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10177?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10177?src=pr&el=footer). Last update [f888656...2a41041](https://codecov.io/gh/apache/incubator-superset/pull/10177?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] bkyryliuk commented on pull request #10177: feat: Switch from nosetest to pytest
Posted by GitBox <gi...@apache.org>.
bkyryliuk commented on pull request #10177:
URL: https://github.com/apache/incubator-superset/pull/10177#issuecomment-651278422
> Codecov seems to be stuck at "[waiting for CI to complete](https://codecov.io/gh/apache/incubator-superset/commit/6a695f9f62b25b601afdea50403c4717b2b56f6e)", just like in #10142 . If you can get it fixed, that'd be great. If not, we can probably just merge this as is and see if it's a recurring issue in the next PR.
>
> There were also some deprecation warnings in the logs that might worth fixing (could be in another PR):
>
> ```
> tests/security_tests.py::TestRolePermission::test_set_perm_slice
> /home/runner/work/incubator-superset/incubator-superset/tests/security_tests.py:425: DeprecationWarning: Please use assertEqual instead.
> self.assertEquals(slice.schema_perm, table.schema_perm)
> ```
@ktmud this is interesting, report is generated on their side: https://codecov.io/gh/apache/incubator-superset/pull/10177
however was not send to update the PR, will amend the PR and see if it fixes it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] bkyryliuk commented on a change in pull request #10177: feat: Switch from nosetest to pytest
Posted by GitBox <gi...@apache.org>.
bkyryliuk commented on a change in pull request #10177:
URL: https://github.com/apache/incubator-superset/pull/10177#discussion_r446462101
##########
File path: scripts/python_tests.sh
##########
@@ -23,5 +23,5 @@ echo "Superset config module: $SUPERSET_CONFIG"
superset db upgrade
superset init
-nosetests --stop tests/load_examples_test.py
-nosetests --stop --exclude=load_examples_test tests
+pytest --maxfail=1 tests/load_examples_test.py
Review comment:
my preference is not to count it, to me this is more a fixture setup rather than an actual test.
However do not have a preference here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] bkyryliuk commented on a change in pull request #10177: feat: Switch from nosetest to pytest
Posted by GitBox <gi...@apache.org>.
bkyryliuk commented on a change in pull request #10177:
URL: https://github.com/apache/incubator-superset/pull/10177#discussion_r446462847
##########
File path: scripts/python_tests.sh
##########
@@ -23,5 +23,5 @@ echo "Superset config module: $SUPERSET_CONFIG"
superset db upgrade
superset init
-nosetests --stop tests/load_examples_test.py
-nosetests --stop --exclude=load_examples_test tests
+pytest --maxfail=1 tests/load_examples_test.py
Review comment:
https://codecov.io/gh/apache/incubator-superset/pull/10177/commits - looks like it was the reason for dropped coverage - will keep playing with it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on pull request #10177: feat: Switch from nosetest to pytest
Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #10177:
URL: https://github.com/apache/incubator-superset/pull/10177#issuecomment-650671509
Codecov seems to be stuck at "[waiting for CI to complete](https://codecov.io/gh/apache/incubator-superset/commit/6a695f9f62b25b601afdea50403c4717b2b56f6e)", just like in #10142 . If you can get it fixed, that'd be great. If not, we can probably just merge this as is and see if it's a recurring issue in the next PR.
There were also some deprecation warnings in the logs that might worth fixing (could be in another PR):
```
tests/security_tests.py::TestRolePermission::test_set_perm_slice
/home/runner/work/incubator-superset/incubator-superset/tests/security_tests.py:425: DeprecationWarning: Please use assertEqual instead.
self.assertEquals(slice.schema_perm, table.schema_perm)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] bkyryliuk commented on pull request #10177: feat: Switch from nosetest to pytest
Posted by GitBox <gi...@apache.org>.
bkyryliuk commented on pull request #10177:
URL: https://github.com/apache/incubator-superset/pull/10177#issuecomment-650464110
> Code LGTM! Do you know why did Codecov say overall coverage dropped by 17.79%?
old run, will try to see how can I trigger it again
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] bkyryliuk commented on pull request #10177: feat: Switch from nosetest to pytest
Posted by GitBox <gi...@apache.org>.
bkyryliuk commented on pull request #10177:
URL: https://github.com/apache/incubator-superset/pull/10177#issuecomment-650460519
> Ah, sorry for missing that. Are those nosetests options in `setup.cfg` also valid for pytest as well?
@ktmud taking into account that we want to modify the local tests vs CI behavior that section is probably not needed.
Can you take another look at the PR?
I've modified it to run test coverage only in the python_tests.sh
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10177: feat: Switch from nosetest to pytest
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10177:
URL: https://github.com/apache/incubator-superset/pull/10177#issuecomment-650480851
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10177?src=pr&el=h1) Report
> Merging [#10177](https://codecov.io/gh/apache/incubator-superset/pull/10177?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f888656e6de671069d7d04d511a215cc90327bd4&el=desc) will **decrease** coverage by `17.57%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10177?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10177 +/- ##
===========================================
- Coverage 70.55% 52.98% -17.58%
===========================================
Files 594 593 -1
Lines 31470 31416 -54
Branches 3228 3228
===========================================
- Hits 22204 16646 -5558
- Misses 9150 14654 +5504
Partials 116 116
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.49% <ø> (ø)` | |
| #javascript | `59.61% <ø> (ø)` | |
| #python | `40.22% <ø> (-30.15%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10177?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/utils/import\_datasource.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvaW1wb3J0X2RhdGFzb3VyY2UucHk=) | `16.66% <0.00%> (-83.34%)` | :arrow_down: |
| [superset/tasks/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvY2FjaGUucHk=) | `0.00% <0.00%> (-73.92%)` | :arrow_down: |
| [superset/sql\_parse.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | `29.65% <0.00%> (-69.66%)` | :arrow_down: |
| [superset/dashboards/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9kYW8ucHk=) | `23.30% <0.00%> (-68.19%)` | :arrow_down: |
| [superset/datasets/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvY3JlYXRlLnB5) | `31.48% <0.00%> (-66.67%)` | :arrow_down: |
| [superset/datasets/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvdXBkYXRlLnB5) | `27.38% <0.00%> (-66.67%)` | :arrow_down: |
| [superset/utils/pandas\_postprocessing.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvcGFuZGFzX3Bvc3Rwcm9jZXNzaW5nLnB5) | `25.54% <0.00%> (-62.78%)` | :arrow_down: |
| [superset/commands/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvdXRpbHMucHk=) | `37.50% <0.00%> (-62.50%)` | :arrow_down: |
| [superset/views/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdXRpbHMucHk=) | `23.07% <0.00%> (-60.58%)` | :arrow_down: |
| [superset/dao/base.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFvL2Jhc2UucHk=) | `36.36% <0.00%> (-60.01%)` | :arrow_down: |
| ... and [103 more](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10177?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10177?src=pr&el=footer). Last update [f888656...7c5dbab](https://codecov.io/gh/apache/incubator-superset/pull/10177?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10177: feat: Switch from nosetest to pytest
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10177:
URL: https://github.com/apache/incubator-superset/pull/10177#issuecomment-650480851
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10177?src=pr&el=h1) Report
> Merging [#10177](https://codecov.io/gh/apache/incubator-superset/pull/10177?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/3414f357922e19c57669f6ca7b711757594a6bb8&el=desc) will **decrease** coverage by `17.87%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10177?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10177 +/- ##
===========================================
- Coverage 70.56% 52.68% -17.88%
===========================================
Files 594 593 -1
Lines 31474 31416 -58
Branches 3228 3228
===========================================
- Hits 22209 16551 -5658
- Misses 9149 14748 +5599
- Partials 116 117 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.07% <ø> (-0.42%)` | :arrow_down: |
| #javascript | `59.61% <ø> (ø)` | |
| #python | `39.84% <ø> (-30.54%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10177?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/utils/import\_datasource.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvaW1wb3J0X2RhdGFzb3VyY2UucHk=) | `16.66% <0.00%> (-83.34%)` | :arrow_down: |
| [superset/tasks/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvY2FjaGUucHk=) | `0.00% <0.00%> (-73.92%)` | :arrow_down: |
| [superset/sql\_parse.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | `29.65% <0.00%> (-69.66%)` | :arrow_down: |
| [superset/dashboards/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9kYW8ucHk=) | `23.30% <0.00%> (-68.94%)` | :arrow_down: |
| [superset/datasets/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvY3JlYXRlLnB5) | `31.48% <0.00%> (-66.67%)` | :arrow_down: |
| [superset/datasets/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvdXBkYXRlLnB5) | `27.38% <0.00%> (-66.67%)` | :arrow_down: |
| [superset/utils/pandas\_postprocessing.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvcGFuZGFzX3Bvc3Rwcm9jZXNzaW5nLnB5) | `25.54% <0.00%> (-62.78%)` | :arrow_down: |
| [superset/commands/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvdXRpbHMucHk=) | `37.50% <0.00%> (-62.50%)` | :arrow_down: |
| [superset/views/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdXRpbHMucHk=) | `23.07% <0.00%> (-60.58%)` | :arrow_down: |
| [superset/dao/base.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFvL2Jhc2UucHk=) | `36.36% <0.00%> (-60.01%)` | :arrow_down: |
| ... and [117 more](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10177?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10177?src=pr&el=footer). Last update [3414f35...2f73887](https://codecov.io/gh/apache/incubator-superset/pull/10177?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on a change in pull request #10177: feat: Switch from nosetest to pytest
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #10177:
URL: https://github.com/apache/incubator-superset/pull/10177#discussion_r446460553
##########
File path: scripts/python_tests.sh
##########
@@ -23,5 +23,5 @@ echo "Superset config module: $SUPERSET_CONFIG"
superset db upgrade
superset init
-nosetests --stop tests/load_examples_test.py
-nosetests --stop --exclude=load_examples_test tests
+pytest --maxfail=1 tests/load_examples_test.py
Review comment:
Do we want coverage for this file as well? I don't think it's needed but it was covered in previous setup.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] bkyryliuk merged pull request #10177: feat: Switch from nosetest to pytest
Posted by GitBox <gi...@apache.org>.
bkyryliuk merged pull request #10177:
URL: https://github.com/apache/incubator-superset/pull/10177
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter commented on pull request #10177: feat: Switch from nosetest to pytest
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #10177:
URL: https://github.com/apache/incubator-superset/pull/10177#issuecomment-651323219
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10177?src=pr&el=h1) Report
> Merging [#10177](https://codecov.io/gh/apache/incubator-superset/pull/10177?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/4342c33d0ebb2bbce1969a4072ce13a1b0af283c&el=desc) will **decrease** coverage by `0.14%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10177?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10177 +/- ##
==========================================
- Coverage 65.84% 65.69% -0.15%
==========================================
Files 594 594
Lines 31486 31492 +6
Branches 3222 3223 +1
==========================================
- Hits 20732 20689 -43
- Misses 10574 10623 +49
Partials 180 180
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `59.42% <ø> (+<0.01%)` | :arrow_up: |
| #python | `70.16% <ø> (-0.26%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10177?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `77.77% <0.00%> (-22.23%)` | :arrow_down: |
| [superset/examples/unicode\_test\_data.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvdW5pY29kZV90ZXN0X2RhdGEucHk=) | `81.63% <0.00%> (-18.37%)` | :arrow_down: |
| [superset/examples/energy.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvZW5lcmd5LnB5) | `84.61% <0.00%> (-15.39%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `84.61% <0.00%> (-15.39%)` | :arrow_down: |
| [superset/examples/helpers.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvaGVscGVycy5weQ==) | `85.00% <0.00%> (-12.50%)` | :arrow_down: |
| [superset/examples/css\_templates.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvY3NzX3RlbXBsYXRlcy5weQ==) | `89.47% <0.00%> (-10.53%)` | :arrow_down: |
| [superset/dashboards/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9kYW8ucHk=) | `91.26% <0.00%> (-0.98%)` | :arrow_down: |
| [superset/cli.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2xpLnB5) | `39.72% <0.00%> (-0.35%)` | :arrow_down: |
| [...erset-frontend/src/SqlLab/components/ResultSet.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Jlc3VsdFNldC5qc3g=) | `70.24% <0.00%> (-0.10%)` | :arrow_down: |
| [superset/views/database/api.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvYXBpLnB5) | `87.50% <0.00%> (ø)` | |
| ... and [3 more](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10177?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10177?src=pr&el=footer). Last update [4342c33...d083dc9](https://codecov.io/gh/apache/incubator-superset/pull/10177?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter removed a comment on pull request #10177: feat: Switch from nosetest to pytest
Posted by GitBox <gi...@apache.org>.
codecov-commenter removed a comment on pull request #10177:
URL: https://github.com/apache/incubator-superset/pull/10177#issuecomment-650408254
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10177?src=pr&el=h1) Report
> Merging [#10177](https://codecov.io/gh/apache/incubator-superset/pull/10177?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f888656e6de671069d7d04d511a215cc90327bd4&el=desc) will **decrease** coverage by `17.79%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10177?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10177 +/- ##
===========================================
- Coverage 70.55% 52.75% -17.80%
===========================================
Files 594 593 -1
Lines 31470 31416 -54
Branches 3228 3228
===========================================
- Hits 22204 16575 -5629
- Misses 9150 14725 +5575
Partials 116 116
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.49% <ø> (ø)` | |
| #javascript | `59.60% <ø> (-0.01%)` | :arrow_down: |
| #python | `39.84% <ø> (-30.53%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10177?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/utils/import\_datasource.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvaW1wb3J0X2RhdGFzb3VyY2UucHk=) | `16.66% <0.00%> (-83.34%)` | :arrow_down: |
| [superset/tasks/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvY2FjaGUucHk=) | `0.00% <0.00%> (-73.92%)` | :arrow_down: |
| [superset/sql\_parse.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | `29.65% <0.00%> (-69.66%)` | :arrow_down: |
| [superset/dashboards/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9kYW8ucHk=) | `23.30% <0.00%> (-68.19%)` | :arrow_down: |
| [superset/datasets/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvY3JlYXRlLnB5) | `31.48% <0.00%> (-66.67%)` | :arrow_down: |
| [superset/datasets/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvdXBkYXRlLnB5) | `27.38% <0.00%> (-66.67%)` | :arrow_down: |
| [superset/utils/pandas\_postprocessing.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvcGFuZGFzX3Bvc3Rwcm9jZXNzaW5nLnB5) | `25.54% <0.00%> (-62.78%)` | :arrow_down: |
| [superset/commands/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvdXRpbHMucHk=) | `37.50% <0.00%> (-62.50%)` | :arrow_down: |
| [superset/views/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdXRpbHMucHk=) | `23.07% <0.00%> (-60.58%)` | :arrow_down: |
| [superset/dao/base.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFvL2Jhc2UucHk=) | `36.36% <0.00%> (-60.01%)` | :arrow_down: |
| ... and [109 more](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10177?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10177?src=pr&el=footer). Last update [f888656...93b4012](https://codecov.io/gh/apache/incubator-superset/pull/10177?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10177: feat: Switch from nosetest to pytest
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10177:
URL: https://github.com/apache/incubator-superset/pull/10177#issuecomment-650480851
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10177?src=pr&el=h1) Report
> Merging [#10177](https://codecov.io/gh/apache/incubator-superset/pull/10177?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/3414f357922e19c57669f6ca7b711757594a6bb8&el=desc) will **decrease** coverage by `17.80%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10177?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10177 +/- ##
===========================================
- Coverage 70.56% 52.76% -17.81%
===========================================
Files 594 593 -1
Lines 31474 31416 -58
Branches 3228 3228
===========================================
- Hits 22209 16576 -5633
- Misses 9149 14724 +5575
Partials 116 116
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.49% <ø> (ø)` | |
| #javascript | `59.61% <ø> (ø)` | |
| #python | `39.84% <ø> (-30.54%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10177?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/utils/import\_datasource.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvaW1wb3J0X2RhdGFzb3VyY2UucHk=) | `16.66% <0.00%> (-83.34%)` | :arrow_down: |
| [superset/tasks/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvY2FjaGUucHk=) | `0.00% <0.00%> (-73.92%)` | :arrow_down: |
| [superset/sql\_parse.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | `29.65% <0.00%> (-69.66%)` | :arrow_down: |
| [superset/dashboards/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9kYW8ucHk=) | `23.30% <0.00%> (-68.94%)` | :arrow_down: |
| [superset/datasets/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvY3JlYXRlLnB5) | `31.48% <0.00%> (-66.67%)` | :arrow_down: |
| [superset/datasets/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvdXBkYXRlLnB5) | `27.38% <0.00%> (-66.67%)` | :arrow_down: |
| [superset/utils/pandas\_postprocessing.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvcGFuZGFzX3Bvc3Rwcm9jZXNzaW5nLnB5) | `25.54% <0.00%> (-62.78%)` | :arrow_down: |
| [superset/commands/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvdXRpbHMucHk=) | `37.50% <0.00%> (-62.50%)` | :arrow_down: |
| [superset/views/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdXRpbHMucHk=) | `23.07% <0.00%> (-60.58%)` | :arrow_down: |
| [superset/dao/base.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFvL2Jhc2UucHk=) | `36.36% <0.00%> (-60.01%)` | :arrow_down: |
| ... and [109 more](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10177?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10177?src=pr&el=footer). Last update [3414f35...2f73887](https://codecov.io/gh/apache/incubator-superset/pull/10177?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on pull request #10177: feat: Switch from nosetest to pytest
Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #10177:
URL: https://github.com/apache/incubator-superset/pull/10177#issuecomment-650449696
1. Code coverage is missing
<img src="https://user-images.githubusercontent.com/335541/85908543-5b399a80-b7ca-11ea-9e57-b90ec0206069.png" width="300" />
2. Might want to remove `nosetests` from pip dependencies and clean [this](https://github.com/apache/incubator-superset/blob/master/setup.cfg#L36-L41) up as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter commented on pull request #10177: feat: [WIP] Switch from nosetest to pytest
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #10177:
URL: https://github.com/apache/incubator-superset/pull/10177#issuecomment-650408254
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10177?src=pr&el=h1) Report
> Merging [#10177](https://codecov.io/gh/apache/incubator-superset/pull/10177?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f888656e6de671069d7d04d511a215cc90327bd4&el=desc) will **increase** coverage by `0.08%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10177?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10177 +/- ##
==========================================
+ Coverage 70.55% 70.64% +0.08%
==========================================
Files 594 404 -190
Lines 31470 13105 -18365
Branches 3228 3228
==========================================
- Hits 22204 9258 -12946
+ Misses 9150 3730 -5420
- Partials 116 117 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.14% <ø> (-0.35%)` | :arrow_down: |
| #javascript | `59.61% <ø> (ø)` | |
| #python | `?` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10177?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...et-frontend/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/TabbedSqlEditors.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmJlZFNxbEVkaXRvcnMuanN4) | `76.62% <0.00%> (-4.55%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/SqlEditorLeftBar.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvckxlZnRCYXIuanN4) | `44.00% <0.00%> (-4.00%)` | :arrow_down: |
| [...end/src/SqlLab/components/TemplateParamsEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RlbXBsYXRlUGFyYW1zRWRpdG9yLmpzeA==) | `88.57% <0.00%> (-2.86%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/reducers/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9zcWxMYWIuanM=) | `37.44% <0.00%> (-1.65%)` | :arrow_down: |
| [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `52.12% <0.00%> (-1.22%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/AceEditorWrapper.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0FjZUVkaXRvcldyYXBwZXIudHN4) | `55.91% <0.00%> (-1.08%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `60.25% <0.00%> (-0.43%)` | :arrow_down: |
| [superset/utils/pandas\_postprocessing.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvcGFuZGFzX3Bvc3Rwcm9jZXNzaW5nLnB5) | | |
| [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | | |
| ... and [189 more](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10177?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10177?src=pr&el=footer). Last update [f888656...a5094ce](https://codecov.io/gh/apache/incubator-superset/pull/10177?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter removed a comment on pull request #10177: feat: Switch from nosetest to pytest
Posted by GitBox <gi...@apache.org>.
codecov-commenter removed a comment on pull request #10177:
URL: https://github.com/apache/incubator-superset/pull/10177#issuecomment-650480851
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10177?src=pr&el=h1) Report
> Merging [#10177](https://codecov.io/gh/apache/incubator-superset/pull/10177?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/3414f357922e19c57669f6ca7b711757594a6bb8&el=desc) will **decrease** coverage by `17.80%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10177?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10177 +/- ##
===========================================
- Coverage 70.56% 52.76% -17.81%
===========================================
Files 594 593 -1
Lines 31474 31416 -58
Branches 3228 3228
===========================================
- Hits 22209 16576 -5633
- Misses 9149 14724 +5575
Partials 116 116
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.49% <ø> (ø)` | |
| #javascript | `59.61% <ø> (ø)` | |
| #python | `39.84% <ø> (-30.54%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10177?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/utils/import\_datasource.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvaW1wb3J0X2RhdGFzb3VyY2UucHk=) | `16.66% <0.00%> (-83.34%)` | :arrow_down: |
| [superset/tasks/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvY2FjaGUucHk=) | `0.00% <0.00%> (-73.92%)` | :arrow_down: |
| [superset/sql\_parse.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | `29.65% <0.00%> (-69.66%)` | :arrow_down: |
| [superset/dashboards/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9kYW8ucHk=) | `23.30% <0.00%> (-68.94%)` | :arrow_down: |
| [superset/datasets/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvY3JlYXRlLnB5) | `31.48% <0.00%> (-66.67%)` | :arrow_down: |
| [superset/datasets/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvdXBkYXRlLnB5) | `27.38% <0.00%> (-66.67%)` | :arrow_down: |
| [superset/utils/pandas\_postprocessing.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvcGFuZGFzX3Bvc3Rwcm9jZXNzaW5nLnB5) | `25.54% <0.00%> (-62.78%)` | :arrow_down: |
| [superset/commands/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvdXRpbHMucHk=) | `37.50% <0.00%> (-62.50%)` | :arrow_down: |
| [superset/views/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdXRpbHMucHk=) | `23.07% <0.00%> (-60.58%)` | :arrow_down: |
| [superset/dao/base.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFvL2Jhc2UucHk=) | `36.36% <0.00%> (-60.01%)` | :arrow_down: |
| ... and [109 more](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10177?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10177?src=pr&el=footer). Last update [3414f35...2f73887](https://codecov.io/gh/apache/incubator-superset/pull/10177?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter commented on pull request #10177: feat: Switch from nosetest to pytest
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #10177:
URL: https://github.com/apache/incubator-superset/pull/10177#issuecomment-650480851
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10177?src=pr&el=h1) Report
> Merging [#10177](https://codecov.io/gh/apache/incubator-superset/pull/10177?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f888656e6de671069d7d04d511a215cc90327bd4&el=desc) will **decrease** coverage by `17.64%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10177?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10177 +/- ##
===========================================
- Coverage 70.55% 52.90% -17.65%
===========================================
Files 594 593 -1
Lines 31470 31416 -54
Branches 3228 3228
===========================================
- Hits 22204 16621 -5583
- Misses 9150 14678 +5528
- Partials 116 117 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.07% <ø> (-0.42%)` | :arrow_down: |
| #javascript | `59.61% <ø> (ø)` | |
| #python | `40.22% <ø> (-30.15%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10177?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/utils/import\_datasource.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvaW1wb3J0X2RhdGFzb3VyY2UucHk=) | `16.66% <0.00%> (-83.34%)` | :arrow_down: |
| [superset/tasks/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvY2FjaGUucHk=) | `0.00% <0.00%> (-73.92%)` | :arrow_down: |
| [superset/sql\_parse.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | `29.65% <0.00%> (-69.66%)` | :arrow_down: |
| [superset/dashboards/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9kYW8ucHk=) | `23.30% <0.00%> (-68.19%)` | :arrow_down: |
| [superset/datasets/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvY3JlYXRlLnB5) | `31.48% <0.00%> (-66.67%)` | :arrow_down: |
| [superset/datasets/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvdXBkYXRlLnB5) | `27.38% <0.00%> (-66.67%)` | :arrow_down: |
| [superset/utils/pandas\_postprocessing.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvcGFuZGFzX3Bvc3Rwcm9jZXNzaW5nLnB5) | `25.54% <0.00%> (-62.78%)` | :arrow_down: |
| [superset/commands/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvdXRpbHMucHk=) | `37.50% <0.00%> (-62.50%)` | :arrow_down: |
| [superset/views/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdXRpbHMucHk=) | `23.07% <0.00%> (-60.58%)` | :arrow_down: |
| [superset/dao/base.py](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFvL2Jhc2UucHk=) | `36.36% <0.00%> (-60.01%)` | :arrow_down: |
| ... and [111 more](https://codecov.io/gh/apache/incubator-superset/pull/10177/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10177?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10177?src=pr&el=footer). Last update [f888656...7c5dbab](https://codecov.io/gh/apache/incubator-superset/pull/10177?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] bkyryliuk commented on pull request #10177: feat: Switch from nosetest to pytest
Posted by GitBox <gi...@apache.org>.
bkyryliuk commented on pull request #10177:
URL: https://github.com/apache/incubator-superset/pull/10177#issuecomment-650657173
@ktmud and @john-bodley could you please take another look?
I've missed some tests in the original implementation and had to do extra changes to the test class names.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org