You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@impala.apache.org by "Feng Guangyuan (Code Review)" <ge...@cloudera.org> on 2016/06/21 08:15:38 UTC

[Impala-CR](cdh5-trunk) IMPALA-3678: Impala FE SortNode analyzer conjuncts failure

Feng Guangyuan has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/3420

Change subject: IMPALA-3678: Impala FE SortNode analyzer conjuncts_ failure
......................................................................

IMPALA-3678: Impala FE SortNode analyzer conjuncts_ failure

This patch assumes that if the rhsRefs of the current predicates' tids
are NULL, the predicate can not be evaluated by the current node, unless
at least one rhsRef was existed, then the perspective predicate can go
into the next validation phase. That means the returned value should be
logical AND.

Change-Id: If823e4c8fb5e7ca2be38bf4b35f4fda97d1a052d
---
M fe/src/main/java/com/cloudera/impala/analysis/Analyzer.java
1 file changed, 9 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/20/3420/1
-- 
To view, visit http://gerrit.cloudera.org:8080/3420
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If823e4c8fb5e7ca2be38bf4b35f4fda97d1a052d
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Feng Guangyuan <gu...@intel.com>

[Impala-CR](cdh5-trunk) IMPALA-3678: Impala FE SortNode analyzer conjuncts failure

Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has abandoned this change.

Change subject: IMPALA-3678: Impala FE SortNode analyzer conjuncts_ failure
......................................................................


Abandoned

This was fixed in a different way.

-- 
To view, visit http://gerrit.cloudera.org:8080/3420
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: If823e4c8fb5e7ca2be38bf4b35f4fda97d1a052d
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Feng Guangyuan <gu...@intel.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>

[Impala-CR](cdh5-trunk) IMPALA-3678: Impala FE SortNode analyzer conjuncts failure

Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change.

Change subject: IMPALA-3678: Impala FE SortNode analyzer conjuncts_ failure
......................................................................


Patch Set 1:

See my comments on the JIRA. I'm not sure you are on the right track here. I think the root cause might be a different problem.

-- 
To view, visit http://gerrit.cloudera.org:8080/3420
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If823e4c8fb5e7ca2be38bf4b35f4fda97d1a052d
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Feng Guangyuan <gu...@intel.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-HasComments: No

[Impala-CR](cdh5-trunk) IMPALA-3678: Impala FE SortNode analyzer conjuncts failure

Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.

Change subject: IMPALA-3678: Impala FE SortNode analyzer conjuncts_ failure
......................................................................


Patch Set 1:

As a reminder, the gerrit "Impala" project is now deprecated. To lear now to switch, read

http://mail-archives.apache.org/mod_mbox/incubator-impala-dev/201607.mbox/%3CCAC-pSX2sHyqsoxGCCKrqmQbo-jjWdP6CMGoTU_1snuQVkDVg_w@mail.gmail.com%3E

To make sure you receive all messages that look like this, subscribe to

http://mail-archives.apache.org/mod_mbox/incubator-impala-dev/

-- 
To view, visit http://gerrit.cloudera.org:8080/3420
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If823e4c8fb5e7ca2be38bf4b35f4fda97d1a052d
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Feng Guangyuan <gu...@intel.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-HasComments: No