[GitHub] [daffodil-vscode] Shanedell commented on a diff in pull request #371: omega-edit updates

[GitBox <gi...@apache.org>]

Shanedell commented on code in PR #371:
URL: https://github.com/apache/daffodil-vscode/pull/371#discussion_r1046095203


##########
src/utils.ts:
##########
@@ -173,6 +173,19 @@ export async function executeScript(
   return terminal
 }
 
+export async function stopJavaProcess() {

Review Comment:
   No there is not, I am not to sure how common it is to run scripts on the OS through TS/JS like we are doing. But in another PR I have coming it up it split out a lot the OS specific stuff into separate functions to allow for better use of those items. But yeah I couldn't find any package that would be what we want, the closest thing is `run-script-os` but that is for the `package.json` scripts to make OS specific commands that way but nothing like what we would need.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org