You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/01/21 14:20:54 UTC

[GitHub] [pulsar] eolivelli opened a new pull request #9263: Ensure that temporary directories are deleted during tests

eolivelli opened a new pull request #9263:
URL: https://github.com/apache/pulsar/pull/9263


   ### Motivation
   The test suite (especially pulsar-broker) creates lots of temporary files, that accumulate on CI and also they fill up the /tmp dir during development (if you dare to run all of the tests locally)
   
   ### Modifications
   
   Modify LocalBookKeeperEnsemble to delete all the temporary directories it created at boot.
   We are not deleting directories that are passed externally from the constructor (like in Pulsar Standalone)
   
   ### Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] eolivelli commented on a change in pull request #9263: Ensure that temporary directories are deleted during tests

Posted by GitBox <gi...@apache.org>.
eolivelli commented on a change in pull request #9263:
URL: https://github.com/apache/pulsar/pull/9263#discussion_r561917224



##########
File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/service/AdvertisedAddressTest.java
##########
@@ -42,7 +42,7 @@
 
     @BeforeMethod
     public void setup() throws Exception {
-        bkEnsemble = new LocalBookkeeperEnsemble(3, 0, () -> 0);
+        bkEnsemble = new LocalBookkeeperEnsemble(1, 0, () -> 0);

Review comment:
       a change to this file is not necessary in the scope of this PR, btw we can save to start 2 bookies for this little test




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] eolivelli commented on a change in pull request #9263: Ensure that temporary directories are deleted during tests

Posted by GitBox <gi...@apache.org>.
eolivelli commented on a change in pull request #9263:
URL: https://github.com/apache/pulsar/pull/9263#discussion_r561917224



##########
File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/service/AdvertisedAddressTest.java
##########
@@ -42,7 +42,7 @@
 
     @BeforeMethod
     public void setup() throws Exception {
-        bkEnsemble = new LocalBookkeeperEnsemble(3, 0, () -> 0);
+        bkEnsemble = new LocalBookkeeperEnsemble(1, 0, () -> 0);

Review comment:
       a change to this file is not necessary in the scope of this PR, btw we can save to start 2 bookies for this little test




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] eolivelli commented on pull request #9263: Ensure that temporary directories are deleted during tests

Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #9263:
URL: https://github.com/apache/pulsar/pull/9263#issuecomment-765202946


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] eolivelli commented on pull request #9263: Ensure that temporary directories are deleted during tests

Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #9263:
URL: https://github.com/apache/pulsar/pull/9263#issuecomment-765529037


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] eolivelli commented on pull request #9263: Ensure that temporary directories are deleted during tests

Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #9263:
URL: https://github.com/apache/pulsar/pull/9263#issuecomment-768106730


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] eolivelli commented on pull request #9263: Ensure that temporary directories are deleted during tests

Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #9263:
URL: https://github.com/apache/pulsar/pull/9263#issuecomment-765390521


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] sijie merged pull request #9263: Ensure that temporary directories are deleted during tests

Posted by GitBox <gi...@apache.org>.
sijie merged pull request #9263:
URL: https://github.com/apache/pulsar/pull/9263


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] eolivelli commented on pull request #9263: Ensure that temporary directories are deleted during tests

Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #9263:
URL: https://github.com/apache/pulsar/pull/9263#issuecomment-765248775


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org