You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@jmeter.apache.org by bu...@apache.org on 2013/07/01 17:18:35 UTC
[Bug 55175] New: HTTPHC4Impl refactoring to allow better inheritance
https://issues.apache.org/bugzilla/show_bug.cgi?id=55175
Bug ID: 55175
Summary: HTTPHC4Impl refactoring to allow better inheritance
Product: JMeter
Version: Nightly (Please specify date)
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P2
Component: HTTP
Assignee: issues@jmeter.apache.org
Reporter: p.mouawad@ubik-ingenierie.com
It would be interesting to refactor slightly HTTPHC4Impl to allow inheriting
classes to reuse many of already implemented and useful internals.
This would be useful to classes that wish for example to post binary content
and similar stuff.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 55175] HTTPHC4Impl refactoring to allow better inheritance
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55175
--- Comment #4 from Philippe Mouawad <p....@ubik-ingenierie.com> ---
Date: Mon Jul 8 20:11:00 2013
New Revision: 1500926
URL: http://svn.apache.org/r1500926
Log:
Bug 55175 - HTTPHC4Impl refactoring to allow better inheritance
Bugzilla Id: 55175
Modified:
jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPHC4Impl.java
jmeter/trunk/xdocs/changes.xml
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 55175] HTTPHC4Impl refactoring to allow better inheritance
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55175
--- Comment #2 from Sebb <se...@apache.org> ---
There seem to be some spurious changes in the patch in the setupRequest method;
it's difficult to work out what is actually changing.
Also there needs to be better Javadoc for the protected methods, especially if
they are intended for use by 3rd party addins. If only intended for use by
JMeter, then that also needs to be documented.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 55175] HTTPHC4Impl refactoring to allow better inheritance
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55175
Philippe Mouawad <p....@ubik-ingenierie.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |p.mouawad@ubik-ingenierie.c
| |om
--- Comment #1 from Philippe Mouawad <p....@ubik-ingenierie.com> ---
Created attachment 30523
--> https://issues.apache.org/bugzilla/attachment.cgi?id=30523&action=edit
Proposed patch
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 55175] HTTPHC4Impl refactoring to allow better inheritance
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55175
Philippe Mouawad <p....@ubik-ingenierie.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 55175] HTTPHC4Impl refactoring to allow better inheritance
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55175
Philippe Mouawad <p....@ubik-ingenierie.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #30523|0 |1
is obsolete| |
--- Comment #3 from Philippe Mouawad <p....@ubik-ingenierie.com> ---
Created attachment 30552
--> https://issues.apache.org/bugzilla/attachment.cgi?id=30552&action=edit
Updated patch as per sebb notes
--
You are receiving this mail because:
You are the assignee for the bug.