[jclouds-labs-openstack] Add support for Database in Reddwarf (#3)

[Zack Shoylev <no...@github.com>]

https://issues.apache.org/jira/browse/JCLOUDS-34
You can merge this Pull Request by running:

  git pull https://github.com/rackerlabs/jclouds-labs-openstack reddwarf-database-api

Or you can view, comment on it, or merge it online at:

  https://github.com/jclouds/jclouds-labs-openstack/pull/3

-- Commit Summary --

  * Add support for Database in Reddwarf

-- File Changes --

    M openstack-reddwarf/src/main/java/org/jclouds/openstack/reddwarf/v1/RedDwarfApi.java (9)
    A openstack-reddwarf/src/main/java/org/jclouds/openstack/reddwarf/v1/binders/BindCreateDatabaseToJson.java (58)
    A openstack-reddwarf/src/main/java/org/jclouds/openstack/reddwarf/v1/features/DatabaseApi.java (110)
    M openstack-reddwarf/src/main/java/org/jclouds/openstack/reddwarf/v1/features/UserApi.java (11)
    A openstack-reddwarf/src/test/java/org/jclouds/openstack/reddwarf/v1/features/DatabaseApiExpectTest.java (161)
    A openstack-reddwarf/src/test/java/org/jclouds/openstack/reddwarf/v1/features/DatabaseApiLiveTest.java (120)
    M openstack-reddwarf/src/test/java/org/jclouds/openstack/reddwarf/v1/features/UserApiExpectTest.java (4)
    M openstack-reddwarf/src/test/java/org/jclouds/openstack/reddwarf/v1/features/UserApiLiveTest.java (16)
    A openstack-reddwarf/src/test/resources/database_create_request.json (9)
    A openstack-reddwarf/src/test/resources/database_create_simple_request.json (7)
    A openstack-reddwarf/src/test/resources/database_list.json (19)

-- Patch Links --

https://github.com/jclouds/jclouds-labs-openstack/pull/3.patch
https://github.com/jclouds/jclouds-labs-openstack/pull/3.diff

Re: [jclouds-labs-openstack] Add support for Database in Reddwarf (#3)

[Ignasi Barrera <no...@github.com>]

+1 This PR looks good to me.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/3#issuecomment-18666768

Re: [jclouds-labs-openstack] Add support for Database in Reddwarf (#3)

[BuildHive <no...@github.com>]

[jclouds » jclouds-labs-openstack #52](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/52/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/3#issuecomment-18639631

Re: [jclouds-labs-openstack] Add support for Database in Reddwarf (#3)

[BuildHive <no...@github.com>]

[jclouds » jclouds-labs-openstack #50](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/50/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/3#issuecomment-18633356

Re: [jclouds-labs-openstack] Add support for Database in Reddwarf (#3)

[BuildHive <no...@github.com>]

[jclouds » jclouds-labs-openstack #51](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/51/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/3#issuecomment-18636123

Re: [jclouds-labs-openstack] Add support for Database in Reddwarf (#3)

[Everett Toews <no...@github.com>]

Closed #3.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/3

Re: [jclouds-labs-openstack] Add support for Database in Reddwarf (#3)

[BuildHive <no...@github.com>]

[jclouds » jclouds-labs-openstack #47](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/47/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/3#issuecomment-18578665

Re: [jclouds-labs-openstack] Add support for Database in Reddwarf (#3)

[BuildHive <no...@github.com>]

[jclouds » jclouds-labs-openstack #54](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/54/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/3#issuecomment-18684932

Re: [jclouds-labs-openstack] Add support for Database in Reddwarf (#3)

[Ignasi Barrera <no...@github.com>]

> +    */
> +   @Named("database:create")
> +   @POST
> +   @Path("/databases")
> +   @Consumes(MediaType.APPLICATION_JSON)
> +   @Fallback(FalseOnNotFoundOr404.class)
> +   @MapBinder(BindCreateDatabaseToJson.class)
> +   boolean create(@PayloadParam("database") String database, @PayloadParam("character_set") String character_set, @PayloadParam("collate") String collate);
> +   
> +   /**
> +    * This operation deletes the specified database for the specified database instance.
> +    *
> +    * @param databaseName The name for the specified database.
> +    * @return true if successful
> +    */
> +   @Named("databases:delete/{name}")

I'm not sure about the `{name}` pattern here. The `@Named` annotation is used to identify the method and configure its timeout. Timeouts are defined using properties with the value of the annotation as follows:

```java
jclouds.timeouts.database:create = <timeout value>
```

And in this case the name of the property would be:

```java
jclouds.timeouts.database:delete/{name} = <timeout value>
```

Which seems a little weird. I'd just leave the value as `databases:delete`.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/3/files#r4437586

Re: [jclouds-labs-openstack] Add support for Database in Reddwarf (#3)

[Everett Toews <no...@github.com>]

Merged.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/3#issuecomment-18753758