You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lenya.apache.org by Andreas Hartmann <an...@apache.org> on 2004/06/14 17:42:12 UTC
Coding Style
Hi Lenya developers,
this code in ProxyGenerator.java took me 2 hrs of tracing:
<snip>
} catch (Exception e) {
this.contentHandler.startDocument();
AttributesImpl attr = new AttributesImpl();
this.start("servletproxygenerator", attr);
this.data(".generate(): " + e);
this.end("servletproxygenerator");
this.contentHandler.endDocument();
//log.error(e);
e.printStackTrace();
} finally {
this.manager.release((Component) parser);
}
</snip>
The generator was used in an aggregation, no invalid XML
was generated, the exception message vanished in smoke,
no log entries ...
I suggest that we refactor this class immediately
after 1.2 is released.
-- Andreas
---------------------------------------------------------------------
To unsubscribe, e-mail: lenya-dev-unsubscribe@cocoon.apache.org
For additional commands, e-mail: lenya-dev-help@cocoon.apache.org
Re: Coding Style
Posted by Rolf Kulemann <ro...@apache.org>.
On Mon, 2004-06-14 at 17:52, Gregor J. Rothfuss wrote:
> Andreas Hartmann wrote:
>
> > this code in ProxyGenerator.java took me 2 hrs of tracing:
>
> <snip>
>
> > The generator was used in an aggregation, no invalid XML
> > was generated, the exception message vanished in smoke,
> > no log entries ...
> >
> > I suggest that we refactor this class immediately
> > after 1.2 is released.
>
> actually, why does it even exist when cocoon has the same?
>
> if there is a feature that is missing from the coccoon one, then lets
> merge it. while we are at it, why do we have our own StreamGenerator?
I added the StreamGenerator due to an Epoz issue, because it sends
text/html and not text/xml, which is not accepted by the
streamegnerator....... See
http://archives2.real-time.com/pipermail/cocoon-devel/2003-December/025045.html
I also started to discuss merging changes into the cocoon one, but
discussion did not get to an end.....to be honest, I forgot to bring the
discussion to the end.
--
Rolf Kulemann
---------------------------------------------------------------------
To unsubscribe, e-mail: lenya-dev-unsubscribe@cocoon.apache.org
For additional commands, e-mail: lenya-dev-help@cocoon.apache.org
Re: Coding Style
Posted by "Gregor J. Rothfuss" <gr...@apache.org>.
Andreas Hartmann wrote:
> this code in ProxyGenerator.java took me 2 hrs of tracing:
<snip>
> The generator was used in an aggregation, no invalid XML
> was generated, the exception message vanished in smoke,
> no log entries ...
>
> I suggest that we refactor this class immediately
> after 1.2 is released.
actually, why does it even exist when cocoon has the same?
if there is a feature that is missing from the coccoon one, then lets
merge it. while we are at it, why do we have our own StreamGenerator?
-gregor
--
Gregor J. Rothfuss
Wyona Inc. - Open Source Content Management - Apache Lenya
http://wyona.com http://cocoon.apache.org/lenya
gregor.rothfuss@wyona.com gregor@apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: lenya-dev-unsubscribe@cocoon.apache.org
For additional commands, e-mail: lenya-dev-help@cocoon.apache.org