You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@whimsical.apache.org by se...@apache.org on 2020/07/09 21:49:31 UTC

[whimsy] branch master updated: Simplify by using library method

This is an automated email from the ASF dual-hosted git repository.

sebb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git


The following commit(s) were added to refs/heads/master by this push:
     new 2bef2fb  Simplify by using library method
2bef2fb is described below

commit 2bef2fbd725fae3629029003923dd193e2e5fcde
Author: Sebb <se...@apache.org>
AuthorDate: Thu Jul 9 22:49:22 2020 +0100

    Simplify by using library method
---
 www/roster/models/committer.rb | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/www/roster/models/committer.rb b/www/roster/models/committer.rb
index 7944802..9148165 100644
--- a/www/roster/models/committer.rb
+++ b/www/roster/models/committer.rb
@@ -149,26 +149,22 @@ class Committer
 
         file = ASF::EmeritusFiles.find(person)
         if file
-          url = ASF::SVN.svnurl('emeritus')
-          response[:forms][:emeritus] = "#{url}/#{file}"
+          response[:forms][:emeritus] = ASF::SVN.svnpath!('emeritus', file)
         end
 
         file = ASF::EmeritusRequestFiles.find(person)
         if file
-          url = ASF::SVN.svnurl('emeritus-requests-received')
-          response[:forms][:emeritus_request] = "#{url}/#{file}"
+          response[:forms][:emeritus_request] = ASF::SVN.svnpath!('emeritus-requests-received', file)
         end
 
         file = ASF::EmeritusRescindedFiles.find(person)
         if file
-          url = ASF::SVN.svnurl('emeritus-requests-rescinded')
-          response[:forms][:emeritus_rescinded] = "#{url}/#{file}"
+          response[:forms][:emeritus_rescinded] = ASF::SVN.svnpath!('emeritus-requests-rescinded', file)
         end
 
         file = ASF::EmeritusReinstatedFiles.find(person)
         if file
-          url = ASF::SVN.svnurl('emeritus-reinstated')
-          response[:forms][:emeritus_reinstated] = "#{url}/#{file}"
+          response[:forms][:emeritus_reinstated] = ASF::SVN.svnpath!('emeritus-reinstated', file)
         end
 
       else