You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@polaris.apache.org by "snazy (via GitHub)" <gi...@apache.org> on 2025/01/16 09:33:33 UTC
[PR] Optionally build Quarkus uber-jar [polaris]
snazy opened a new pull request, #797:
URL: https://github.com/apache/polaris/pull/797
We currently build Polaris Quarkus as a `fast-jar`. In order to eventually publish the Polaris Quarkus server in a binary release to Maven Central, it is beneficial to use an uber-jar.
This change allows to do that if the project property `uber-jar` is present, for example `./gradlew publishToMavenLocal -Puber-jar`
Note that the Quarkus uber-jars are placed directly in the Gradle project's `build/` directory, not in `build/libs/`
<!--
Possible security vulnerabilities: STOP here and contact security@apache.org instead!
Please update the title of the PR with a meaningful message - do not leave it "empty" or "generated"
Please update this summary field:
The summary should cover these topics, if applicable:
* the motivation for the change
* a description of the status quo, for example the current behavior
* the desired behavior
* etc
PR checklist:
- Do a self-review of your code before opening a pull request
- Make sure that there's good test coverage for the changes included in this PR
- Run tests locally before pushing a PR (./gradlew check)
- Code should have comments where applicable. Particularly hard-to-understand
areas deserve good in-line documentation.
- Include changes and enhancements to the documentation (in site/content/in-dev/unreleased)
- For Work In Progress Pull Requests, please use the Draft PR feature.
Make sure to add the information BELOW this comment.
Everything in this comment will NOT be added to the PR description.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Optionally build Polaris Server Quarkus uber-jar [polaris]
Posted by "snazy (via GitHub)" <gi...@apache.org>.
snazy commented on PR #797:
URL: https://github.com/apache/polaris/pull/797#issuecomment-2615724193
There are some pros and cons for each approach. Let's think a bit more about this change - putting it to "draft" for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Optionally build Polaris Server Quarkus uber-jar [polaris]
Posted by "snazy (via GitHub)" <gi...@apache.org>.
snazy commented on PR #797:
URL: https://github.com/apache/polaris/pull/797#issuecomment-2595069895
> I'm not opposed to the idea, but isn't this redundant with the `distribution` plugin?
Related, but different. The `distribution` plugin generates archives that users can manually extract and use. The published (uber) jar can be used as _dependency_ for integration tests (#785).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Optionally build Polaris Server Quarkus uber-jar [polaris]
Posted by "adutra (via GitHub)" <gi...@apache.org>.
adutra commented on PR #797:
URL: https://github.com/apache/polaris/pull/797#issuecomment-2595062394
I'm not opposed to the idea, but isn't this redundant with the `distribution` plugin?
Right now, 2 archives are being generated with the following content, including the required license files:
<img width="430" alt="image" src="https://github.com/user-attachments/assets/92c2378e-c6df-4b6b-879c-2ff703ce64a6" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Optionally build Polaris Server Quarkus uber-jar [polaris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #797: Optionally build Polaris Server Quarkus uber-jar
URL: https://github.com/apache/polaris/pull/797
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Optionally build Polaris Server Quarkus uber-jar [polaris]
Posted by "eric-maynard (via GitHub)" <gi...@apache.org>.
eric-maynard commented on code in PR #797:
URL: https://github.com/apache/polaris/pull/797#discussion_r1927463233
##########
quarkus/server/build.gradle.kts:
##########
@@ -69,10 +78,46 @@ tasks.register("polarisServerRun") { dependsOn("quarkusRun") }
distributions {
main {
contents {
- from(project.layout.buildDirectory.dir("quarkus-app"))
+ if (quarkusFatJar) {
+ from(project.layout.buildDirectory) { include("polaris-quarkus-admin-*-runner.jar") }
Review Comment:
Why doesn't this go in `/lib`?
##########
quarkus/server/build.gradle.kts:
##########
@@ -69,10 +78,46 @@ tasks.register("polarisServerRun") { dependsOn("quarkusRun") }
distributions {
main {
contents {
- from(project.layout.buildDirectory.dir("quarkus-app"))
+ if (quarkusFatJar) {
+ from(project.layout.buildDirectory) { include("polaris-quarkus-admin-*-runner.jar") }
Review Comment:
Why doesn't this go in `/libs`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Optionally build Polaris Server Quarkus uber-jar [polaris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #797:
URL: https://github.com/apache/polaris/pull/797#issuecomment-2691841737
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org