[GitHub] [brooklyn-server] duncangrant commented on a diff in pull request #1390: adding logging category and level to workflow logs

["duncangrant (via GitHub)" <gi...@apache.org>]

duncangrant commented on code in PR #1390:
URL: https://github.com/apache/brooklyn-server/pull/1390#discussion_r1170037508


##########
core/src/main/java/org/apache/brooklyn/core/workflow/steps/flow/LogWorkflowStep.java:
##########
@@ -26,12 +26,16 @@
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
+import org.apache.brooklyn.core.BrooklynLogging;
+
 public class LogWorkflowStep extends WorkflowStepDefinition {
 
-    private static final Logger LOG = LoggerFactory.getLogger(LogWorkflowStep.class);
+    private static Logger LOG = LoggerFactory.getLogger(LogWorkflowStep.class);

Review Comment:
   I think global and mutable is probably not a good idea.  



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org