(commons-beanutils) 34/37: Use compact array declaration

[gg...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch 1.X
in repository https://gitbox.apache.org/repos/asf/commons-beanutils.git

commit 4e4e2582a17f0146337615085d790f59a7840e9e
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Fri Jul 26 11:24:13 2024 -0400

    Use compact array declaration
    
    - Remove redundant parentheses
    - No need to nest
---
 .../beanutils/converters/LongArrayConverter.java   | 23 ++++++++++------------
 1 file changed, 10 insertions(+), 13 deletions(-)

diff --git a/src/main/java/org/apache/commons/beanutils/converters/LongArrayConverter.java b/src/main/java/org/apache/commons/beanutils/converters/LongArrayConverter.java
index 38e8b7d5..76c68c7a 100644
--- a/src/main/java/org/apache/commons/beanutils/converters/LongArrayConverter.java
+++ b/src/main/java/org/apache/commons/beanutils/converters/LongArrayConverter.java
@@ -72,7 +72,7 @@ public final class LongArrayConverter extends AbstractArrayConverter {
     /**
      * <p>Model object for type comparisons.</p>
      */
-    private static final long[] MODEL = new long[0];
+    private static final long[] MODEL = {};
 
 
     // --------------------------------------------------------- Public Methods
@@ -95,15 +95,14 @@ public final class LongArrayConverter extends AbstractArrayConverter {
         // Deal with a null value
         if (value == null) {
             if (useDefault) {
-                return (defaultValue);
-            } else {
-                throw new ConversionException("No value specified");
+                return defaultValue;
             }
+            throw new ConversionException("No value specified");
         }
 
         // Deal with the no-conversion-needed case
         if (MODEL.getClass() == value.getClass()) {
-            return (value);
+            return value;
         }
 
         // Deal with input value as a String array
@@ -114,13 +113,12 @@ public final class LongArrayConverter extends AbstractArrayConverter {
                 for (int i = 0; i < values.length; i++) {
                     results[i] = Long.parseLong(values[i]);
                 }
-                return (results);
+                return results;
             } catch (final Exception e) {
                 if (useDefault) {
-                    return (defaultValue);
-                } else {
-                    throw new ConversionException(value.toString(), e);
+                    return defaultValue;
                 }
+                throw new ConversionException(value.toString(), e);
             }
         }
 
@@ -132,13 +130,12 @@ public final class LongArrayConverter extends AbstractArrayConverter {
             for (int i = 0; i < results.length; i++) {
                 results[i] = Long.parseLong((String) list.get(i));
             }
-            return (results);
+            return results;
         } catch (final Exception e) {
             if (useDefault) {
-                return (defaultValue);
-            } else {
-                throw new ConversionException(value.toString(), e);
+                return defaultValue;
             }
+            throw new ConversionException(value.toString(), e);
         }
 
     }