You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Santhosh Edukulla <sa...@citrix.com> on 2014/04/16 11:50:11 UTC

Review Request 20411: Added few fixes for CLOUDSTACK-6316

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20411/
-----------------------------------------------------------

Review request for cloudstack and SrikanteswaraRao Talluri.


Repository: cloudstack-git


Description
-------

Added few changes for CLOUDSTACK-6316
    
1. Added pep8 changes, delete dc flag.
2. Now, delete dc works only if flag is set under config.
3. SSH, retries and delay were altered to reduce the time
    for ssh connection


Diffs
-----

  tools/marvin/marvin/cloudstackConnection.py e3c5590 
  tools/marvin/marvin/cloudstackTestClient.py 1e13506 
  tools/marvin/marvin/codes.py 4096a44 
  tools/marvin/marvin/config/test_data.py 67acc77 
  tools/marvin/marvin/deployDataCenter.py 8e39e73 
  tools/marvin/marvin/marvinLog.py 9b4dd19 
  tools/marvin/marvin/marvinPlugin.py e631985 
  tools/marvin/marvin/sshClient.py fb4e18b 
  tools/marvin/setup.py 9160642 

Diff: https://reviews.apache.org/r/20411/diff/


Testing
-------


Thanks,

Santhosh Edukulla

Re: Review Request 20411: Added few fixes for CLOUDSTACK-6316

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20411/#review41120
-----------------------------------------------------------


Commit b2543efaca31bc7932ebe6ecefa963849049f39f in cloudstack's branch refs/heads/master from SrikanteswaraRao Talluri
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=b2543ef ]

CLOUDSTACK-6316: added else code in __createUserApiClient function


- ASF Subversion and Git Services


On April 16, 2014, 9:50 a.m., Santhosh Edukulla wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20411/
> -----------------------------------------------------------
> 
> (Updated April 16, 2014, 9:50 a.m.)
> 
> 
> Review request for cloudstack and SrikanteswaraRao Talluri.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Added few changes for CLOUDSTACK-6316
>     
> 1. Added pep8 changes, delete dc flag.
> 2. Now, delete dc works only if flag is set under config.
> 3. SSH, retries and delay were altered to reduce the time
>     for ssh connection
> 
> 
> Diffs
> -----
> 
>   tools/marvin/marvin/cloudstackConnection.py e3c5590 
>   tools/marvin/marvin/cloudstackTestClient.py 1e13506 
>   tools/marvin/marvin/codes.py 4096a44 
>   tools/marvin/marvin/config/test_data.py 67acc77 
>   tools/marvin/marvin/deployDataCenter.py 8e39e73 
>   tools/marvin/marvin/marvinLog.py 9b4dd19 
>   tools/marvin/marvin/marvinPlugin.py e631985 
>   tools/marvin/marvin/sshClient.py fb4e18b 
>   tools/marvin/setup.py 9160642 
> 
> Diff: https://reviews.apache.org/r/20411/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Santhosh Edukulla
> 
>

Re: Review Request 20411: Added few fixes for CLOUDSTACK-6316

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20411/#review41119
-----------------------------------------------------------


Commit ca67e25f2399d4c2bb7b7fde30616f6acf683f16 in cloudstack's branch refs/heads/master from SrikanteswaraRao Talluri
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=ca67e25 ]

CLOUDSTACK-6316: fixed test data and their references in the test files and few more fixes in tests


- ASF Subversion and Git Services


On April 16, 2014, 9:50 a.m., Santhosh Edukulla wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20411/
> -----------------------------------------------------------
> 
> (Updated April 16, 2014, 9:50 a.m.)
> 
> 
> Review request for cloudstack and SrikanteswaraRao Talluri.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Added few changes for CLOUDSTACK-6316
>     
> 1. Added pep8 changes, delete dc flag.
> 2. Now, delete dc works only if flag is set under config.
> 3. SSH, retries and delay were altered to reduce the time
>     for ssh connection
> 
> 
> Diffs
> -----
> 
>   tools/marvin/marvin/cloudstackConnection.py e3c5590 
>   tools/marvin/marvin/cloudstackTestClient.py 1e13506 
>   tools/marvin/marvin/codes.py 4096a44 
>   tools/marvin/marvin/config/test_data.py 67acc77 
>   tools/marvin/marvin/deployDataCenter.py 8e39e73 
>   tools/marvin/marvin/marvinLog.py 9b4dd19 
>   tools/marvin/marvin/marvinPlugin.py e631985 
>   tools/marvin/marvin/sshClient.py fb4e18b 
>   tools/marvin/setup.py 9160642 
> 
> Diff: https://reviews.apache.org/r/20411/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Santhosh Edukulla
> 
>

Re: Review Request 20411: Added few fixes for CLOUDSTACK-6316

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20411/#review40529
-----------------------------------------------------------


Commit 901d633ca426ee5542e9b021135cd8fb2288a25c in cloudstack's branch refs/heads/marvin from Santhosh Edukulla
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=901d633 ]

Added few changes for CLOUDSTACK-6316

1. Added pep8 changes, delete dc flag.
2. Now, delete dc works only if flag is set under config.
3. SSH, retries and delay were altered to reduce the time
for ssh connection

Signed-off-by: Santhosh Edukulla <Sa...@citrix.com>
Signed-off-by: SrikanteswaraRao Talluri <ta...@apache.org>


- ASF Subversion and Git Services


On April 16, 2014, 9:50 a.m., Santhosh Edukulla wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20411/
> -----------------------------------------------------------
> 
> (Updated April 16, 2014, 9:50 a.m.)
> 
> 
> Review request for cloudstack and SrikanteswaraRao Talluri.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Added few changes for CLOUDSTACK-6316
>     
> 1. Added pep8 changes, delete dc flag.
> 2. Now, delete dc works only if flag is set under config.
> 3. SSH, retries and delay were altered to reduce the time
>     for ssh connection
> 
> 
> Diffs
> -----
> 
>   tools/marvin/marvin/cloudstackConnection.py e3c5590 
>   tools/marvin/marvin/cloudstackTestClient.py 1e13506 
>   tools/marvin/marvin/codes.py 4096a44 
>   tools/marvin/marvin/config/test_data.py 67acc77 
>   tools/marvin/marvin/deployDataCenter.py 8e39e73 
>   tools/marvin/marvin/marvinLog.py 9b4dd19 
>   tools/marvin/marvin/marvinPlugin.py e631985 
>   tools/marvin/marvin/sshClient.py fb4e18b 
>   tools/marvin/setup.py 9160642 
> 
> Diff: https://reviews.apache.org/r/20411/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Santhosh Edukulla
> 
>

Re: Review Request 20411: Added few fixes for CLOUDSTACK-6316

Posted by SrikanteswaraRao Talluri <sr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20411/#review40527
-----------------------------------------------------------

Ship it!


Ship It!

- SrikanteswaraRao Talluri


On April 16, 2014, 9:50 a.m., Santhosh Edukulla wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20411/
> -----------------------------------------------------------
> 
> (Updated April 16, 2014, 9:50 a.m.)
> 
> 
> Review request for cloudstack and SrikanteswaraRao Talluri.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Added few changes for CLOUDSTACK-6316
>     
> 1. Added pep8 changes, delete dc flag.
> 2. Now, delete dc works only if flag is set under config.
> 3. SSH, retries and delay were altered to reduce the time
>     for ssh connection
> 
> 
> Diffs
> -----
> 
>   tools/marvin/marvin/cloudstackConnection.py e3c5590 
>   tools/marvin/marvin/cloudstackTestClient.py 1e13506 
>   tools/marvin/marvin/codes.py 4096a44 
>   tools/marvin/marvin/config/test_data.py 67acc77 
>   tools/marvin/marvin/deployDataCenter.py 8e39e73 
>   tools/marvin/marvin/marvinLog.py 9b4dd19 
>   tools/marvin/marvin/marvinPlugin.py e631985 
>   tools/marvin/marvin/sshClient.py fb4e18b 
>   tools/marvin/setup.py 9160642 
> 
> Diff: https://reviews.apache.org/r/20411/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Santhosh Edukulla
> 
>

Re: Review Request 20411: Added few fixes for CLOUDSTACK-6316

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20411/#review41121
-----------------------------------------------------------


Commit 901d633ca426ee5542e9b021135cd8fb2288a25c in cloudstack's branch refs/heads/master from Santhosh Edukulla
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=901d633 ]

Added few changes for CLOUDSTACK-6316

1. Added pep8 changes, delete dc flag.
2. Now, delete dc works only if flag is set under config.
3. SSH, retries and delay were altered to reduce the time
for ssh connection

Signed-off-by: Santhosh Edukulla <Sa...@citrix.com>
Signed-off-by: SrikanteswaraRao Talluri <ta...@apache.org>


- ASF Subversion and Git Services


On April 16, 2014, 9:50 a.m., Santhosh Edukulla wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20411/
> -----------------------------------------------------------
> 
> (Updated April 16, 2014, 9:50 a.m.)
> 
> 
> Review request for cloudstack and SrikanteswaraRao Talluri.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Added few changes for CLOUDSTACK-6316
>     
> 1. Added pep8 changes, delete dc flag.
> 2. Now, delete dc works only if flag is set under config.
> 3. SSH, retries and delay were altered to reduce the time
>     for ssh connection
> 
> 
> Diffs
> -----
> 
>   tools/marvin/marvin/cloudstackConnection.py e3c5590 
>   tools/marvin/marvin/cloudstackTestClient.py 1e13506 
>   tools/marvin/marvin/codes.py 4096a44 
>   tools/marvin/marvin/config/test_data.py 67acc77 
>   tools/marvin/marvin/deployDataCenter.py 8e39e73 
>   tools/marvin/marvin/marvinLog.py 9b4dd19 
>   tools/marvin/marvin/marvinPlugin.py e631985 
>   tools/marvin/marvin/sshClient.py fb4e18b 
>   tools/marvin/setup.py 9160642 
> 
> Diff: https://reviews.apache.org/r/20411/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Santhosh Edukulla
> 
>