You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@impala.apache.org by "Henry Robinson (Code Review)" <ge...@cloudera.org> on 2016/12/12 19:10:33 UTC
[Toolchain-CR] IMPALA-4650: Add protobuf 2.6.1 to toolchain
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5479
Change subject: IMPALA-4650: Add protobuf 2.6.1 to toolchain
......................................................................
IMPALA-4650: Add protobuf 2.6.1 to toolchain
This is preparation for the KRPC changes in IMPALA-2567
Change-Id: Icd4c7ecedf22d44213aff7a4999ba99d8868f41d
---
A source/protobuf/build.sh
1 file changed, 35 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Toolchain refs/changes/79/5479/1
--
To view, visit http://gerrit.cloudera.org:8080/5479
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icd4c7ecedf22d44213aff7a4999ba99d8868f41d
Gerrit-PatchSet: 1
Gerrit-Project: Toolchain
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
[Toolchain-CR] IMPALA-4650: Add protobuf 2.6.1 to toolchain
Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Henry Robinson has submitted this change and it was merged.
Change subject: IMPALA-4650: Add protobuf 2.6.1 to toolchain
......................................................................
IMPALA-4650: Add protobuf 2.6.1 to toolchain
This is preparation for the KRPC changes in IMPALA-2567
Change-Id: Icd4c7ecedf22d44213aff7a4999ba99d8868f41d
---
A source/protobuf/build.sh
1 file changed, 32 insertions(+), 0 deletions(-)
Approvals:
Henry Robinson: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/5479
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icd4c7ecedf22d44213aff7a4999ba99d8868f41d
Gerrit-PatchSet: 2
Gerrit-Project: Toolchain
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Toolchain-CR] IMPALA-4650: Add protobuf 2.6.1 to toolchain
Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Bharath Vissapragada has posted comments on this change.
Change subject: IMPALA-4650: Add protobuf 2.6.1 to toolchain
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5479/1/source/protobuf/build.sh
File source/protobuf/build.sh:
PS1, Line 2: 2015
nit: 2016?
--
To view, visit http://gerrit.cloudera.org:8080/5479
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd4c7ecedf22d44213aff7a4999ba99d8868f41d
Gerrit-PatchSet: 1
Gerrit-Project: Toolchain
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: Yes
[Toolchain-CR] IMPALA-4650: Add protobuf 2.6.1 to toolchain
Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4650: Add protobuf 2.6.1 to toolchain
......................................................................
Patch Set 2: Code-Review+2 Verified+1
Passed a private job.
--
To view, visit http://gerrit.cloudera.org:8080/5479
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd4c7ecedf22d44213aff7a4999ba99d8868f41d
Gerrit-PatchSet: 2
Gerrit-Project: Toolchain
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Toolchain-CR] IMPALA-4650: Add protobuf 2.6.1 to toolchain
Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4650: Add protobuf 2.6.1 to toolchain
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/5479/1/source/protobuf/build.sh
File source/protobuf/build.sh:
PS1, Line 2: 2015
> nit: 2016?
Done
Line 16: # cleans and rebuilds thirdparty/. The Impala build environment must be set up
> Old comment?
Done
--
To view, visit http://gerrit.cloudera.org:8080/5479
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd4c7ecedf22d44213aff7a4999ba99d8868f41d
Gerrit-PatchSet: 1
Gerrit-Project: Toolchain
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: Yes
[Toolchain-CR] IMPALA-4650: Add protobuf 2.6.1 to toolchain
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4650: Add protobuf 2.6.1 to toolchain
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5479/1/source/protobuf/build.sh
File source/protobuf/build.sh:
Line 16: # cleans and rebuilds thirdparty/. The Impala build environment must be set up
Old comment?
--
To view, visit http://gerrit.cloudera.org:8080/5479
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd4c7ecedf22d44213aff7a4999ba99d8868f41d
Gerrit-PatchSet: 1
Gerrit-Project: Toolchain
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: Yes
[Toolchain-CR] IMPALA-4650: Add protobuf 2.6.1 to toolchain
Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Hello Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5479
to look at the new patch set (#2).
Change subject: IMPALA-4650: Add protobuf 2.6.1 to toolchain
......................................................................
IMPALA-4650: Add protobuf 2.6.1 to toolchain
This is preparation for the KRPC changes in IMPALA-2567
Change-Id: Icd4c7ecedf22d44213aff7a4999ba99d8868f41d
---
A source/protobuf/build.sh
1 file changed, 32 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Toolchain refs/changes/79/5479/2
--
To view, visit http://gerrit.cloudera.org:8080/5479
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Icd4c7ecedf22d44213aff7a4999ba99d8868f41d
Gerrit-PatchSet: 2
Gerrit-Project: Toolchain
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>