You are viewing a plain text version of this content. The canonical link for it is here.
Posted to bugs@httpd.apache.org by bu...@apache.org on 2016/08/11 15:16:56 UTC

[Bug 59979] New: Add log message when ap_save_brigade fails

https://bz.apache.org/bugzilla/show_bug.cgi?id=59979

            Bug ID: 59979
           Summary: Add log message when ap_save_brigade fails
           Product: Apache httpd-2
           Version: 2.5-HEAD
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P2
         Component: All
          Assignee: bugs@httpd.apache.org
          Reporter: jiazhouyang@nudt.edu.cn

Created attachment 34125
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=34125&action=edit
Add log message when ap_save_brigade fails

Function ap_save_brigade may fail. The majority of calls have checked the
return value and printed log message like the following code snippet, while the
others have not. Those unchecked ones probably need logs too (see attachment).

/* httpd-2.4.10/modules/proxy/mod_proxy_http.c:826:18 */
        status = ap_save_brigade(NULL, &input_brigade, &temp_brigade, p);
        if (status != APR_SUCCESS) {
            ap_log_rerror(APLOG_MARK, APLOG_ERR, status, r, APLOGNO(01096)
                          "processing prefetched request body failed"
                          " to %pI (%s) from %s (%s)",
                          p_conn->addr, p_conn->hostname ? p_conn->hostname:
"",
                          c->client_ip, c->remote_host ? c->remote_host: "");
            return HTTP_INTERNAL_SERVER_ERROR;
        }

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 59979] [patch] Add log message when ap_save_brigade fails

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59979

jiazhouyang@nudt.edu.cn changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Add log message when        |[patch] Add log message
                   |ap_save_brigade fails       |when ap_save_brigade fails

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org