You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@linkis.apache.org by GitBox <gi...@apache.org> on 2022/07/17 04:15:47 UTC

[GitHub] [incubator-linkis] Dlimeng commented on a diff in pull request #2444: [Feature] Dev 1.2.1 linkis metadata query add database

Dlimeng commented on code in PR #2444:
URL: https://github.com/apache/incubator-linkis/pull/2444#discussion_r922767200


##########
linkis-public-enhancements/linkis-datasource/linkis-metadata-query/service/mysql/pom.xml:
##########
@@ -55,11 +56,69 @@
             </exclusions>
             <scope>provided</scope>
         </dependency>
-        <dependency>
-            <groupId>mysql</groupId>
-            <artifactId>mysql-connector-java</artifactId>
-            <version>${mysql.version}</version>
-        </dependency>
+        <!--mysql-->
+<!--        <dependency>-->
+<!--            <groupId>mysql</groupId>-->
+<!--            <artifactId>mysql-connector-java</artifactId>-->
+<!--            <version>${mysql.version}</version>-->
+<!--        </dependency>-->
+
+<!--        <dependency>-->
+<!--            <groupId>com.oracle</groupId>-->
+<!--            <artifactId>ojdbc6</artifactId>-->
+<!--            <version>11.2.0.3</version>-->
+<!--            <scope>system</scope>-->
+<!--            <systemPath>${basedir}/src/main/lib/ojdbc6-11.2.0.3.jar</systemPath>-->
+<!--        </dependency>-->
+
+<!--        <dependency>-->
+<!--            <groupId>com.ibm.db2.jcc</groupId>-->
+<!--            <artifactId>db2jcc</artifactId>-->
+<!--            <version>db2jcc4</version>-->
+<!--        </dependency>-->
+<!--        <dependency>-->
+<!--            <groupId>com.dameng</groupId>-->
+<!--            <artifactId>Dm7JdbcDriver16</artifactId>-->
+<!--            <version>7.6.0.165</version>-->
+<!--        </dependency>-->
+<!--        <dependency>-->
+<!--            <groupId>com.pivotal</groupId>-->
+<!--            <artifactId>greenplum-jdbc</artifactId>-->
+<!--            <version>5.1.4</version>-->
+<!--        </dependency>-->
+<!--        <dependency>-->
+<!--            <groupId>com.kingbase</groupId>-->
+<!--            <artifactId>kingbase8</artifactId>-->
+<!--            <version>8</version>-->
+<!--        </dependency>-->
+<!--        <dependency>-->
+<!--            <groupId>org.postgresql</groupId>-->
+<!--            <artifactId>postgresql</artifactId>-->
+<!--            <version>${postgresql.version}</version>-->
+<!--        </dependency>-->
+
+
+<!--        <dependency>-->
+<!--            <groupId>com.microsoft.jdbc.sqlserver</groupId>-->
+<!--            <artifactId>msbase</artifactId>-->
+<!--            <version>1.0</version>-->
+<!--            <scope>system</scope>-->
+<!--            <systemPath>${basedir}/src/main/lib/msbase-1.0.jar</systemPath>-->
+<!--        </dependency>-->
+<!--        <dependency>-->
+<!--            <groupId>com.microsoft.jdbc.sqlserver</groupId>-->
+<!--            <artifactId>msutil</artifactId>-->
+<!--            <version>1.0</version>-->
+<!--            <scope>system</scope>-->
+<!--            <systemPath>${basedir}/src/main/lib/msutil-1.0.jar</systemPath>-->
+<!--        </dependency>-->
+<!--        <dependency>-->
+<!--            <groupId>com.microsoft.jdbc.sqlserver</groupId>-->
+<!--            <artifactId>mssqlserver</artifactId>-->
+<!--            <version>1.0</version>-->
+<!--            <scope>system</scope>-->
+<!--            <systemPath>${basedir}/src/main/lib/mssqlserver-1.0.jar</systemPath>-->
+<!--        </dependency>-->

Review Comment:
   postgresql can be referenced directly, other references need to be downloaded from the official website



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org