[GitHub] [superset] betodealmeida commented on a change in pull request #17771: refactor(sql_lab): SQL Lab Persistent Saved State

[GitBox <gi...@apache.org>]

betodealmeida commented on a change in pull request #17771:
URL: https://github.com/apache/superset/pull/17771#discussion_r783528052



##########
File path: superset-frontend/src/SqlLab/actions/sqlLab.js
##########
@@ -869,14 +870,32 @@ export function saveQuery(query) {
           query,
           result: convertQueryToClient(result.json.item),
         });
-        dispatch(addSuccessToast(t('Your query was saved')));
         dispatch(queryEditorSetTitle(query, query.title));
+        return convertQueryToClient(result.json.item);

Review comment:
       Why do we need this here?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org