You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/06/29 19:15:33 UTC

[GitHub] [spark] tgravescs edited a comment on pull request #33135: [SPARK-35931][CORE][YARN] Ability to override Yarn Cluster Submit Class with Configuration

tgravescs edited a comment on pull request #33135:
URL: https://github.com/apache/spark/pull/33135#issuecomment-870847874


   I'm pretty hesitant about this without more information.  I do not want yet another plugin place that we have to maintain and is a one off use.  These are all internal Spark classes as well, so making a config for it without some public or developer interface doesn't make a lot of sense.  cc @mridulm  as well
   
   Can you give more details about exactly what requires changing here? 
   
   > there may be significant (non-generic) changes required in Yarn client
   
   If its a different yarn Client, if its way different it should just be a separate resource manager perhaps. If its something smaller (which it doesn't sound like from the description) perhaps something else needs to be more flexible.
   
   Another question - the ApplicationMaster doesn't need modified as well?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org