You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/09/15 02:38:41 UTC
[GitHub] [shardingsphere-elasticjob] Technoboy- commented on a change in pull request #1457: Trigger one-off job via Zookeeper
Technoboy- commented on a change in pull request #1457:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1457#discussion_r488347532
##########
File path: elasticjob-lite/elasticjob-lite-core/src/main/java/org/apache/shardingsphere/elasticjob/lite/api/bootstrap/impl/OneOffJobBootstrap.java
##########
@@ -57,7 +59,15 @@ public OneOffJobBootstrap(final CoordinatorRegistryCenter regCenter, final Strin
*/
public void execute() {
Preconditions.checkArgument(Strings.isNullOrEmpty(jobScheduler.getJobConfig().getCron()), "Cron should be empty.");
- jobScheduler.getJobScheduleController().executeJob();
+ triggerAllInstancesManually();
+ }
+
+ private void triggerAllInstancesManually() {
Review comment:
triggerAllInstancesManually -> triggerAllInstances is much more better ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org