You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2022/01/13 22:45:07 UTC
[GitHub] [druid] clintropolis opened a new pull request #12155: fix incorrect ColumnInspector in IncrementalIndex.makeColumnSelectorFactory
clintropolis opened a new pull request #12155:
URL: https://github.com/apache/druid/pull/12155
This PR reverts a change made semi recently that causes potentially subtly incorrect `ColumnInspector` to be used in a `RowBasedColumnSelectorFactory` in `IncrementalIndex`. The schema of the `IncrementalIndex` doesn't necessarily match the schema of the `InputRow`, which was my mistake.
Ideally, the InputRow could provide its signature so that the stuff using this column selector factory could have better information, but i'll save that for another day.
It isn't immediately obvious to me the best way to add a direct test for this, will add to PR if i think of one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] clintropolis merged pull request #12155: fix incorrect ColumnInspector in IncrementalIndex.makeColumnSelectorFactory
Posted by GitBox <gi...@apache.org>.
clintropolis merged pull request #12155:
URL: https://github.com/apache/druid/pull/12155
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org