You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by GitBox <gi...@apache.org> on 2020/03/31 23:59:22 UTC
[GitHub] [cassandra] dcapwell commented on a change in pull request #500:
Bug/negative disk space
dcapwell commented on a change in pull request #500: Bug/negative disk space
URL: https://github.com/apache/cassandra/pull/500#discussion_r401282232
##########
File path: src/java/org/apache/cassandra/db/lifecycle/LifecycleTransaction.java
##########
@@ -224,12 +229,14 @@ public Throwable doCommit(Throwable accumulate)
accumulate = markObsolete(obsoletions, accumulate);
accumulate = tracker.updateSizeTracking(logged.obsolete, logged.update, accumulate);
+ accumulate = runOnCommitHooks(accumulate);
Review comment:
I debate if these should be first or at the end
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org