You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Ignasi Barrera <no...@github.com> on 2015/11/24 15:36:29 UTC
[jclouds] Fix filesystem api in OSX (#884)
/cc @andrewgaul @kahing
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds/pull/884
-- Commit Summary --
* Fix filesystem api in OSX
-- File Changes --
M apis/filesystem/src/main/java/org/jclouds/filesystem/strategy/internal/FilesystemStorageStrategyImpl.java (4)
-- Patch Links --
https://github.com/jclouds/jclouds/pull/884.patch
https://github.com/jclouds/jclouds/pull/884.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/884
Re: [jclouds] Fix filesystem api in OSX (#884)
Posted by Andrew Phillips <no...@github.com>.
> The jclouds loggers already take care of that.
Er...ah, yes, of course - this is _jclouds_ logging, not SLF4J. Doh! ;-)
Thanks, Ignasi!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/884#issuecomment-159351600
Re: [jclouds] Fix filesystem api in OSX (#884)
Posted by Ignasi Barrera <no...@github.com>.
For some reason the github PR preview shows both commits when the PR was actually rebased to the latest master. Look at the commit hash of the ec2 fix (whcih comes from a previous PR); it matches the commit that was currently on master.
The pr did actually contain only 1 commit, but the github preview showed both. Don't know why. The master commit history looks clean too.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/884#issuecomment-159341257
Re: [jclouds] Fix filesystem api in OSX (#884)
Posted by Ka-Hing Cheung <no...@github.com>.
:+1:
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/884#issuecomment-159359936
Re: [jclouds] Fix filesystem api in OSX (#884)
Posted by Andrew Phillips <no...@github.com>.
> The master commit history looks clean too.
I'm sure all is well there ;-) Just wanted to check that the relevant bit of the change is indeed only:
```
- if (!view.list().isEmpty()) {
+ if (view == null) { // OSX HFS+ does not support UserDefinedFileAttributeView
+ logger.debug("Could not look for attributes from %s", directory);
+ } else if (!view.list().isEmpty()) {
```
Regarding that: what's our feeling on making `logger.debug` calls that are not wrapped by `logger.isDebugEnabled`?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/884#issuecomment-159342144
Re: [jclouds] Fix filesystem api in OSX (#884)
Posted by Ignasi Barrera <no...@github.com>.
>Regarding that: what's our feeling on making logger.debug calls that are not wrapped by logger.isDebugEnabled?
The [jclouds loggers](https://github.com/jclouds/jclouds/blob/master/core/src/main/java/org/jclouds/logging/BaseLogger.java#L47-L50) already take care of that.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/884#issuecomment-159344766
Re: [jclouds] Fix filesystem api in OSX (#884)
Posted by Andrew Phillips <no...@github.com>.
@nacx Were both of these commits intended to be part of this PR? It looks like only one small change is actually about OS X filesystem support?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/884#issuecomment-159339007
Re: [jclouds] Fix filesystem api in OSX (#884)
Posted by Ignasi Barrera <no...@github.com>.
jclouds FTW! ^^
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/884#issuecomment-159354166