[jira] [Work logged] (TS-5027) Replace readdir_r with readdir.

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/TS-5027?focusedWorklogId=31504&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-31504 ]

ASF GitHub Bot logged work on TS-5027:
--------------------------------------

                Author: ASF GitHub Bot
            Created on: 03/Nov/16 04:32
            Start Date: 03/Nov/16 04:32
    Worklog Time Spent: 10m 
      Work Description: GitHub user jpeach opened a pull request:

    https://github.com/apache/trafficserver/pull/1181

    TS-5027: Replace readdir_r with readdir.

    Glibc deprecated readdir_r(3), so replace it with readdir(3). We
    were already using readdir(3) in many places so this is just accepting
    the inevitable.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jpeach/trafficserver fix/readdir

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/trafficserver/pull/1181.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1181
    
----
commit c886cffa126c756e9729b450ffd86e444c2260d7
Author: James Peach <jp...@apache.org>
Date:   2016-11-03T04:30:47Z

    TS-5027: Replace readdir_r with readdir.
    
    Glibc deprecated readdir_r(3), so replace it with readdir(3). We
    were already using readdir(3) in many places so this is just accepting
    the inevitable.

----


Issue Time Tracking
-------------------

            Worklog Id:     (was: 31504)
            Time Spent: 10m
    Remaining Estimate: 0h

> Replace readdir_r with readdir.
> -------------------------------
>
>                 Key: TS-5027
>                 URL: https://issues.apache.org/jira/browse/TS-5027
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Cleanup, Core
>            Reporter: James Peach
>            Assignee: James Peach
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> glibc deprecated {{readdir_r}} for reasons explained in the [man page|http://man7.org/linux/man-pages/man3/readdir_r.3.html].
> {noformat}
> ../../mgmt/Rollback.cc  -fPIC -DPIC -o .libs/Rollback.o
> ../../mgmt/FileManager.cc: In member function 'SnapResult FileManager::removeSnap(const char*, const char*)':
> ../../mgmt/FileManager.cc:394:10: error: 'int readdir_r(DIR*, dirent*, dirent**)' is deprecated [-Werror=deprecated-declarations]
>   while (readdir_r(dir, dirEntrySpace, &entryPtr) == 0) {
>          ^~~~~~~~~
> In file included from ../../lib/ts/ink_platform.h:130:0,
>                 from ../../mgmt/FileManager.cc:24:
> /usr/include/dirent.h:183:12: note: declared here
> extern int readdir_r (DIR *__restrict __dirp,
>            ^~~~~~~~~
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)