You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/12/17 06:12:08 UTC
[GitHub] [kafka] dongxuwang opened a new pull request #9763: MINOR: Use ApiUtils' methods static imported consistently.
dongxuwang opened a new pull request #9763:
URL: https://github.com/apache/kafka/pull/9763
Because there have been using the static import methods of ApiUtils, it is not necessary to import the whole ApiUtils which also keeps the consistency.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 commented on pull request #9763: MINOR: Use ApiUtils' methods static imported consistently.
Posted by GitBox <gi...@apache.org>.
chia7712 commented on pull request #9763:
URL: https://github.com/apache/kafka/pull/9763#issuecomment-747848651
There are similar issues in ```KafkaStreams```, ```Materialized```, ```SessionWindows```, ```SlidingWindows```, ```TimeWindows```, ```ProcessorContextImpl``` and ```Stores```. Could you fix them as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dongxuwang commented on pull request #9763: MINOR: Use ApiUtils' methods static imported consistently.
Posted by GitBox <gi...@apache.org>.
dongxuwang commented on pull request #9763:
URL: https://github.com/apache/kafka/pull/9763#issuecomment-747869947
Sorry, didn't check others. Let me see and will push them on this branch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 merged pull request #9763: MINOR: Use ApiUtils' methods static imported consistently.
Posted by GitBox <gi...@apache.org>.
chia7712 merged pull request #9763:
URL: https://github.com/apache/kafka/pull/9763
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dongxuwang commented on pull request #9763: MINOR: Use ApiUtils' methods static imported consistently.
Posted by GitBox <gi...@apache.org>.
dongxuwang commented on pull request #9763:
URL: https://github.com/apache/kafka/pull/9763#issuecomment-749878096
@chia7712 Hi Ping, can you help review, thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dongxuwang edited a comment on pull request #9763: MINOR: Use ApiUtils' methods static imported consistently.
Posted by GitBox <gi...@apache.org>.
dongxuwang edited a comment on pull request #9763:
URL: https://github.com/apache/kafka/pull/9763#issuecomment-749878096
@chia7712 Hi Ping, can you help take a look, thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org