You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/02/23 07:01:32 UTC

[GitHub] [incubator-shardingsphere] terrymanu opened a new pull request #4414: Add SQL statement type into rule name

terrymanu opened a new pull request #4414: Add SQL statement type into rule name
URL: https://github.com/apache/incubator-shardingsphere/pull/4414
 
 
   For #4412.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4414: Add SQL statement type into rule name

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4414: Add SQL statement type into rule name
URL: https://github.com/apache/incubator-shardingsphere/pull/4414#issuecomment-590035285
 
 
   ## Pull Request Test Coverage Report for [Build 1841](https://coveralls.io/builds/28901639)
   
   * **51** of **88**   **(57.95%)**  changed or added relevant lines in **8** files are covered.
   * **2** unchanged lines in **1** file lost coverage.
   * Overall coverage increased (+**0.08%**) to **58.325%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/core/visitor/ParseTreeVisitorFactory.java](https://coveralls.io/builds/28901639/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fcore%2Fvisitor%2FParseTreeVisitorFactory.java#L45) | 0 | 2 | 0.0%
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/MySQLParserConfiguration.java](https://coveralls.io/builds/28901639/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2FMySQLParserConfiguration.java#L54) | 0 | 7 | 0.0%
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-oracle/src/main/java/org/apache/shardingsphere/sql/parser/OracleParserConfiguration.java](https://coveralls.io/builds/28901639/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-oracle%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2FOracleParserConfiguration.java#L54) | 0 | 7 | 0.0%
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-postgresql/src/main/java/org/apache/shardingsphere/sql/parser/PostgreSQLParserConfiguration.java](https://coveralls.io/builds/28901639/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2FPostgreSQLParserConfiguration.java#L54) | 0 | 7 | 0.0%
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-sql92/src/main/java/org/apache/shardingsphere/sql/parser/SQL92ParserConfiguration.java](https://coveralls.io/builds/28901639/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-sql92%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2FSQL92ParserConfiguration.java#L54) | 0 | 7 | 0.0%
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-sqlserver/src/main/java/org/apache/shardingsphere/sql/parser/SQLServerParserConfiguration.java](https://coveralls.io/builds/28901639/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-sqlserver%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2FSQLServerParserConfiguration.java#L54) | 0 | 7 | 0.0%
   <!-- | **Total:** | **51** | **88** | **57.95%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java](https://coveralls.io/builds/28901639/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Futil%2FIpUtils.java#L72) | 2 | 80.0% |
   <!-- | **Total:** | **2** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/28901639/badge)](https://coveralls.io/builds/28901639) |
   | :-- | --: |
   | Change from base [Build 9714](https://coveralls.io/builds/28901388): |  0.08% |
   | Covered Lines: | 10803 |
   | Relevant Lines: | 18522 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls commented on issue #4414: Add SQL statement type into rule name

Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #4414: Add SQL statement type into rule name
URL: https://github.com/apache/incubator-shardingsphere/pull/4414#issuecomment-590035285
 
 
   ## Pull Request Test Coverage Report for [Build 9715](https://coveralls.io/builds/28901629)
   
   * **51** of **88**   **(57.95%)**  changed or added relevant lines in **8** files are covered.
   * No unchanged relevant lines lost coverage.
   * Overall coverage increased (+**0.07%**) to **58.32%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/core/visitor/ParseTreeVisitorFactory.java](https://coveralls.io/builds/28901629/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fcore%2Fvisitor%2FParseTreeVisitorFactory.java#L45) | 0 | 2 | 0.0%
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/MySQLParserConfiguration.java](https://coveralls.io/builds/28901629/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2FMySQLParserConfiguration.java#L54) | 0 | 7 | 0.0%
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-oracle/src/main/java/org/apache/shardingsphere/sql/parser/OracleParserConfiguration.java](https://coveralls.io/builds/28901629/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-oracle%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2FOracleParserConfiguration.java#L54) | 0 | 7 | 0.0%
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-postgresql/src/main/java/org/apache/shardingsphere/sql/parser/PostgreSQLParserConfiguration.java](https://coveralls.io/builds/28901629/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2FPostgreSQLParserConfiguration.java#L54) | 0 | 7 | 0.0%
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-sql92/src/main/java/org/apache/shardingsphere/sql/parser/SQL92ParserConfiguration.java](https://coveralls.io/builds/28901629/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-sql92%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2FSQL92ParserConfiguration.java#L54) | 0 | 7 | 0.0%
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-sqlserver/src/main/java/org/apache/shardingsphere/sql/parser/SQLServerParserConfiguration.java](https://coveralls.io/builds/28901629/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-sqlserver%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2FSQLServerParserConfiguration.java#L54) | 0 | 7 | 0.0%
   <!-- | **Total:** | **51** | **88** | **57.95%** | -->
   
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/28901629/badge)](https://coveralls.io/builds/28901629) |
   | :-- | --: |
   | Change from base [Build 9714](https://coveralls.io/builds/28901388): |  0.07% |
   | Covered Lines: | 10802 |
   | Relevant Lines: | 18522 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] codecov-io commented on issue #4414: Add SQL statement type into rule name

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4414: Add SQL statement type into rule name
URL: https://github.com/apache/incubator-shardingsphere/pull/4414#issuecomment-590035075
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4414?src=pr&el=h1) Report
   > Merging [#4414](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4414?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/d7c4789fddd77e98dfce1f0871910d2c0dd1189b?src=pr&el=desc) will **increase** coverage by `0.06%`.
   > The diff coverage is `57.95%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4414/graphs/tree.svg?width=650&token=ZvlXpWa7so&height=150&src=pr)](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4414?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #4414      +/-   ##
   ============================================
   + Coverage     54.67%   54.74%   +0.06%     
     Complexity      332      332              
   ============================================
     Files           952      953       +1     
     Lines         18542    18522      -20     
     Branches       3453     3436      -17     
   ============================================
   + Hits          10138    10140       +2     
   + Misses         7753     7731      -22     
     Partials        651      651
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4414?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...here/sql/parser/PostgreSQLParserConfiguration.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4414/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXBvc3RncmVzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NxbC9wYXJzZXIvUG9zdGdyZVNRTFBhcnNlckNvbmZpZ3VyYXRpb24uamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...l/parser/core/visitor/ParseTreeVisitorFactory.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4414/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9jb3JlL3Zpc2l0b3IvUGFyc2VUcmVlVmlzaXRvckZhY3RvcnkuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...ingsphere/sql/parser/MySQLParserConfiguration.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4414/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLW15c3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcWwvcGFyc2VyL015U1FMUGFyc2VyQ29uZmlndXJhdGlvbi5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...ingsphere/sql/parser/SQL92ParserConfiguration.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4414/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXNxbDkyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcWwvcGFyc2VyL1NRTDkyUGFyc2VyQ29uZmlndXJhdGlvbi5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...phere/sql/parser/SQLServerParserConfiguration.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4414/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXNxbHNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9TUUxTZXJ2ZXJQYXJzZXJDb25maWd1cmF0aW9uLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...ngsphere/sql/parser/OracleParserConfiguration.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4414/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLW9yYWNsZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9PcmFjbGVQYXJzZXJDb25maWd1cmF0aW9uLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...ere/sql/parser/sql/statement/SQLStatementType.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4414/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvc3RhdGVtZW50L1NRTFN0YXRlbWVudFR5cGUuamF2YQ==) | `100% <100%> (ø)` | `0 <0> (?)` | |
   | [...rdingsphere/sql/parser/core/constant/RuleName.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4414/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9jb3JlL2NvbnN0YW50L1J1bGVOYW1lLmphdmE=) | `100% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4414?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4414?src=pr&el=footer). Last update [d7c4789...d583532](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4414?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] tristaZero merged pull request #4414: Add SQL statement type into rule name

Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #4414: Add SQL statement type into rule name
URL: https://github.com/apache/incubator-shardingsphere/pull/4414
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services