You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/06/09 17:20:52 UTC
[GitHub] [beam] damccorm opened a new pull request, #21775: Stop collecting jira metrics
damccorm opened a new pull request, #21775:
URL: https://github.com/apache/beam/pull/21775
Once we merge #21771 and have observed that it works for a little bit, we can get rid of our jira metric collection.
Fixes #21735
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [x] Add a link to the appropriate issue in your description, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [x] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on a diff in pull request #21775: Stop collecting jira metrics
Posted by GitBox <gi...@apache.org>.
damccorm commented on code in PR #21775:
URL: https://github.com/apache/beam/pull/21775#discussion_r894591347
##########
.test-infra/metrics/sync/github/queries.py:
##########
@@ -123,7 +123,7 @@
MAIN_ISSUES_QUERY = '''
query {
search(
- query: "type:issue repo:apache/beam created:><TemstampSubstitueLocation> sort:updated-asc"
+ query: "type:issue repo:apache/beam updated:><TemstampSubstitueLocation> sort:updated-asc"
Review Comment:
This is so that we actually notice when we close or relabel an issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #21775: Stop collecting jira metrics
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #21775:
URL: https://github.com/apache/beam/pull/21775#issuecomment-1151397321
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kileys merged pull request #21775: Stop collecting jira metrics
Posted by GitBox <gi...@apache.org>.
kileys merged PR #21775:
URL: https://github.com/apache/beam/pull/21775
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on a diff in pull request #21775: Stop collecting jira metrics
Posted by GitBox <gi...@apache.org>.
damccorm commented on code in PR #21775:
URL: https://github.com/apache/beam/pull/21775#discussion_r893919601
##########
.test-infra/metrics/grafana/dashboards/post-commit_tests.json:
##########
@@ -835,7 +835,7 @@
"hide": false,
"metricColumn": "none",
"rawQuery": true,
- "rawSql": "with days as (select date_trunc('day', dd) as day from generate_series( $__timeFrom()::timestamp, $__timeTo()::timestamp, '1 day'::interval) as dd),\n knowndays as (SELECT days.day, count(*) as currently_failing\n FROM jira_issues, days\n WHERE jira_issues.created < days.day AND (jira_issues.resolutiondate > days.day OR jira_issues.resolutiondate is null) AND (jira_issues.labels LIKE '%currently-failing%')\n GROUP BY days.day\n ORDER BY days.day)\nselect days.day as time, greatest(knowndays.currently_failing, 0) as currently_failing\nfrom days left outer join knowndays\non days.day = knowndays.day",
+ "rawSql": "with days as (select date_trunc('day', dd) as day from generate_series( $__timeFrom()::timestamp, $__timeTo()::timestamp, '1 day'::interval) as dd),\n knowndays as (SELECT days.day, count(*) as currently_failing\n FROM jira_issues, days\n WHERE jira_issues.created < days.day AND (jira_issues.resolutiondate > days.day OR jira_issues.resolutiondate is null) AND (jira_issues.labels @> ARRAY['currently-failing'])\n GROUP BY days.day\n ORDER BY days.day)\nselect days.day as time, greatest(knowndays.currently_failing, 0) as currently_failing\nfrom days left outer join knowndays\non days.day = knowndays.day",
Review Comment:
Note that I updated to `@>` which is the [postgresql contains operator](https://www.postgresql.org/docs/9.5/functions-array.html) because labels is actually a varchar[] not a varchar.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #21775: Stop collecting jira metrics
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #21775:
URL: https://github.com/apache/beam/pull/21775#issuecomment-1151397329
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on a diff in pull request #21775: Stop collecting jira metrics
Posted by GitBox <gi...@apache.org>.
damccorm commented on code in PR #21775:
URL: https://github.com/apache/beam/pull/21775#discussion_r893919601
##########
.test-infra/metrics/grafana/dashboards/post-commit_tests.json:
##########
@@ -835,7 +835,7 @@
"hide": false,
"metricColumn": "none",
"rawQuery": true,
- "rawSql": "with days as (select date_trunc('day', dd) as day from generate_series( $__timeFrom()::timestamp, $__timeTo()::timestamp, '1 day'::interval) as dd),\n knowndays as (SELECT days.day, count(*) as currently_failing\n FROM jira_issues, days\n WHERE jira_issues.created < days.day AND (jira_issues.resolutiondate > days.day OR jira_issues.resolutiondate is null) AND (jira_issues.labels LIKE '%currently-failing%')\n GROUP BY days.day\n ORDER BY days.day)\nselect days.day as time, greatest(knowndays.currently_failing, 0) as currently_failing\nfrom days left outer join knowndays\non days.day = knowndays.day",
+ "rawSql": "with days as (select date_trunc('day', dd) as day from generate_series( $__timeFrom()::timestamp, $__timeTo()::timestamp, '1 day'::interval) as dd),\n knowndays as (SELECT days.day, count(*) as currently_failing\n FROM jira_issues, days\n WHERE jira_issues.created < days.day AND (jira_issues.resolutiondate > days.day OR jira_issues.resolutiondate is null) AND (jira_issues.labels @> ARRAY['currently-failing'])\n GROUP BY days.day\n ORDER BY days.day)\nselect days.day as time, greatest(knowndays.currently_failing, 0) as currently_failing\nfrom days left outer join knowndays\non days.day = knowndays.day",
Review Comment:
Note that I updated to `@>` which is the [postgresql contains operator](https://www.postgresql.org/docs/9.5/functions-array.html) because labels is actually a varchar[] not a varchar.
I haven't been able to get my test env quite right for this, but this should do no harm since its currently failing http://104.154.241.245/d/D81lW0pmk/post-commit-test-reliability?orgId=1&inspect=14&inspectTab=error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #21775: Stop collecting jira metrics
Posted by GitBox <gi...@apache.org>.
damccorm commented on PR #21775:
URL: https://github.com/apache/beam/pull/21775#issuecomment-1151602396
R: @kileys
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org